From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3574 invoked by alias); 20 Oct 2016 09:19:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2726 invoked by uid 89); 20 Oct 2016 09:19:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:2034 X-HELO: mail-qk0-f177.google.com Received: from mail-qk0-f177.google.com (HELO mail-qk0-f177.google.com) (209.85.220.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Oct 2016 09:19:42 +0000 Received: by mail-qk0-f177.google.com with SMTP id o68so81842094qkf.3 for ; Thu, 20 Oct 2016 02:19:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=hS99/5fih9HV4N3J7uC0nuMXLRMD7U/hD7XQD7GLNOE=; b=HlYp018cn91IhtfXYMNeAKV1hVJh6qQWBgacCKch5gE+yIVF4jNvIv4cNJZ27Js8C8 54LZdsF6VH8yjeJj5RxPQYd/NfEKcQY+FI7xIzNaFw2L/Nb3IUdHX2JuZ/C40z01/JTO B16mXylUfgc4REDLPGx7TNa19YPPm0SKkwlD6hF0XkO5Bd11fqr3Z5n8n/lbaDA0y56v MC/SnY5Fd+xyLlluApNUiVAeFn5TKT8QI839SYe55R2vZurE+sf5tNi00c8d8/saB0zj VHhyVxE4e0GN102L4Xh4qvBc53EU1Dihg4nai8NgWJemhsKlwFZCHAnyL+9vkjBmQm8Z 2mDA== X-Gm-Message-State: ABUngvdjJMOXiNARNhyGwm6RNAmkxCbbwJLwhVxW1jJaqhpnnL2tfsChvvPST8ap6wxNR2oi+QiDM5JH5zltNA6T X-Received: by 10.55.105.130 with SMTP id e124mr11290276qkc.278.1476955180579; Thu, 20 Oct 2016 02:19:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.43.116 with HTTP; Thu, 20 Oct 2016 02:19:39 -0700 (PDT) In-Reply-To: References: From: Christophe Lyon Date: Thu, 20 Oct 2016 09:19:00 -0000 Message-ID: Subject: Re: [libstdc++, testsuite] Add dg-require-thread-fence To: Jonathan Wakely , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg01603.txt.bz2 On 20 October 2016 at 09:55, Christophe Lyon wrote: > Hi, > > Several times I have noticed/reported test failures because some test > cases wouldn't link on arm-none-eabi using the default 'old' cpu > target: __sync_synchronize cannot be resolved by the linker. > > The attached long patch adds > +// { dg-require-thread-fence "" } > to all the tests that require it according to the error messages I get. > > The change is mechanical: > - insert this line below dg-do if present > - insert this line at the top of the file otherwise > > For instance: > > diff --git a/libstdc++-v3/testsuite/18_support/bad_typeid/what.cc > b/libstdc++-v3/testsuite/18_support/bad_typeid/what.cc > index 633175b..a048250 100644 > --- a/libstdc++-v3/testsuite/18_support/bad_typeid/what.cc > +++ b/libstdc++-v3/testsuite/18_support/bad_typeid/what.cc > @@ -1,3 +1,4 @@ > +// { dg-require-thread-fence "" } > // 2007-01-30 Paolo Carlini > > // Copyright (C) 2007-2016 Free Software Foundation, Inc. > diff --git a/libstdc++-v3/testsuite/18_support/cxa_vec.cc > b/libstdc++-v3/testsuite/18_support/cxa_vec.cc > index e712655..f2a6c5a 100644 > --- a/libstdc++-v3/testsuite/18_support/cxa_vec.cc > +++ b/libstdc++-v3/testsuite/18_support/cxa_vec.cc > @@ -1,4 +1,5 @@ > // { dg-do run } > +// { dg-require-thread-fence "" } > // Avoid use of non-overridable new/delete operators in shared > // { dg-options "-static" { target *-*-mingw* } } > // Test __cxa_vec routines > > > If that's OK, I'm not sure how to write the ChangeLog entry: it > modifies 3287 files. > > In my testing, it replaces 3287 FAILs by 3287 UNSUPPORTED. > > > OK? > Jonathan, The new test you introduced yesterday would need a similar fix: experimental/memory/shared_ptr/cons/enable_shared_from_this.cc Christophe > Other question: I've noticed similar errors in the g++ validation, but > I'm not sure what is the corresponding dg-require directive? > > Thanks, > > Christophe