From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120156 invoked by alias); 10 Jan 2019 15:46:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 120145 invoked by uid 89); 10 Jan 2019 15:46:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:insert_, UD:bti-1.c, UD:bti-3.c, H*f:sk:fd1cb81 X-HELO: mail-ua1-f67.google.com Received: from mail-ua1-f67.google.com (HELO mail-ua1-f67.google.com) (209.85.222.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Jan 2019 15:46:15 +0000 Received: by mail-ua1-f67.google.com with SMTP id d2so3739256ual.2 for ; Thu, 10 Jan 2019 07:46:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n96LhmYZN7Q5+3K8mcYQ4OZCiFg5AbCDmZ5ownJDS58=; b=CwUnh6zC4/CHLe5guIsDrFHqnl3vJSgJN6gdpLCGemzOp6LaRUbGBAaAqJg95qiAbq iDbsQghdXwve5HIBIosa1l1u3BUwPreL3q99xwJiI0fw35KMebgbt+oWich3dQTZP5zm u1KWkI5tALoD+XRVMzl46JS8DUzKJi5V4CKQY= MIME-Version: 1.0 References: <520262f0-989a-fa92-5d5f-fa7c90d77198@arm.com> <4a091322-c031-ced1-a78b-dd45316d8c7c@arm.com> <20181219154057.GA21219@arm.com> <864f7e46-bf8d-717a-86a7-79b31aa15246@arm.com> In-Reply-To: <864f7e46-bf8d-717a-86a7-79b31aa15246@arm.com> From: Christophe Lyon Date: Thu, 10 Jan 2019 15:46:00 -0000 Message-ID: Subject: Re: [PATCH, GCC, AARCH64, 5/6] Enable BTI : Add new pass for BTI. To: Sudakshina Das Cc: James Greenhalgh , "gcc-patches@gcc.gnu.org" , nd , Richard Earnshaw , Marcus Shawcroft Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00556.txt.bz2 On Wed, 9 Jan 2019 at 15:42, Sudakshina Das wrote: > > Hi > > On 20/12/18 16:40, Sudakshina Das wrote: > > Hi James > > > > On 19/12/18 3:40 PM, James Greenhalgh wrote: > >> On Fri, Dec 14, 2018 at 10:09:03AM -0600, Sudakshina Das wrote: > >> > >> > >> > >>> I have updated the patch according to our discussions offline. > >>> The md pattern is now split into 4 patterns and i have added a new > >>> test for the setjmp case along with some comments where missing. > >> > >> This is OK for trunk. > >> > > > > Thanks for the approvals. With this my series is ready to go in trunk. I > > will wait for Sam's options patch to go in trunk before I commit mine. > > > > Series is committed with a rebase without Sam Tebbs's 3rd patch for > B-Key addition as r267765 to r267770. > > Thanks > Sudi > Hi Sudi, I think the new bti-1.c test lacks /* { dg-require-effective-target lp64 } */ as I see it failing when using -mabi=ilp32: cc1: sorry, unimplemented: return address signing is only supported for -mabi=lp64 Christophe > > Thanks > > Sudi > > > >> Thanks, > >> James > >> > >>> *** gcc/ChangeLog *** > >>> > >>> 2018-xx-xx Sudakshina Das > >>> Ramana Radhakrishnan > >>> > >>> * config.gcc (aarch64*-*-*): Add aarch64-bti-insert.o. > >>> * gcc/config/aarch64/aarch64.h: Update comment for > >>> TRAMPOLINE_SIZE. > >>> * config/aarch64/aarch64.c (aarch64_asm_trampoline_template): > >>> Update if bti is enabled. > >>> * config/aarch64/aarch64-bti-insert.c: New file. > >>> * config/aarch64/aarch64-passes.def (INSERT_PASS_BEFORE): Insert > >>> bti pass. > >>> * config/aarch64/aarch64-protos.h (make_pass_insert_bti): > >>> Declare the new bti pass. > >>> * config/aarch64/aarch64.md (unspecv): Add UNSPECV_BTI_NOARG, > >>> UNSPECV_BTI_C, UNSPECV_BTI_J and UNSPECV_BTI_JC. > >>> (bti_noarg, bti_j, bti_c, bti_jc): New define_insns. > >>> * config/aarch64/t-aarch64: Add rule for aarch64-bti-insert.o. > >>> > >>> *** gcc/testsuite/ChangeLog *** > >>> > >>> 2018-xx-xx Sudakshina Das > >>> > >>> * gcc.target/aarch64/bti-1.c: New test. > >>> * gcc.target/aarch64/bti-2.c: New test. > >>> * gcc.target/aarch64/bti-3.c: New test. > >>> * lib/target-supports.exp > >>> (check_effective_target_aarch64_bti_hw): Add new check for > >>> BTI hw. > >>> > >>> Thanks > >>> Sudi >