public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Christophe Lyon <christophe.lyon@linaro.org>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
Cc: Christophe Lyon <christophe.lyon@st.com>,
		"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [ARM/FDPIC v5 20/21] [ARM][testsuite] FDPIC: Skip tests using architectures unsupported by FDPIC
Date: Fri, 06 Sep 2019 09:10:00 -0000	[thread overview]
Message-ID: <CAKdteObQ=rk+OFehrRFbLxKLn2_T+r=gjv8bjvQpP+MP+MsmyQ@mail.gmail.com> (raw)
In-Reply-To: <aaa0ec4f-6ef6-3004-a78b-bf4fa080e25b@foss.arm.com>

On Fri, 6 Sep 2019 at 10:28, Kyrill Tkachov <kyrylo.tkachov@foss.arm.com> wrote:
>
>
> On 9/6/19 9:01 AM, Christophe Lyon wrote:
> > On Fri, 19 Jul 2019 at 11:00, Kyrill Tkachov
> > <kyrylo.tkachov@foss.arm.com> wrote:
> >>
> >> On 5/15/19 1:39 PM, Christophe Lyon wrote:
> >>> Since FDPIC currently supports arm and thumb-2 modes only, these tests
> >>> fail because they enforce an architecture version that doesn't match
> >>> these restrictions.
> >>>
> >>> This patch introduces new values for the arm_arch effective-target
> >>> (v4t_thumb, v5t_thumb, v5te_thumb, v6_thumb, v6k_thumb, v6z_thumb) as
> >>> needed, and adds them to the relevant tests.  It also adds the
> >>> corresponding non-thumb effective-target to the tests that were
> >>> missing it.
> >>>
> >>> 2019-XX-XX  Christophe Lyon  <christophe.lyon@st.com>
> >>>
> >>>          * lib/target-supports.exp
> >>>          (check_effective_target_arm_arch_FUNC_ok): Add v4t_thumb,
> >>>          v5t_thumb, v5te_thumb, v6_thumb, v6k_thumb, v6z_thumb.
> >>>          * gcc.target/arm/armv6-unaligned-load-ice.c: Add arm_arch
> >>>          effective-target.
> >>>          * gcc.target/arm/attr-unaligned-load-ice.c: Likewise.
> >>>          * gcc.target/arm/attr_arm-err.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv4-arm.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv4t-arm.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv4t-thumb.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv5t-arm.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv5t-thumb.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv5te-arm.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv5te-thumb.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv6-arm.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv6-thumb.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv6k-arm.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv6k-thumb.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv6m-thumb.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv6t2-arm.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv6t2-thumb.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv6z-arm.c: Likewise.
> >>>          * gcc.target/arm/ftest-armv6z-thumb.c: Likewise.
> >>>          * gcc.target/arm/g2.c: Likewise.
> >>>          * gcc.target/arm/macro_defs1.c: Likewise.
> >>>          * gcc.target/arm/pr59858.c: Likewise.
> >>>          * gcc.target/arm/pr65647-2.c: Likewise.
> >>>          * gcc.target/arm/pr79058.c: Likewise.
> >>>          * gcc.target/arm/pr83712.c: Likewise.
> >>>          * gcc.target/arm/pragma_arch_switch_2.c: Likewise.
> >>>          * gcc.target/arm/scd42-1.c: Likewise.
> >>>          * gcc.target/arm/scd42-2.c: Likewise.
> >>>          * gcc.target/arm/scd42-3.c: Likewise.
> >>>          * gcc.c-torture/compile/pr82096.c: Fix arm_arch effective-target.
> >>>
> >> Ok.
> >>
> >> This looks like a good improvement on its own.
> >>
> > Sigh, after more testing I found problems :(
> >
> >> Thanks,
> >>
> >> Kyrill
> >>
> >>
> >>
> >>> Change-Id: I0845b262b241026561cc52a19ff8bb1659675e49
> >>>
> >>> diff --git a/gcc/testsuite/gcc.c-torture/compile/pr82096.c
> >>> b/gcc/testsuite/gcc.c-torture/compile/pr82096.c
> >>> index d144b70..4e695cd 100644
> >>> --- a/gcc/testsuite/gcc.c-torture/compile/pr82096.c
> >>> +++ b/gcc/testsuite/gcc.c-torture/compile/pr82096.c
> >>> @@ -1,4 +1,4 @@
> >>> -/* { dg-require-effective-target arm_arch_v5t_ok { target arm*-*-* } } */
> >>> +/* { dg-require-effective-target arm_arch_v5t_thumb_ok { target
> >>> arm*-*-* } } */
> >>>   /* { dg-skip-if "Do not combine float-abi values" { arm*-*-* } {
> >>> "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */
> >>>   /* { dg-additional-options "-march=armv5t -mthumb -mfloat-abi=soft" {
> >>> target arm*-*-* } } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/armv6-unaligned-load-ice.c
> >>> b/gcc/testsuite/gcc.target/arm/armv6-unaligned-load-ice.c
> >>> index 88528f1..886a012 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/armv6-unaligned-load-ice.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/armv6-unaligned-load-ice.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv6k" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-marm" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v6k_thumb_ok } */
> >>>   /* { dg-options "-mthumb -Os -mfloat-abi=softfp" } */
> >>>   /* { dg-add-options arm_arch_v6k } */
> >>>
> > For instance on arm-linux-gnueabihf (thus defaulting to float-abi=hard),
> > arm_arch_v6k_thumb fails (because it tries to use thumb-1 + hard-float
> > which is not supported),
> > while the test itself would add -mfloat-abi=softfp, thus using a
> > supported configuration.
> >
> > Is there a way to pass an argument to an effective-target directive?
> > (current, if one adds an argument, it's the target selector)
> >
> > Or shall I add other effective-targets, eg arm_arch_v6k_thumb_softfp_ok?
>
> Sigh, at this point I'm thinking maybe we should have a
> arm_arch_v6k_thumb target that basically assumes/forces softfp.
>

Sure, I can add:
 +       v6k_thumb "-march=armv6k -mthumb -mfloat-abi=softfp" __ARM_ARCH_6K__
instead of
 +       v6k_thumb "-march=armv6k -mthumb" __ARM_ARCH_6K__
as the original patch does.

But isn't there a risk of conflict on toolchains configured for
hard-float or testcases enforcing it?
And... I suppose I should to the same for v4t_thumb, v5t_thumb,
v5te_thumb, v6_thumb and v6z_thumb?

I see that v6m/v8m_base already forces float-abi=soft....

Christophe



> Thanks,
>
> Kyrill
>
>
> >
> > Christophe
> >
> >>> diff --git a/gcc/testsuite/gcc.target/arm/attr-unaligned-load-ice.c
> >>> b/gcc/testsuite/gcc.target/arm/attr-unaligned-load-ice.c
> >>> index e1ed1c1..2eeb522 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/attr-unaligned-load-ice.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/attr-unaligned-load-ice.c
> >>> @@ -2,6 +2,7 @@
> >>>      Verify that unaligned_access is correctly with attribute target.  */
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv6" } } */
> >>> +/* { dg-require-effective-target arm_arch_v6_ok } */
> >>>   /* { dg-options "-Os -mfloat-abi=softfp -mtp=soft" } */
> >>>   /* { dg-add-options arm_arch_v6 } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/attr_arm-err.c
> >>> b/gcc/testsuite/gcc.target/arm/attr_arm-err.c
> >>> index 630c06a..d410056 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/attr_arm-err.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/attr_arm-err.c
> >>> @@ -2,6 +2,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-require-effective-target arm_arm_ok } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv6-m" } } */
> >>> +/* { dg-require-effective-target arm_arch_v6m_ok } */
> >>>   /* { dg-add-options arm_arch_v6m } */
> >>>
> >>>   int __attribute__((target("arm")))
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv4-arm.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv4-arm.c
> >>> index 4b48ef8..447a8ec 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv4-arm.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv4-arm.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv4" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-mthumb" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v4_ok } */
> >>>   /* { dg-options "-marm" } */
> >>>   /* { dg-add-options arm_arch_v4 } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv4t-arm.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv4t-arm.c
> >>> index 016506f..05db533 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv4t-arm.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv4t-arm.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv4t" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-mthumb" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v4t_ok } */
> >>>   /* { dg-options "-marm" } */
> >>>   /* { dg-add-options arm_arch_v4t } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv4t-thumb.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv4t-thumb.c
> >>> index 9ef944e..78878f7 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv4t-thumb.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv4t-thumb.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv4t" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-marm" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v4t_thumb_ok } */
> >>>   /* { dg-options "-mthumb" } */
> >>>   /* { dg-add-options arm_arch_v4t } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv5t-arm.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv5t-arm.c
> >>> index a9403e9..bea25d09 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv5t-arm.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv5t-arm.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv5t" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-mthumb" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v5t_ok } */
> >>>   /* { dg-options "-marm" } */
> >>>   /* { dg-add-options arm_arch_v5t } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv5t-thumb.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv5t-thumb.c
> >>> index f3ad07e..b25d17d 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv5t-thumb.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv5t-thumb.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv5t" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-marm" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v5t_thumb_ok } */
> >>>   /* { dg-options "-mthumb" } */
> >>>   /* { dg-add-options arm_arch_v5t } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv5te-arm.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv5te-arm.c
> >>> index f98c01a..7b37c7f 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv5te-arm.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv5te-arm.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv5te" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-mthumb" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v5te_ok } */
> >>>   /* { dg-options "-marm" } */
> >>>   /* { dg-add-options arm_arch_v5te } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv5te-thumb.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv5te-thumb.c
> >>> index 5d71787..27a64a2 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv5te-thumb.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv5te-thumb.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv5te" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-marm" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v5te_thumb_ok } */
> >>>   /* { dg-options "-mthumb" } */
> >>>   /* { dg-add-options arm_arch_v5te } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv6-arm.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv6-arm.c
> >>> index 88a5089..bfab765 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv6-arm.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv6-arm.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv6" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-mthumb" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v6_ok } */
> >>>   /* { dg-options "-marm" } */
> >>>   /* { dg-add-options arm_arch_v6 } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv6-thumb.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv6-thumb.c
> >>> index 90ef9d2..15a6d75 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv6-thumb.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv6-thumb.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv6" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-marm" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v6_thumb_ok } */
> >>>   /* { dg-options "-mthumb" } */
> >>>   /* { dg-add-options arm_arch_v6 } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv6k-arm.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv6k-arm.c
> >>> index 8de021a..721c9f9 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv6k-arm.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv6k-arm.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv6k" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-mthumb" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v6k_ok } */
> >>>   /* { dg-options "-marm" } */
> >>>   /* { dg-add-options arm_arch_v6k } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv6k-thumb.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv6k-thumb.c
> >>> index c2fc270..b3b6ecf 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv6k-thumb.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv6k-thumb.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv6k" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-marm" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v6k_thumb_ok } */
> >>>   /* { dg-options "-mthumb" } */
> >>>   /* { dg-add-options arm_arch_v6k } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv6m-thumb.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv6m-thumb.c
> >>> index ee075e2..27f71be 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv6m-thumb.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv6m-thumb.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv6-m" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-marm" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v6m_ok } */
> >>>   /* { dg-options "-mthumb" } */
> >>>   /* { dg-add-options arm_arch_v6m } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv6t2-arm.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv6t2-arm.c
> >>> index 83b4bc4..259d2b5 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv6t2-arm.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv6t2-arm.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv6t2" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-mthumb" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v6t2_ok } */
> >>>   /* { dg-options "-marm" } */
> >>>   /* { dg-add-options arm_arch_v6t2 } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv6t2-thumb.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv6t2-thumb.c
> >>> index 1a1cbc5..e624ec5 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv6t2-thumb.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv6t2-thumb.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv6t2" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-marm" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v6t2_ok } */
> >>>   /* { dg-options "-mthumb" } */
> >>>   /* { dg-add-options arm_arch_v6t2 } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv6z-arm.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv6z-arm.c
> >>> index e2df0d4..66380bf 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv6z-arm.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv6z-arm.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv6z" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-mthumb" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v6z_ok } */
> >>>   /* { dg-options "-marm" } */
> >>>   /* { dg-add-options arm_arch_v6z } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/ftest-armv6z-thumb.c
> >>> b/gcc/testsuite/gcc.target/arm/ftest-armv6z-thumb.c
> >>> index e4b94ef..23a4fcd 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/ftest-armv6z-thumb.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/ftest-armv6z-thumb.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv6z" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-marm" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v6z_thumb_ok } */
> >>>   /* { dg-options "-mthumb" } */
> >>>   /* { dg-add-options arm_arch_v6z } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/g2.c
> >>> b/gcc/testsuite/gcc.target/arm/g2.c
> >>> index e368017..da68c8b 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/g2.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/g2.c
> >>> @@ -4,6 +4,7 @@
> >>>   /* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } {
> >>> "-march=*" } { "-march=xscale" } } */
> >>>   /* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } {
> >>> "-mcpu=*" } { "-mcpu=xscale" } } */
> >>>   /* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } {
> >>> "-mthumb" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v5te_ok } */
> >>>   /* { dg-require-effective-target arm32 } */
> >>>
> >>>   /* Brett Gaines' test case. */
> >>> diff --git a/gcc/testsuite/gcc.target/arm/macro_defs1.c
> >>> b/gcc/testsuite/gcc.target/arm/macro_defs1.c
> >>> index 4cc9ae6..655ba93 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/macro_defs1.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/macro_defs1.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-march=*" } { "-march=armv6-m" } } */
> >>>   /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
> >>> "-marm" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v6m_ok } */
> >>>   /* { dg-options "-march=armv6-m -mthumb" } */
> >>>
> >>>   #ifdef __ARM_NEON_FP
> >>> diff --git a/gcc/testsuite/gcc.target/arm/pr59858.c
> >>> b/gcc/testsuite/gcc.target/arm/pr59858.c
> >>> index a944b9a..bcfd5d5 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/pr59858.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/pr59858.c
> >>> @@ -1,6 +1,7 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-options "-march=armv5te -fno-builtin -mfloat-abi=soft -mthumb
> >>> -fno-stack-protector -Os -fno-tree-loop-optimize
> >>> -fno-tree-dominator-opts -fPIC -w" } */
> >>>   /* { dg-skip-if "Incompatible command line options: -mfloat-abi=soft
> >>> -mfloat-abi=hard" { *-*-* } { "-mfloat-abi=hard" } { "" } } */
> >>> +/* { dg-require-effective-target arm_arch_v5te_thumb_ok } */
> >>>
> >>>   typedef enum {
> >>>    REG_ENOSYS = -1,
> >>> diff --git a/gcc/testsuite/gcc.target/arm/pr65647-2.c
> >>> b/gcc/testsuite/gcc.target/arm/pr65647-2.c
> >>> index f2985f8..3d9e75f 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/pr65647-2.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/pr65647-2.c
> >>> @@ -1,4 +1,5 @@
> >>>   /* { dg-do compile } */
> >>> +/* { dg-require-effective-target arm_arch_v6_ok } */
> >>>   /* { dg-options "-O3 -marm -march=armv6 -std=c99" } */
> >>>
> >>>   typedef struct {
> >>> diff --git a/gcc/testsuite/gcc.target/arm/pr79058.c
> >>> b/gcc/testsuite/gcc.target/arm/pr79058.c
> >>> index 54a1d8a..7d078ac 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/pr79058.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/pr79058.c
> >>> @@ -1,5 +1,6 @@
> >>>   /* { dg-do compile } */
> >>>   /* { dg-require-effective-target arm_arm_ok } */
> >>> +/* { dg-require-effective-target arm_arch_v4_ok } */
> >>>   /* { dg-skip-if "do not override -mcpu" { *-*-* } { "-mcpu=*" } {
> >>> "-mcpu=arm7tdmi" } } */
> >>>   /* { dg-options "-Os -mbig-endian -marm -mcpu=arm7tdmi" } */
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/pr83712.c
> >>> b/gcc/testsuite/gcc.target/arm/pr83712.c
> >>> index 8ed8cdf..4902ec9 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/pr83712.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/pr83712.c
> >>> @@ -1,4 +1,5 @@
> >>>   /* { dg-do compile } */
> >>> +/* { dg-require-effective-target arm_arch_v5t_thumb_ok } */
> >>>   /* { dg-options "-mfloat-abi=softfp -mthumb -march=armv5t -O2" }  */
> >>>   #pragma GCC optimize ("-O2")
> >>>
> >>> diff --git a/gcc/testsuite/gcc.target/arm/pragma_arch_switch_2.c
> >>> b/gcc/testsuite/gcc.target/arm/pragma_arch_switch_2.c
> >>> index b6211f9..c3361e7 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/pragma_arch_switch_2.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/pragma_arch_switch_2.c
> >>> @@ -2,6 +2,7 @@
> >>>   /* { dg-skip-if "instruction not valid on thumb" { *-*-* } {
> >>> "-mthumb" } { "" } } */
> >>>   /* { dg-do assemble } */
> >>>   /* { dg-require-effective-target arm_arm_ok } */
> >>> +/* { dg-require-effective-target arm_arch_v5te_ok } */
> >>>   /* { dg-additional-options "-Wall -O2 -march=armv5te -std=gnu99
> >>> -marm" } */
> >>>
> >>>   #pragma GCC target ("arch=armv6")
> >>> diff --git a/gcc/testsuite/gcc.target/arm/scd42-1.c
> >>> b/gcc/testsuite/gcc.target/arm/scd42-1.c
> >>> index be60e64..2b8fc0b 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/scd42-1.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/scd42-1.c
> >>> @@ -3,6 +3,7 @@
> >>>   /* { dg-skip-if "Test is specific to Xscale" { arm*-*-* } {
> >>> "-march=*" } { "-march=xscale" } } */
> >>>   /* { dg-skip-if "Test is specific to Xscale" { arm*-*-* } { "-mcpu=*"
> >>> } { "-mcpu=xscale" } } */
> >>>   /* { dg-skip-if "do not override -mfloat-abi" { *-*-* } {
> >>> "-mfloat-abi=*" } { "-mfloat-abi=softfp" } } */
> >>> +/* { dg-require-effective-target arm_arch_v5te_ok } */
> >>>   /* { dg-options "-mcpu=xscale -O -mfloat-abi=softfp" } */
> >>>
> >>>   unsigned load1(void) __attribute__ ((naked));
> >>> diff --git a/gcc/testsuite/gcc.target/arm/scd42-2.c
> >>> b/gcc/testsuite/gcc.target/arm/scd42-2.c
> >>> index 6d9e5e1..4181a75 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/scd42-2.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/scd42-2.c
> >>> @@ -4,6 +4,7 @@
> >>>   /* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } {
> >>> "-mcpu=*" } { "-mcpu=xscale" } } */
> >>>   /* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } {
> >>> "-mthumb" } { "" } } */
> >>>   /* { dg-require-effective-target arm32 } */
> >>> +/* { dg-require-effective-target arm_arch_v5te_ok } */
> >>>   /* { dg-options "-mcpu=xscale -O -marm" } */
> >>>
> >>>   unsigned load2(void) __attribute__ ((naked));
> >>> diff --git a/gcc/testsuite/gcc.target/arm/scd42-3.c
> >>> b/gcc/testsuite/gcc.target/arm/scd42-3.c
> >>> index e566cb2..0afd121 100644
> >>> --- a/gcc/testsuite/gcc.target/arm/scd42-3.c
> >>> +++ b/gcc/testsuite/gcc.target/arm/scd42-3.c
> >>> @@ -3,6 +3,7 @@
> >>>   /* { dg-skip-if "Test is specific to Xscale" { arm*-*-* } {
> >>> "-march=*" } { "-march=xscale" } } */
> >>>   /* { dg-skip-if "Test is specific to Xscale" { arm*-*-* } { "-mcpu=*"
> >>> } { "-mcpu=xscale" } } */
> >>>   /* { dg-skip-if "do not override -mfloat-abi" { *-*-* } {
> >>> "-mfloat-abi=*" } { "-mfloat-abi=softfp" } } */
> >>> +/* { dg-require-effective-target arm_arch_v5te_ok } */
> >>>   /* { dg-options "-mcpu=xscale -O -mfloat-abi=softfp" } */
> >>>
> >>>   unsigned load4(void) __attribute__ ((naked));
> >>> diff --git a/gcc/testsuite/lib/target-supports.exp
> >>> b/gcc/testsuite/lib/target-supports.exp
> >>> index 60d68f4..3f091c5 100644
> >>> --- a/gcc/testsuite/lib/target-supports.exp
> >>> +++ b/gcc/testsuite/lib/target-supports.exp
> >>> @@ -4104,12 +4104,18 @@ proc check_effective_target_arm_fp16_hw { } {
> >>>   foreach { armfunc armflag armdefs } {
> >>>           v4 "-march=armv4 -marm" __ARM_ARCH_4__
> >>>           v4t "-march=armv4t" __ARM_ARCH_4T__
> >>> +       v4t_thumb "-march=armv4t -mthumb" __ARM_ARCH_4T__
> >>>           v5t "-march=armv5t" __ARM_ARCH_5T__
> >>> +       v5t_thumb "-march=armv5t -mthumb" __ARM_ARCH_5T__
> >>>           v5te "-march=armv5te" __ARM_ARCH_5TE__
> >>> +       v5te_thumb "-march=armv5te -mthumb" __ARM_ARCH_5TE__
> >>>           v6 "-march=armv6" __ARM_ARCH_6__
> >>> +       v6_thumb "-march=armv6 -mthumb" __ARM_ARCH_6__
> >>>           v6k "-march=armv6k" __ARM_ARCH_6K__
> >>> +       v6k_thumb "-march=armv6k -mthumb" __ARM_ARCH_6K__
> >>>           v6t2 "-march=armv6t2" __ARM_ARCH_6T2__
> >>>           v6z "-march=armv6z" __ARM_ARCH_6Z__
> >>> +       v6z_thumb "-march=armv6z -mthumb" __ARM_ARCH_6Z__
> >>>           v6m "-march=armv6-m -mthumb -mfloat-abi=soft" __ARM_ARCH_6M__
> >>>           v7a "-march=armv7-a" __ARM_ARCH_7A__
> >>>           v7r "-march=armv7-r" __ARM_ARCH_7R__
> >>> --
> >>> 2.6.3
> >>>

  reply	other threads:[~2019-09-06  9:10 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 12:40 [ARM/FDPIC v5 00/21] FDPIC ABI for ARM Christophe Lyon
2019-05-15 12:40 ` [ARM/FDPIC v5 01/21] [ARM] FDPIC: Add -mfdpic option support Christophe Lyon
2019-07-16 10:18   ` Richard Sandiford
2019-08-29 15:08     ` Christophe Lyon
2019-08-30 10:06       ` Richard Sandiford
2019-05-15 12:41 ` [ARM/FDPIC v5 05/21] [ARM] FDPIC: Fix __do_global_dtors_aux and frame_dummy generation Christophe Lyon
2019-07-12  6:49   ` Richard Sandiford
2019-07-12 14:25     ` Christophe Lyon
2019-08-29 15:39     ` Christophe Lyon
2019-08-30  8:41       ` Richard Sandiford
2019-05-15 12:41 ` [ARM/FDPIC v5 02/21] [ARM] FDPIC: Handle arm*-*-uclinuxfdpiceabi in configure scripts Christophe Lyon
2019-07-12  7:44   ` Richard Sandiford
2019-07-12 13:25     ` Christophe Lyon
2019-07-12 13:28       ` Richard Sandiford
2019-08-29 15:14     ` Christophe Lyon
2019-08-30  9:30       ` Richard Sandiford
2019-08-30 14:48         ` Christophe Lyon
2019-08-30 15:15           ` Richard Sandiford
2019-09-02  7:51             ` Christophe Lyon
2019-09-02  8:31               ` Richard Sandiford
2019-08-30 14:40       ` Jonathan Wakely
2019-05-15 12:41 ` [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided Christophe Lyon
2019-05-15 13:55   ` Szabolcs Nagy
2019-05-15 14:37     ` Rich Felker
2019-05-15 15:12       ` Christophe Lyon
2019-05-15 15:37         ` Rich Felker
2019-05-15 15:59           ` Szabolcs Nagy
2019-05-15 16:07             ` Rich Felker
2019-05-21 15:29               ` Christophe Lyon
2019-05-21 15:48                 ` Rich Felker
2019-05-22  8:39                 ` Szabolcs Nagy
2019-05-22  8:45                   ` Christophe Lyon
2019-05-23 12:45                     ` Christophe Lyon
2019-07-16 10:38                       ` Richard Sandiford
2019-07-16 20:00                         ` Rich Felker
2019-08-01 10:13                         ` Christophe Lyon
2019-08-06 14:28                           ` Richard Sandiford
2019-08-29 15:14                         ` Christophe Lyon
2019-08-30  9:40                           ` Richard Sandiford
2019-05-15 12:41 ` [ARM/FDPIC v5 04/21] [ARM] FDPIC: Add support for FDPIC for arm architecture Christophe Lyon
2019-07-16 12:33   ` Richard Sandiford
2019-08-20 17:13     ` Christophe Lyon
2019-08-29 15:39     ` Christophe Lyon
2019-09-02 16:12       ` Richard Sandiford
2019-09-02 20:04         ` Christophe Lyon
2019-09-03  8:40           ` Richard Sandiford
2019-09-04 19:59             ` Christophe Lyon
2019-09-05  8:03               ` Richard Sandiford
2019-05-15 12:42 ` [ARM/FDPIC v5 06/21] [ARM] FDPIC: Add support for c++ exceptions Christophe Lyon
2019-08-30  9:31   ` Kyrill Tkachov
2019-08-30 14:44     ` Jonathan Wakely
2019-05-15 12:42 ` [ARM/FDPIC v5 07/21] [ARM] FDPIC: Avoid saving/restoring r9 on stack since it is read-only Christophe Lyon
2019-07-16 10:42   ` Kyrill Tkachov
2019-05-15 12:43 ` [ARM/FDPIC v5 09/21] [ARM] FDPIC: Add support for taking address of nested function Christophe Lyon
2019-07-16 11:53   ` Kyrill Tkachov
2019-07-16 13:31     ` Kyrill Tkachov
2019-07-31 14:48       ` Christophe Lyon
2019-08-29 15:40         ` Christophe Lyon
2019-08-30  8:54           ` Kyrill Tkachov
2019-05-15 12:43 ` [ARM/FDPIC v5 10/21] [ARM] FDPIC: Implement TLS support Christophe Lyon
2019-09-04 14:16   ` Kyrill Tkachov
2019-09-04 20:03     ` Christophe Lyon
2019-09-09  8:54       ` Christophe Lyon
2019-05-15 12:43 ` [ARM/FDPIC v5 08/21] [ARM] FDPIC: Enforce local/global binding for function descriptors Christophe Lyon
2019-07-16 10:51   ` Kyrill Tkachov
2019-05-15 12:44 ` [ARM/FDPIC v5 13/21] [ARM] FDPIC: Force LSB bit for PC in Cortex-M architecture Christophe Lyon
2019-08-29 15:37   ` Kyrill Tkachov
2019-09-05  8:30     ` Christophe Lyon
2019-09-05  8:32       ` Christophe Lyon
2019-09-05 20:56         ` Ian Lance Taylor
2019-09-05  9:03       ` Kyrill Tkachov
2019-09-09  8:58         ` Christophe Lyon
2019-05-15 12:44 ` [ARM/FDPIC v5 12/21] [ARM] FDPIC: Restore r9 after we call __aeabi_read_tp Christophe Lyon
2019-08-29 15:40   ` Christophe Lyon
2019-08-29 15:44   ` Kyrill Tkachov
2019-05-15 12:44 ` [ARM/FDPIC v5 11/21] [ARM] FDPIC: Add support to unwind FDPIC signal frame Christophe Lyon
2019-09-04 14:19   ` Kyrill Tkachov
2019-05-15 12:45 ` [ARM/FDPIC v5 15/21] [ARM][testsuite] FDPIC: Adjust scan-assembler patterns Christophe Lyon
2019-07-19  8:54   ` Kyrill Tkachov
2019-05-15 12:45 ` [ARM/FDPIC v5 14/21] [ARM][testsuite] FDPIC: Skip unsupported tests Christophe Lyon
2019-07-19  8:52   ` Kyrill Tkachov
2019-05-15 12:45 ` [ARM/FDPIC v5 16/21] [ARM][testsuite] FDPIC: Skip tests that don't work in PIC mode Christophe Lyon
2019-07-19  8:56   ` Kyrill Tkachov
2019-05-15 12:46 ` [ARM/FDPIC v5 19/21] [ARM][testsuite] FDPIC: Adjust pr43698.c to avoid clash with uclibc Christophe Lyon
2019-07-19  9:00   ` Kyrill Tkachov
2019-05-15 12:46 ` [ARM/FDPIC v5 18/21] [ARM][testsuite] FDPIC: Enable tests on pie_enabled targets Christophe Lyon
2019-07-19  8:59   ` Kyrill Tkachov
2019-07-22 19:50     ` Mike Stump
2019-05-15 12:46 ` [ARM/FDPIC v5 17/21] [ARM][testsuite] FDPIC: Handle *-*-uclinux* Christophe Lyon
2019-07-19  8:57   ` Kyrill Tkachov
2019-07-22 19:37     ` Mike Stump
2019-05-15 12:47 ` [ARM/FDPIC v5 21/21] [ARM] FDPIC: Handle stack-protector combined patterns Christophe Lyon
2019-07-19  9:40   ` Kyrill Tkachov
2019-05-15 12:47 ` [ARM/FDPIC v5 20/21] [ARM][testsuite] FDPIC: Skip tests using architectures unsupported by FDPIC Christophe Lyon
2019-07-19  9:03   ` Kyrill Tkachov
2019-09-06  8:01     ` Christophe Lyon
2019-09-06  8:28       ` Kyrill Tkachov
2019-09-06  9:10         ` Christophe Lyon [this message]
2019-09-06 17:44           ` Christophe Lyon
2019-09-09  8:38             ` Christophe Lyon
2019-05-23 12:46 ` [ARM/FDPIC v5 00/21] FDPIC ABI for ARM Christophe Lyon
2019-06-04 12:57   ` Christophe Lyon
2019-06-06 12:36     ` Christophe Lyon
2019-06-17 11:42       ` Christophe Lyon
2019-07-01 12:16         ` Christophe Lyon
2019-07-08 14:28           ` Christophe Lyon
2019-07-16  9:13             ` Christophe Lyon
2019-08-29 14:54 ` Christophe Lyon
2019-08-29 16:29   ` Christophe Lyon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKdteObQ=rk+OFehrRFbLxKLn2_T+r=gjv8bjvQpP+MP+MsmyQ@mail.gmail.com' \
    --to=christophe.lyon@linaro.org \
    --cc=christophe.lyon@st.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kyrylo.tkachov@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).