From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82594 invoked by alias); 2 Mar 2015 22:04:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 82579 invoked by uid 89); 2 Mar 2015 22:04:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qa0-f54.google.com Received: from mail-qa0-f54.google.com (HELO mail-qa0-f54.google.com) (209.85.216.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 02 Mar 2015 22:04:39 +0000 Received: by mail-qa0-f54.google.com with SMTP id x12so25281736qac.13 for ; Mon, 02 Mar 2015 14:04:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=R4Yeb8371PK/hGhyJGIUf+wSPLytTqICyw9vw4/jD7U=; b=NKJSYxXshZ0I6rusXVdcl+TaU2aWbN3oPxad3KDOLFD+1fDlBuidYJC/W0/Nvp+c9W J5tf449zRejD6Wu/Kbe1CaIwI/vuQ3z1gaSNPOaIfJAwVsQD2jjngX9afBcUjrvUKwIN OZC8J9ZZ1f6Qt/hTzgPr7Xs9vb8rlDuNMumBQmqIeqJBLdEzcbLU1z75GcYUfeU+IikE mZ9YtNWXwqXDPsrjdbjvf41uVR9J0cX6YGz5oxYETNuhYZqQ9brQeoBfnCA2N0xxmLZ/ vpR474UrtVCMfL15YOko2iX6L/EWP3+5logSqhnv72CctQ9UUNblKBWx4oWkP0nxNALW 88sg== X-Gm-Message-State: ALoCoQmS3WB9CJyTkvKNUlsQGgdxurFNmoYD8cobGIts+18FMJyz9lUbX/KmwOdtL06YvN759kZl MIME-Version: 1.0 X-Received: by 10.140.44.134 with SMTP id g6mr51828990qga.85.1425333876832; Mon, 02 Mar 2015 14:04:36 -0800 (PST) Received: by 10.140.95.194 with HTTP; Mon, 2 Mar 2015 14:04:36 -0800 (PST) In-Reply-To: <20150302202137.GB846@kam.mff.cuni.cz> References: <20150227021047.GA20437@kam.mff.cuni.cz> <1425058393.27855.242.camel@ubuntu-sellcey> <20150227204951.GF48311@kam.mff.cuni.cz> <54F4B35C.2000300@arm.com> <20150302202137.GB846@kam.mff.cuni.cz> Date: Mon, 02 Mar 2015 22:04:00 -0000 Message-ID: Subject: Re: ipa-icf::merge TLC From: Christophe Lyon To: Jan Hubicka Cc: Alex Velenko , Steve Ellcey , Jack Howarth , GCC Patches , =?UTF-8?Q?Martin_Li=C5=A1ka?= , Jakub Jelinek , James Greenhalgh Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00105.txt.bz2 On 2 March 2015 at 21:21, Jan Hubicka wrote: >> >> >> On 01/03/15 16:47, Christophe Lyon wrote: >> >On 27 February 2015 at 21:49, Jan Hubicka wrote: >> >>> >> >>>../sysdeps/gnu/siglist.c:72:1: internal compiler error: in address_matters_p, at symtab.c:1908 >> >>> versioned_symbol (libc, __new_sys_sigabbrev, sys_sigabbrev, GLIBC_2_3_3); >> >>> ^ >> >>>0x66a080 symtab_node::address_matters_p() >> >>> /scratch/sellcey/repos/bootstrap/src/gcc/gcc/symtab.c:1908 >> >>>0xe7cbe5 ipa_icf::sem_variable::merge(ipa_icf::sem_item*) >> >>> /scratch/sellcey/repos/bootstrap/src/gcc/gcc/ipa-icf.c:1443 >> >> >> >>Indeed, the ipa-icf should not try to analyze aliases - just prove ekvialence of >> >>definitions they are attached to. It already does that for functions (bit by accident; >> >>it gives up when there is no gimple body), but it does not do that for variables because >> >>it gets into ctor_for_folding. For that reason it sometimes decides to try to make two >> >>variable aliases alias of each other that is not a good idea, because of possible creation >> >>of loops. >> >> >> >>I am just discussing with Martin the fix. >> >> >> >>Honza >> > >> >For the record, I have noticed similar errors on ARM and AArch64 >> >targets, when building glibc. >> > >> >Christophe. >> > >> >> I confirm ARM and AArch64 failing to build with this patch: >> chmod a-w /work/build-aarch64-none-linux-gnu/obj/glibc/stdio-common/errlist-compat.cT >> 0x6b9100 symtab_node::address_matters_p() >> /work/src/gcc/gcc/symtab.c:1908 >> 0xedb4e5 ipa_icf::sem_variable::merge(ipa_icf::sem_item*) >> /work/src/gcc/gcc/ipa-icf.c:1723 >> 0xee03f9 ipa_icf::sem_item_optimizer::merge_classes(unsigned int) >> /work/src/gcc/gcc/ipa-icf.c:2955 >> 0xee6d31 ipa_icf::sem_item_optimizer::execute() >> /work/src/gcc/gcc/ipa-icf.c:2217 >> 0xee8df1 ipa_icf_driver >> /work/src/gcc/gcc/ipa-icf.c:3034 >> 0xee8df1 ipa_icf::pass_ipa_icf::execute(function*) >> /work/src/gcc/gcc/ipa-icf.c:3081 > > I commited patch for the alias merging yesterda night, so it should be fixed > now. If it still fails, please fill in a PR with preprocessed testcase so I > can reproduce it in a cross. > On my side, I saw builds complete again starting with r221090, I guess that's the commit you are referring to? Thanks, Christophe. > Honza >> Please submit a full bug report, >> with preprocessed source if appropriate. >> Please include the complete backtrace with any bug report. >> See for instructions. >> make[2]: *** >> [/work/build-aarch64-none-linux-gnu/obj/glibc/stdio-common/siglist.o] >> Error 1 >> make[2]: *** Waiting for unfinished jobs.... >> mv -f /work/build-aarch64-none-linux-gnu/obj/glibc/stdio-common/errlist-compat.cT /work/build-aarch64-none-linux-gnu/obj/glibc/stdio-common/errlist-compat.c >> >> Regards, >> Alex