From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3980 invoked by alias); 16 Jan 2013 13:46:58 -0000 Received: (qmail 3881 invoked by uid 22791); 16 Jan 2013 13:46:56 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-oa0-f48.google.com (HELO mail-oa0-f48.google.com) (209.85.219.48) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Jan 2013 13:46:45 +0000 Received: by mail-oa0-f48.google.com with SMTP id h2so1367769oag.7 for ; Wed, 16 Jan 2013 05:46:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type:x-gm-message-state; bh=Ayap7AdIcTJf+B7iZnSd3S96Qe1+F00ajMxMRKiRfnE=; b=aOPVSG76imnu7jck2DYT2fLZV9UTJtrAytkBqQHBjVf2SJ3q13aOkH2z6ddEAKte/u LhYRE8F1yAIgNRXD5i9WvpBvacyw5hHepLFJVg/mU+xUH0+pe7PlUKxuz7aqfK9K+ZcP 6y02e0nZryyFnaAuJPt7gZ0Xrm0n8ANDe8gttVOy0scrPfmMZHc2t30fofsdU1rhg3qx MCm1LN6giwUl19iLNPHemB5bZtdDX07XcF1IUjyM+3niCOxQeZh7H2vU96u6S3sv8cG3 vc1W70YfU8qowlrVT6DX3t1BWf8VASUyBAyvvUiZ5QG1WiN736XNilBGW4l7j4YF9yiL AX2g== MIME-Version: 1.0 X-Received: by 10.60.172.178 with SMTP id bd18mr812177oec.133.1358344004698; Wed, 16 Jan 2013 05:46:44 -0800 (PST) Received: by 10.60.115.67 with HTTP; Wed, 16 Jan 2013 05:46:44 -0800 (PST) In-Reply-To: References: <50CF366B.2060405@arm.com> Date: Wed, 16 Jan 2013 13:46:00 -0000 Message-ID: Subject: Re: [ARM] Turning off 64bits ops in Neon and gfortran/modulo-scheduling problem From: Christophe Lyon To: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnn298qOmE5hVS6iC7lOWK4PkocG2lg252j9Nm533DBFLVolH2bGLaRBbG5A391o66+7MYQ X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00848.txt.bz2 Ping^2 ? On 8 January 2013 17:24, Christophe Lyon wrote: > Ping? > http://gcc.gnu.org/ml/gcc-patches/2012-12/msg01197.html > > Thanks, > > Christophe > > On 19 December 2012 16:59, Christophe Lyon wrote: >> On 17 December 2012 16:12, Richard Earnshaw wrote: >>> On 29/11/12 17:16, Christophe Lyon wrote: >>>> On trunk I have noticed a regression in gfortran when using modulo >>>> scheduling: sms-1.f90 now fails, but I suspect it's not because of >>>> this patch since forcing compilation for armv5t makes the same test >>>> fail with and without my patch. >>>> >>> >>> Hmm, that's worrying. Could you please makesure this is recorded in >>> bugzilla. If this is a regression, please mark it as such. >>> >> I was about to do so, but after bisecting it turns out that the >> problem was introduced by >> http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=192969 and is very >> likely to be another instance of PR55562, which has just been fixed >> by http://gcc.gnu.org/ml/gcc-patches/2012-12/msg01137.html. >> >> >>> >>> Now that this optimization is disabled by default, the onlya8 code is >>> completely redundant and should be purged, along with the insn alternatives >>> that used it. >>> >>> R. >>> >> Here is a new version of my patch, with the cleanup you requested. >> >> 2012-12-18 Christophe Lyon >> >> gcc/ >> * config/arm/arm-protos.h (tune_params): Add >> prefer_neon_for_64bits field. >> * config/arm/arm.c (prefer_neon_for_64bits): New variable. >> (arm_slowmul_tune): Default prefer_neon_for_64bits to false. >> (arm_fastmul_tune, arm_strongarm_tune, arm_xscale_tune): Ditto. >> (arm_9e_tune, arm_v6t2_tune, arm_cortex_tune): Ditto. >> (arm_cortex_a5_tune, arm_cortex_a15_tune): Ditto. >> (arm_cortex_a9_tune, arm_fa726te_tune): Ditto. >> (arm_option_override): Handle -mneon-for-64bits new option. >> * config/arm/arm.h (TARGET_PREFER_NEON_64BITS): New macro. >> (prefer_neon_for_64bits): Declare new variable. >> * config/arm/arm.md (arch): Rename neon_onlya8 and neon_nota8 to >> avoid_neon_for_64bits and neon_for_64bits. Remove onlya8 and >> nota8. >> (arch_enabled): Handle new arch types. Remove support for onlya8 >> and nota8. >> (one_cmpldi2): Use new arch names. >> * config/arm/arm.opt (mneon-for-64bits): Add option. >> * config/arm/neon.md (adddi3_neon, subdi3_neon, iordi3_neon) >> (anddi3_neon, xordi3_neon, ashldi3_neon, di3_neon): Use >> neon_for_64bits instead of nota8 and avoid_neon_for_64bits instead >> of onlya8. >> * doc/invoke.texi (-mneon-for-64bits): Document. >> >> gcc/testsuite/ >> * gcc.target/arm/neon-for-64bits-1.c: New tests. >> * gcc.target/arm/neon-for-64bits-2.c: Likewise.