From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24185 invoked by alias); 14 Sep 2016 13:37:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 23545 invoked by uid 89); 14 Sep 2016 13:37:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f172.google.com Received: from mail-qt0-f172.google.com (HELO mail-qt0-f172.google.com) (209.85.216.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Sep 2016 13:37:45 +0000 Received: by mail-qt0-f172.google.com with SMTP id l91so6617357qte.3 for ; Wed, 14 Sep 2016 06:37:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IHtVKnjZGqSSbMXpR0UeTjEWeZGMQzK68TknVpUie68=; b=IFnrn0PIizCuSF5fiwwNbYt7cgR8+uP7rApBG4TV3hePHHiB/3c10mMqfVeR+DVprL OP2P+j+o5aGBt5qWxpCWv9mcBToXf5NVAbpbqZSn74suxDOdTV0M4+wmsNeejvSipvlC 1sq5+mHiIhhWpEHeTn0oFsIONUe0yzrrQieJcEVHPmBqG7W8tOgUG6F38iFYV+mXTG4M plfNzEy4MJDYiK62Mpk8ISgaxsm1qB77jYMi+aHBbbVyQWU5leNoVMUgQVDIVnxkaWga Hap0jd4TyCujyrQYEM9Tgk6CGKZ2+TDYi69htE5IHEb0NkoMfGMwp5D4sW0dejDhI+ZI zYPQ== X-Gm-Message-State: AE9vXwNqsTIn5iMn+DDzNnsQtj2A0zehQMM6+wanowkSZfhigiXSouLKcvgoEnvR0asxlWFn74PW+4NNcnAqVBRz X-Received: by 10.200.57.231 with SMTP id v94mr2882651qte.35.1473860263271; Wed, 14 Sep 2016 06:37:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.21.102 with HTTP; Wed, 14 Sep 2016 06:37:42 -0700 (PDT) In-Reply-To: <20160914132749.GH17376@redhat.com> References: <57C97BF8.5090601@foss.arm.com> <20160906101528.GA32255@redhat.com> <20160914132749.GH17376@redhat.com> From: Christophe Lyon Date: Wed, 14 Sep 2016 13:41:00 -0000 Message-ID: Subject: Re: [libstdc++-v3] Fix dg-require before dg-run directives in testsuite. To: Jonathan Wakely Cc: Matthew Wahab , gcc-patches , "libstdc++" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00830.txt.bz2 On 14 September 2016 at 15:27, Jonathan Wakely wrote: > On 14/09/16 15:17 +0200, Christophe Lyon wrote: >> >> It seems some tests still have dg-require or dg-skip before dg-do. >> The attached patch fixes that, the only effect is that >> 25_algorithms/lower_bound/debug/irreflexive.cc >> is now UNSUPPORTED instead of PASS on arm* and aarch64* targets. >> >> I'm not sure if that's expected. I do see: "#error No debug mode" in the >> logs. > > > It's expected, because it has dg-require-debug-mode, so the test > should only run when doing make check-debug, or adding > -D_GLIBCXX_DEBUG to the options used for testing. > > It passes in normal mode too, but doesn't test anything very > interesting, so doesn't need to be tested. > Thanks for the explanation. Committed as r240135. Christophe >> OK for trunk? > > > Yes, thanks. > >