From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by sourceware.org (Postfix) with ESMTPS id DE0CA388A015 for ; Thu, 2 Apr 2020 17:17:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DE0CA388A015 Received: by mail-ot1-x344.google.com with SMTP id c9so4195757otl.12 for ; Thu, 02 Apr 2020 10:17:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VIbGYdQ9AyuWRv4cmWTMAa6W0eGhTTx/XeQWhRc8Yww=; b=pA8NHPfkVHIUhBVAIetFXOwyu9n+vN39DOlTh+v8AeKXMAtHNQ1dHatcd0tK4yfOPL HmWomIit848RcCzWEFuLZZqiMEASIfJKPk/D1zWgsRDjOGQwcx3yj7IOjnSydfgEzSx4 REv6gfBCzBFAZYSNt+dBXWW6D4hbp/4dQtAVQOgobHqp9Q6m2OWKa7aalAq3GupPmncz nzHkTIAxTxanRW7LnSlZo6TYCXxbEk/DHQmJaVoyDaNT2/eCOLvlMtRDw9249hMKSsqT tdnpDHZXpaq+31xZ6qhlO+oJme0tX1TSmrT/2aAS8DSZAB5zWGBA4N1Jo9SGliWdNvou S04A== X-Gm-Message-State: AGi0PuZ0X3CVilRF0ArVvdimZe45u8muId8A24UzqIqJSW34X/66LjGZ 4J5yR1zFO0VR8u7DkdW8kImKg9QEhUjUecyHUh94xg== X-Google-Smtp-Source: APiQypL8z8waFj1T84EsmUP0PPxsrufoY2G4tln7s+vP9/Un+AlYwxcS+f1WQTpSxy7rgx86nkNG7OgpcsMATXHYcmY= X-Received: by 2002:a9d:7397:: with SMTP id j23mr3061037otk.269.1585847856192; Thu, 02 Apr 2020 10:17:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christophe Lyon Date: Thu, 2 Apr 2020 19:17:25 +0200 Message-ID: Subject: Re: [PATCH] ICF: compare type attributes for gimple_call_fntypes. To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: gcc Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-15.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2020 17:17:38 -0000 On Thu, 2 Apr 2020 at 17:16, Martin Li=C5=A1ka wrote: > > Hi. > > The patch compares type attributes for gimple_call_fntypes in IPA ICF. > Note that we were unable to find a generic function attribute that > can be used on a function type definition. > > For a one which is allowed assume_aligned(16) I get affects_type_identity= =3D=3D false > which seems suspicious to me. > > Note that we currently use comp_type_attributes in ICF for both variable = and > function declarations. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > Hi, Thanks for the quick patch! I confirm it fixes the problem I noticed on arm with the cmse-15.c for -O2 and -O3. However, the testcase still fails with -Os. I haven't looked at the details, so it may be a different cause. Thanks, Christophe > gcc/ChangeLog: > > 2020-04-02 Martin Liska > > PR ipa/94445 > * ipa-icf-gimple.c (func_checker::compare_gimple_call): > Compare type attributes for gimple_call_fntypes. > --- > gcc/ipa-icf-gimple.c | 4 ++++ > 1 file changed, 4 insertions(+) > >