From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by sourceware.org (Postfix) with ESMTPS id B570A383F857 for ; Wed, 4 Nov 2020 13:37:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B570A383F857 Received: by mail-ot1-x343.google.com with SMTP id l36so11309313ota.4 for ; Wed, 04 Nov 2020 05:37:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/aGv+XjxHLKAf64DKLGMifPOi3s+xOiIpxBVouCDnEY=; b=XBBbDdPJoXQGwDvcnGIbS9UU5OZOgL40bXeDtwLlBjzxf8gvs9IrVns9X+x9mGtiMy Xpamvcjr/YhomInKaclx3GcgZct/ycYshNDE1W5bCdpMyMJ7if186lTryReQ8z4WdnI0 BzbvZtJV4EifABIUCpym4MOX/Wkm/d6PKKWunc2CYrRs4VsLMLLX4Hhx+j+z4pqOsQul dxXBl8qP8qOGV4+SgZgxNxeIgoLCykweCLgacahRMtSUL6NjYtzOyuQGhby11BdW7Ixc 9KmVKf6998bXQZ8WbcyjW/ZIqWDam/AT6Un7bPBkJdgjGNl7RgPspgeovphkV43CMZ/k VFGQ== X-Gm-Message-State: AOAM530WFUHo151NskWz0sb5zJhaJSEaE6O4ZogfSNbGXvB++huEv1Yu m02oXO8V2IYxiq6v0ptM+ffqC+jObFY9DLdxdA8nDw== X-Google-Smtp-Source: ABdhPJwMS8Ia6PemXA8/6Bpo9ZUh9z5hT/6fNx5qysbnkerUI6gfwN2VGHpLFPo+LCfqqwXxD6a1I3zwN3TWZeKRtPk= X-Received: by 2002:a9d:6307:: with SMTP id q7mr19287601otk.218.1604497034129; Wed, 04 Nov 2020 05:37:14 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Christophe Lyon Date: Wed, 4 Nov 2020 14:37:03 +0100 Message-ID: Subject: Re: [PATCH 1/x] arm: Add vld1_lane_bf16 + vldq_lane_bf16 intrinsics To: Kyrylo Tkachov Cc: Andrea Corallo , "gcc-patches@gcc.gnu.org" , Richard Earnshaw , nd Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2020 13:37:16 -0000 On Wed, 4 Nov 2020 at 14:29, Christophe Lyon wrote: > > On Tue, 3 Nov 2020 at 11:27, Kyrylo Tkachov via Gcc-patches > wrote: > > > > Hi Andrea, > > > > > -----Original Message----- > > > From: Andrea Corallo > > > Sent: 26 October 2020 15:59 > > > To: gcc-patches@gcc.gnu.org > > > Cc: Kyrylo Tkachov ; Richard Earnshaw > > > ; nd > > > Subject: [PATCH 1/x] arm: Add vld1_lane_bf16 + vldq_lane_bf16 intrinsics > > > > > > Hi all, > > > > > > I'd like to submit the following patch implementing the bfloat16_t > > > neon related load intrinsics: vld1_lane_bf16, vld1q_lane_bf16. > > > > > > Please see refer to: > > > ACLE > > > ISA > > > > > > Regtested and bootstrapped. > > > > > > Okay for trunk? > > > > I think you need to add -mfloat-abi=hard to the dg-additional-options > otherwise vld1_lane_bf16_1.c > fails on targets with a soft float-abi default (eg arm-linux-gnueabi). > > See bf16_vldn_1.c. Actually that's not sufficient because in turn we get: /sysroot-arm-none-linux-gnueabi/usr/include/gnu/stubs.h:10:11: fatal error: gnu/stubs-hard.h: No such file or directory So you should check that -mfloat-abi=hard is supported. Ditto for the vst tests. > > BTW, why did you use a different naming scheme for the tests? > (bf16_vldn_1.c vs vld1_lane_bf16_1.c) > > Christophe > > > Ok. > > Thanks, > > Kyrill > > > > > > > > > > Andrea > >