From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21802 invoked by alias); 16 Jun 2017 15:39:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21739 invoked by uid 89); 16 Jun 2017 15:39:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=realizing X-HELO: mail-ua0-f175.google.com Received: from mail-ua0-f175.google.com (HELO mail-ua0-f175.google.com) (209.85.217.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Jun 2017 15:39:40 +0000 Received: by mail-ua0-f175.google.com with SMTP id g40so27793595uaa.3 for ; Fri, 16 Jun 2017 08:39:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=kpkXDvCfeD2Cq3mHF0nwB/fS82t6r6KX0w57FtHKGMw=; b=b3Wa5lLIkL/qwhxQ0trmkqTJV3OLHwKBkam7524uYCXbbKE7QBk5w9LEQewHYAE7wV N0WQcbOb7iDa0qRORsfG1JbeokXu40lCG+6Uo89j0d6GygyZFtosWKC+VpamU76o6+vz IgAxN4+nHGUs6OApd8oDr+ds5vkmZpq+OTcIei/f5+sVYbq17hOaaVzt9rdAIpHzMuTD r8wHdN+YLdCid6A26OIvyj8cubUqctO+WbKLtKv1T0sao+H0IPRqTt2HfiUfgvs7j4iz qqyX5UDrGj71x+Gkw1xyPpq2wbh+Z8wLrWbED7im48iMNo/TdxPF+CKrv6B6Pk4rUo2j 2WQw== X-Gm-Message-State: AKS2vOwGbb81CpnyCN2CEXnXgucthZu5sEF1XlnbpAiVYZKCAPT5r6Ks lAwS92FbOp/v3evH2CSv4pkJ/r0L+LOhxZs= X-Received: by 10.176.67.166 with SMTP id l35mr6110334ual.119.1497627582577; Fri, 16 Jun 2017 08:39:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.50.131 with HTTP; Fri, 16 Jun 2017 08:39:42 -0700 (PDT) In-Reply-To: References: From: Christophe Lyon Date: Fri, 16 Jun 2017 15:39:00 -0000 Message-ID: Subject: Re: [Patch, ARM, testsuite] Add -mfloat-abi=hard to arm_neon_ok To: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01208.txt.bz2 ping? On 7 June 2017 at 11:13, Christophe Lyon wrote: > Hi, > > > On 2 June 2017 at 16:19, Christophe Lyon wrote: >> Hi, >> >> I have recently updated the dejagnu version I use for >> cross-testing arm and aarch64 toolchains to 1.6+. One of the side >> effects was mentioned by Jonathan in >> https://gcc.gnu.org/ml/gcc-patches/2017-05/msg01267.html. Since I >> use multilibs to test many configurations, I noticed several >> changes in the results I get. >> >> In particular, on arm-none-linux-gnueabihf with -march=armv5t, >> all the tests that require arm_neon_ok fail to compile because >> they now use -march=armv5t -mfpu=neon -mfloat-abi=softfp >> -march=armv7-a, which leads to a failure to include >> gnu/stubs-soft.h (not present since the target is >> 'hf'). Previously, -march=armv5t was appended, making the tests >> unsupported because -mfpu=neon conflicts with -march=armv5t. Now, >> arm_neon_ok succeeds because it only checks if some preprocessor >> defines are present. >> >> This patch fixes that by including arm_neon.h in arm_neon_ok, such >> that it fails for unsupported cases. However, since most of these >> tests should pass instead of becoming unsupported, I have added flag >> combinations with -mfloat-abi=hard. >> >> However, this is not sufficient to make the >> gcc.target/arm/lto/pr65837* tests pass: they do not require >> arm_neon_ok, and when I tried to add it, they still failed >> because these lto tests do not support dg-add-options. My >> proposal is to add a new >> check_effective_target_arm_neon_ok_no_float_abi function which >> tries to use neon without trying to change the -mfloat-abi >> setting (that is, the same as arm_neon_ok, with only "" >> and "-mfpu=neon" in the list of flags) . This makes these two lto >> tests unsupported for non-hf targets (again because >> gnu/stubs-soft.h is not present). >> >> To make them pass on "hf" targets: >> - I added -mfpu=neon to dg-lto-options in pr65837-attr_0.c, >> because the fpu attributes in arm_neon.h only work if >> -mfpu=neon is enabled >> - I removed dg-suppress-ld-options {-mfpu=neon} from pr65837_0.c, >> -mfpu=neon is needed for the test to compile with toolchains >> where the default fpu is not neon (eg vfpv3-d16-fp16) >> >> On arm-none-linux-gnueabihf --with-cpu=cortex-a9 --with-fpu=vfp >> and multilib test flag=-march=armv5t, this patch brings: >> - 2 UNRESOLVED -> FAIL (gcc.dg/vect/vect-align-1.c) >> - 14 UNRESOLVED -> XPASS (in gcc.dg/vect/) >> - 2765 new PASS >> - 3639 FAIL -> PASS >> - 1826 UNRESOLVED -> PASS >> - 102 UNRESOLVED -> XFAIL >> >> as visible in the red cell at >> http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/248552-gnu-stubs9.patch/report-build-info.html >> (the build-failed line can be ignored, it was caused by a server >> problem) >> >> Sorry, the explanation is almost longer than the patch :-) >> >> Is it OK for trunk? >> (Just realizing that I forgot to document the new functions :( ) >> > > Here is an updated version with a bit of documentation for the new > effective target. > arm_neon_ok_no_float_abi now only tries to add -mfpu=neon, not "" > since we always > add -mfpu=neon in the lto tests anyway. > > OK? > > >> Thanks, >> >> Christophe