From: Christophe Lyon <christophe.lyon@linaro.org>
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Gilles Gouaillardet <gilles@rist.or.jp>
Subject: Re: [Patch, fortran] PR91926 - assumed rank optional
Date: Wed, 09 Oct 2019 10:18:00 -0000 [thread overview]
Message-ID: <CAKdteObnapMP7Trk13QYX5WWJdvSnPT2bLqerO-swua9rSDOhg@mail.gmail.com> (raw)
In-Reply-To: <CAGkQGiK0F2Jr+KXTzkxPJf0koK4bRoKvWP0MLMsbcM0Lr+bjag@mail.gmail.com>
Hi,
On Sat, 5 Oct 2019 at 20:31, Paul Richard Thomas <
paul.richard.thomas@gmail.com> wrote:
> I must apologise not posting this before committing. I left for a
> vacation this morning and I thought that this problem and the one
> posted by Gilles were best fixed before departing. The patch only
> touches the new ISO_Fortran binding feature and so I thought that I
> would be safe to do this.
>
> It was fully regtested and only applies to trunk.
>
> Paul
>
> Author: pault
> Date: Sat Oct 5 08:17:55 2019
> New Revision: 276624
>
> URL: https://gcc.gnu.org/viewcvs?rev=276624&root=gcc&view=rev
> Log:
> 2019-10-05 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/91926
> * trans-expr.c (gfc_conv_gfc_desc_to_cfi_desc): Correct the
> assignment of the attribute field to account correctly for an
> assumed shape dummy. Assign separately to the gfc and cfi
> descriptors since the atribute can be different. Add btanch to
> correctly handle missing optional dummies.
>
> 2019-10-05 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/91926
> * gfortran.dg/ISO_Fortran_binding_13.f90 : New test.
> * gfortran.dg/ISO_Fortran_binding_13.c : Additional source.
> * gfortran.dg/ISO_Fortran_binding_14.f90 : New test.
>
> 2019-10-05 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/91926
> * runtime/ISO_Fortran_binding.c (cfi_desc_to_gfc_desc): Do not
> modify the bounds and offset for CFI_other.
>
> Added:
> trunk/gcc/testsuite/gfortran.dg/ISO_Fortran_binding_13.c
> trunk/gcc/testsuite/gfortran.dg/ISO_Fortran_binding_13.f90
> trunk/gcc/testsuite/gfortran.dg/ISO_Fortran_binding_14.f90
> Modified:
> trunk/gcc/fortran/ChangeLog
> trunk/gcc/fortran/trans-expr.c
> trunk/gcc/testsuite/ChangeLog
> trunk/libgfortran/ChangeLog
> trunk/libgfortran/runtime/ISO_Fortran_binding.c
>
Since this was committed (r276624), I have noticed regressions on
arm-linux-gnueabihf:
FAIL: gfortran.dg/ISO_Fortran_binding_11.f90 -O3 -g execution test
I've seen other reports on gcc-testresults too.
Christophe
next prev parent reply other threads:[~2019-10-09 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 18:31 Paul Richard Thomas
2019-10-09 10:18 ` Christophe Lyon [this message]
2019-10-09 11:35 ` Paul Richard Thomas
2019-10-17 13:56 ` Tobias Burnus
2019-10-19 18:10 ` Paul Richard Thomas
2019-10-21 17:59 ` Paul Richard Thomas
2019-10-25 7:29 ` Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKdteObnapMP7Trk13QYX5WWJdvSnPT2bLqerO-swua9rSDOhg@mail.gmail.com \
--to=christophe.lyon@linaro.org \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gilles@rist.or.jp \
--cc=paul.richard.thomas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).