From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by sourceware.org (Postfix) with ESMTPS id 1FA64385700A for ; Mon, 9 Nov 2020 07:16:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1FA64385700A Received: by mail-oi1-x243.google.com with SMTP id q206so9226647oif.13 for ; Sun, 08 Nov 2020 23:16:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+/qL1wC2FzLGfhD8BAxqH5Ee48M1PhoqNjRCBYfHAH0=; b=fLYGyKdbSxmKiIhrk1IGvqJStUqrVCV7tQ7hHnl8vashcIGQq7Eb3rUVsKCA24inVr 9D05t2jNdLZcBBN4K5vKAebarSWWWs4gTS5x53Vb2R0n7R/vM5PrygMBHjKsR0FuAE5p lVbiHZ5DR4qtHgUDTUNJwTGZTquBzGPxmclrxiihaOJPjZsKN+cxv3n1hXppX7lDv8Ws 0Tj01Bazz9YCV/k0kmfvr5o/Xpy6vJwwDRvOrXpUspKzRQHEzAvYGO3XC3cFsMOi/PFF q75hmRVB19J3cBOCAgEJ0b3M+h82OUGMv89AihycQosPlNqI/kaKlTLJGjsPCXONUpKr oNBg== X-Gm-Message-State: AOAM530xboReEzNkCVXX9XZmuUouFFBoLqjkfr2KRa1L0JciAXP4iZ+S MqUjX+tbgBwwYBIsDg3sFs+6xrgcxSxzs5q0UWbMxQ== X-Google-Smtp-Source: ABdhPJzvUld9a7BSSvZVJ0paeYopsx3oDBMSaVYhzxYVRbRYSDgxAtpRdKwtEjvon6loAuI3VwQhVa+A8DOi//ipkFw= X-Received: by 2002:a05:6808:2c4:: with SMTP id a4mr7850088oid.114.1604906190350; Sun, 08 Nov 2020 23:16:30 -0800 (PST) MIME-Version: 1.0 References: <1600075768-21285-1-git-send-email-christophe.lyon@linaro.org> <8e8cd5c9-2b66-0c3c-cf18-9b33db495547@redhat.com> In-Reply-To: From: Christophe Lyon Date: Mon, 9 Nov 2020 08:16:19 +0100 Message-ID: Subject: Re: [PATCH] libiberty/pex-win32.c: Initialize orig_err To: Jeff Law Cc: gcc Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2020 07:16:32 -0000 On Sat, 7 Nov 2020 at 00:59, Jeff Law wrote: > > > On 9/18/20 6:33 AM, Christophe Lyon wrote: > > On Thu, 17 Sep 2020 at 23:33, Jeff Law wrote: > >> > >> On 9/14/20 3:29 AM, Christophe Lyon via Gcc-patches wrote: > >>> Initializing orig_err avoids a warning: "may be used uninitialized". > >>> > >>> 2020-09-14 Torbj=C3=B6rn SVENSSON > >>> Christophe Lyon > >>> > >>> libiberty/ > >>> * pex-win32 (pex_win32_exec_child): Initialize orig_err. > >> Rather than just blindly initializing orig_err, we'd actually prefer t= o > >> have a compilable testcase and analyze why we're getting the warning. = A > >> false positive -Wuninitialized warning is often a missed optimization > >> under the hood. > >> > > OK, I filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D97108 > > after checking the problem is still present with trunk and not only > > with the old gcc version we have in our builders. > > Thanks. I've put an initial analysis in there. I think it's pointing > at a failing in both the traditional threader as well as the backwards > threader. The backwards threader is probably the place to fix it in the > long term. > > > In the immediate term, go ahead with the trivial initialization so that > it doesn't show up in your builds. We'll track the threader issue via > the BZ. > Thanks, pushed as r11-4828. > > Thanks, > > jeff >