From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124908 invoked by alias); 13 Nov 2015 08:31:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 124806 invoked by uid 89); 13 Nov 2015 08:31:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qk0-f182.google.com Received: from mail-qk0-f182.google.com (HELO mail-qk0-f182.google.com) (209.85.220.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 13 Nov 2015 08:31:14 +0000 Received: by qkas77 with SMTP id s77so40468224qka.0 for ; Fri, 13 Nov 2015 00:31:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=c1ADottO/l293HhRAlMV8Yc/m3PMX3r1SC4/yu+NNQQ=; b=f65iv2m4mImtgEZpWwhfz5eLwbVSGGiBZRoZxt5j/9ZbnxaNM5RznzhxVRJG9H1frF dWwblwqzjIhLheq/Wdwe3yrc+f+5Q738eKo5LB0FpwQAaZxKAfuri+vXUk8CiDX3cCxZ Kj1WPaaC0aVV69ziV5YvkSlal99Y6hvjlU2YPBbkHFy0B9RyG6hpmhcdfsjTNf/30TM2 53ptbvR7skj8rSI+Eg5xaxvRhB2sjMzy4pZDFfxlVByq4Rq6LX1ex3PHqBqCqOyqmJ3+ kuLhqkAvdI7p3+pLP7CrPdPvqs38vLvXBnb1TPZvyMWIKYawQHY6N/sAYaTSdTDL0J6Y 81vw== X-Gm-Message-State: ALoCoQlukC8uu/KgHOUSF5i8n8aJXEQmjORQIX7tABhQYhi5uLd29bfd1btlH3od+fW9VFz2eEf/ MIME-Version: 1.0 X-Received: by 10.55.33.40 with SMTP id h40mr20450232qkh.77.1447403472476; Fri, 13 Nov 2015 00:31:12 -0800 (PST) Received: by 10.140.109.200 with HTTP; Fri, 13 Nov 2015 00:31:12 -0800 (PST) In-Reply-To: References: Date: Fri, 13 Nov 2015 08:31:00 -0000 Message-ID: Subject: Re: [PATCH] More compile-time saving in BB vectorization From: Christophe Lyon To: Andreas Schwab Cc: Richard Biener , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg01627.txt.bz2 On 12 November 2015 at 21:04, Christophe Lyon wrote: > On 12 November 2015 at 16:49, Andreas Schwab wrote: >> Richard Biener writes: >> >>> * tree-vectorizer.h (vect_slp_analyze_and_verify_instance_alignment): >>> Declare. >>> (vect_analyze_data_refs_alignment): Make loop vect specific. >>> (vect_verify_datarefs_alignment): Likewise. >>> * tree-vect-data-refs.c (vect_slp_analyze_data_ref_dependences): >>> Add missing continue. >>> (vect_compute_data_ref_alignment): Export. >>> (vect_compute_data_refs_alignment): Merge into... >>> (vect_analyze_data_refs_alignment): ... this. >>> (verify_data_ref_alignment): Split out from ... >>> (vect_verify_datarefs_alignment): ... here. >>> (vect_slp_analyze_and_verify_node_alignment): New function. >>> (vect_slp_analyze_and_verify_instance_alignment): Likewise. >>> * tree-vect-slp.c (vect_supported_load_permutation_p): Remove >>> misplaced checks on alignment. >>> (vect_slp_analyze_bb_1): Add fatal output parameter. Do >>> alignment analysis after SLP discovery and do it per instance. >>> (vect_slp_bb): When vect_slp_analyze_bb_1 fatally failed do not >>> bother to re-try using different vector sizes. >> >> This breaks libgfortran on ia64: >> >> ../../../libgfortran/generated/matmul_c4.c: In function 'matmul_c4': >> ../../../libgfortran/generated/matmul_c4.c:79:1: internal compiler error: in vectorizable_store, at tree-vect-stmts.c:5651 >> matmul_c4 (gfc_array_c4 * const restrict retarray, >> ^ >> 0x40000000010ff01f vectorizable_store >> ../../gcc/tree-vect-stmts.c:5651 >> 0x4000000001115b5f vect_transform_stmt(gimple*, gimple_stmt_iterator*, bool*, _slp_tree*, _slp_instance*) >> ../../gcc/tree-vect-stmts.c:8003 >> 0x400000000114df1f vect_schedule_slp_instance >> ../../gcc/tree-vect-slp.c:3484 >> 0x4000000001154d6f vect_schedule_slp(vec_info*) >> ../../gcc/tree-vect-slp.c:3549 >> 0x40000000011562bf vect_slp_bb(basic_block_def*) >> ../../gcc/tree-vect-slp.c:2543 >> 0x4000000001159f2f execute >> ../../gcc/tree-vectorizer.c:734 >> > > Same problem on armeb. > Now fixed at r230260 (pr68308). Thanks. > >> Andreas. >> >> -- >> Andreas Schwab, SUSE Labs, schwab@suse.de >> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 >> "And now for something completely different."