From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59771 invoked by alias); 15 Jun 2015 12:16:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59760 invoked by uid 89); 15 Jun 2015 12:16:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qk0-f177.google.com Received: from mail-qk0-f177.google.com (HELO mail-qk0-f177.google.com) (209.85.220.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 15 Jun 2015 12:16:23 +0000 Received: by qkhq76 with SMTP id q76so52405999qkh.2 for ; Mon, 15 Jun 2015 05:16:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=sa/a5pyCMbPA9/1oq/bHfFr/nNcp/S29+NBAC/JemIo=; b=BBRds81xUokjwhyxJu6+BAbSvvu40K77BtB+2Twky6xZ7l5VZLzMXLVyxpw/MwglxE /HSaMDdSbXOVMgLQZbLKfxzPsB1fFBR19+fz34GqcIdQTA21OnrP3ytDLuqiT8wb/K/U 8EOaK+R6B90OeqezY6uADRRNhnqtVyN+W9uvrw6ERxK9XsQpCv72U63oTripbXrZV1I8 1f+4lGkTcOdmPtdswM5vbjiesNa5opbP2Y7IJgt9tAtFws4OeZxYiZJ9Q0eDRv2fzu0m txsjEJR0MFYxz8yefu5iY/412/OLW+iDfub+bLgKTHeiYWpaFojtnCR/ezGgrFIxdEDn 0uCg== X-Gm-Message-State: ALoCoQkgvedgRD8Hh+RrbX2rUwhrVGYK7xppYmi9L4sx3tfJsCpb2cVfD2ypn3S46hZvnSSW72Yn MIME-Version: 1.0 X-Received: by 10.140.235.147 with SMTP id g141mr35570004qhc.35.1434370581182; Mon, 15 Jun 2015 05:16:21 -0700 (PDT) Received: by 10.140.102.164 with HTTP; Mon, 15 Jun 2015 05:16:21 -0700 (PDT) In-Reply-To: References: <54238FEF.6030006@linaro.org> Date: Mon, 15 Jun 2015 12:20:00 -0000 Message-ID: Subject: Re: [AArch64] Fix predicate and constraint mismatch in logical atomic operations From: Christophe Lyon To: Richard Biener Cc: Marcus Shawcroft , Michael Collison , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg01004.txt.bz2 On 8 May 2015 at 12:42, Richard Biener wrote: > On Tue, Nov 4, 2014 at 11:44 AM, Marcus Shawcroft > wrote: >> On 25 September 2014 04:45, Michael Collison >> wrote: >>> On certain patterns in atomics.md the constraint 'n' is used in combination >>> with the predicate atomic_op_operand. The constraint is too general and >>> allows constants that are disallowed by the predicate. This causes an ICE In >>> final_scan_insn when the insn cannot be split because the constraint and >>> predicate do not match. >>> >>> Tested on aarch64-none-elf, aarch64-linux-gnu. Additionally the originally >>> reporter of the bug, (doko@ubuntu.com), applied the patch and successfully >>> bootstrapped and tested with no regressions. >>> >>> 2014-09-23 Michael Collison >>> >>> * config/aarch64/iterators.md (lconst_atomic): New mode attribute to >>> support constraints for CONST_INT in atomic operations. >>> * config/aarch64/atomics.md >>> (atomic_): Use lconst_atomic constraint. >>> (atomic_nand): Likewise. >>> (atomic_fetch_): Likewise. >>> (atomic_fetch_nand): Likewise. >>> (atomic__fetch): Likewise. >>> (atomic_nand_fetch): Likewise. >> >> OK Thanks. /Marcus > > Can you please backport this to all release branches as well? > Hi Richard, I have tested this backport against 4.8 and 4.9 branches. I applies cleanly in both cases, shows no regression and fixes the ICE. I'm afraid it's too late for committing into the 4.8 branch? Sorry for the delay in handling this. Christophe. > Thanks, > Richard.