From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61067 invoked by alias); 21 Nov 2016 12:47:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60997 invoked by uid 89); 21 Nov 2016 12:47:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=promised, person X-HELO: mail-qk0-f177.google.com Received: from mail-qk0-f177.google.com (HELO mail-qk0-f177.google.com) (209.85.220.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Nov 2016 12:47:11 +0000 Received: by mail-qk0-f177.google.com with SMTP id n21so348101203qka.3 for ; Mon, 21 Nov 2016 04:47:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3XThPxs7NGmC0W1jc2pKqUQ9haFFDDindU8xsFRKNqE=; b=S+mT3gGrwmhthbVU3EefroVn/6vpZhSLEO79wAO+nWXyZd7DwN7dV7OeX5avih5Dhi 0ugsGzUtdgpfOBEs6bhgW5AioPjSz9r2ydO+A0JzVRLDjEWwPTb2YUxx3hj9LqSLk58+ 1VHdoATgUzx8nltE8omDOnvZSczi9C9VwP0UQqzkvQA4fCzlJ1a7Ieg731lIAe1swLuZ 1nVrgZPitksJ7sHA9Dc06SiO7Dcfl1CYi//Rp02r0Yk5bChUtxZ9pEiYNVX/wtirBoaQ yrNGLE4hJ914vPIsEJPW5Mtx3ExwuUaH3OaKkqz891kfc6azH1nF2H2XaktETSUH/w46 A8AA== X-Gm-Message-State: AKaTC01qdfRrYgxhnDJ+RaQGIRhwOwrutbfTz7YKhe+btMrr1E4Lx7Ymdfynldr2P3rf3/HcIb/lgghHCCiO2qtR X-Received: by 10.55.8.20 with SMTP id 20mr17049161qki.3.1479732429875; Mon, 21 Nov 2016 04:47:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.28.226 with HTTP; Mon, 21 Nov 2016 04:47:09 -0800 (PST) In-Reply-To: References: <512a967c-39c4-44f5-6f24-d75ef543979d@redhat.com> <20160629192130.GF8823@embecosm.com> <20160914130048.GC31794@embecosm.com> <03bef940-2b86-af7d-d2d2-b96b8283596f@redhat.com> <20161116200930.GG5975@embecosm.com> <20161116221217.GH5975@embecosm.com> <20161119215926.GX5975@embecosm.com> From: Christophe Lyon Date: Mon, 21 Nov 2016 12:47:00 -0000 Message-ID: Subject: Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag. To: Mike Stump Cc: Andrew Burgess , Bernd Schmidt , "gcc-patches@gcc.gnu.org" , Jeff Law , Jakub Jelinek Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg02119.txt.bz2 On 20 November 2016 at 18:27, Mike Stump wrote: > On Nov 19, 2016, at 1:59 PM, Andrew Burgess wrote: >>> So, your new test fails on arm* targets: >> >> After a little digging I think the problem might be that >> -freorder-blocks-and-partition is not supported on arm. >> >> This should be detected as the new tests include: >> >> /* { dg-require-effective-target freorder } */ >> >> however this test passed on arm as -freorder-blocks-and-partition does >> not issue any warning unless -fprofile-use is also passed. >> >> The patch below extends check_effective_target_freorder to check using >> -fprofile-use. With this change in place the tests are skipped on >> arm. > >> All feedback welcome, > > Seems reasonable, unless a -freorder-blocks-and-partition/-fprofile-use person thinks this is the wrong solution. > Hi, As promised, I tested this patch: it makes gcc.dg/tree-prof/section-attr-[123].c unsupported on arm*, and thus they are not failing anymore :-) However, it also makes other tests unsupported, while they used to pass: gcc.dg/pr33648.c gcc.dg/pr46685.c gcc.dg/tree-prof/20041218-1.c gcc.dg/tree-prof/bb-reorg.c gcc.dg/tree-prof/cold_partition_label.c gcc.dg/tree-prof/comp-goto-1.c gcc.dg/tree-prof/pr34999.c gcc.dg/tree-prof/pr45354.c gcc.dg/tree-prof/pr50907.c gcc.dg/tree-prof/pr52027.c gcc.dg/tree-prof/va-arg-pack-1.c and failures are now unsupported: gcc.dg/tree-prof/cold_partition_label.c gcc.dg/tree-prof/section-attr-1.c gcc.dg/tree-prof/section-attr-2.c gcc.dg/tree-prof/section-attr-3.c So, maybe this patch is too strong? Christophe