From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id 0688D3858439 for ; Wed, 13 Oct 2021 10:19:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0688D3858439 Received: by mail-io1-xd2e.google.com with SMTP id 5so2221187iov.9 for ; Wed, 13 Oct 2021 03:19:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=barQYg5LtGaG9mDs1rEQFFL5oVZ7UHng4n3/KM0V4Zs=; b=30XmixBGr8mFMt/LYWthS02JOWmP1kEb7HiJctBuMSAgKc5Wm3KPScF60+N6CRzwRm X2psdF17TnN4mFJNAdNGvCnBKiuROO/l1noN8XyP4O2od4rEeJfQnJntTN/IToP6Mskk fNRmhP7Roj+UxgxMn/g91lGNcKd8ui3zT8CyJ/Pyb95tzlqT3VVnr3cQeorjArlVBngv g+qm2d0yOx0zEDogK156gYor3ePlH/iGludj1Nszg1Eqy2LgvcJm4rther5Z6zwfd/O7 BCsimq5UHIVNmoRsvptdOx5HeGnxmJmqb4cMbcqJdoE5ZQ7YXltmbXWgRdhsPBWBlMlR /4Ig== X-Gm-Message-State: AOAM532YHOoNt4/Dv0ofh//CvzdN68DsVttdzskQTBq+WioIG7gBSUBM rmnRb/+i/eCD5/4RyV+YQbI7GU0Qce7PCdY3S0A= X-Google-Smtp-Source: ABdhPJw0lAQxz+8AGxSktcnGubmVwhwxH58+ej341hdm9QikGcm4F38ujcD9LImAVQPl3kZ8qrkYh9Z3ePfqR5HKyB0= X-Received: by 2002:a02:9f1a:: with SMTP id z26mr8622778jal.86.1634120368325; Wed, 13 Oct 2021 03:19:28 -0700 (PDT) MIME-Version: 1.0 References: <20210907091704.1034380-6-christophe.lyon@foss.st.com> <20210907091704.1034380-7-christophe.lyon@foss.st.com> In-Reply-To: From: Christophe Lyon Date: Wed, 13 Oct 2021 12:19:17 +0200 Message-ID: Subject: Re: [PATCH 06/13] arm: Fix mve_vmvnq_n_ argument mode To: Richard Sandiford , Christophe Lyon via Gcc-patches , Christophe Lyon X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2021 10:19:31 -0000 On Mon, Oct 11, 2021 at 4:10 PM Richard Sandiford via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > Christophe Lyon via Gcc-patches writes: > > The vmvnq_n* intrinsics and have [u]int[16|32]_t arguments, so use > > iterator instead of HI in mve_vmvnq_n_. > > > > 2021-09-03 Christophe Lyon > > > > gcc/ > > * config/arm/mve.md (mve_vmvnq_n_): Use V_elem mode > > for operand 1. > > > > diff --git a/gcc/config/arm/mve.md b/gcc/config/arm/mve.md > > index e393518ea88..14d17060290 100644 > > --- a/gcc/config/arm/mve.md > > +++ b/gcc/config/arm/mve.md > > @@ -617,7 +617,7 @@ (define_insn "mve_vcvtaq_" > > (define_insn "mve_vmvnq_n_" > > [ > > (set (match_operand:MVE_5 0 "s_register_operand" "=w") > > - (unspec:MVE_5 [(match_operand:HI 1 "immediate_operand" "i")] > > + (unspec:MVE_5 [(match_operand: 1 "immediate_operand" "i")] > > VMVNQ_N)) > > ] > > "TARGET_HAVE_MVE" > > I agree this is correct, but there's also the issue that the > predicate is too broad. At the moment it allows any immediate, > so things like: > > #include > int32x4_t foo(void) { return vmvnq_n_s32(0x12345678); } > > are accepted by the compiler and only rejected by the assembler. > Not your bug to fix, just saying :-) > > Right, and it seems to be the case for vbicq_n, vorrq_n, ... I'll check that separately. > Thanks, > Richard >