From: Christophe Lyon <christophe.lyon.oss@gmail.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Christophe LYON <christophe.lyon@foss.st.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libcpp: Use [[likely]] conditionally
Date: Tue, 23 Nov 2021 21:34:04 +0100 [thread overview]
Message-ID: <CAKhMtS+yOGhdyHp4fjBEfNcVRdZUTowEOSUUrjaVPZqpyDi3vg@mail.gmail.com> (raw)
In-Reply-To: <80552f43-bb51-4526-f06a-c4c4855d7073@gmail.com>
On Tue, Nov 23, 2021 at 4:41 PM Jeff Law via Gcc-patches <
gcc-patches@gcc.gnu.org> wrote:
>
>
> On 11/23/2021 8:26 AM, Christophe LYON via Gcc-patches wrote:
> > Hi!
> >
> > On 23/11/2021 01:26, Jeff Law via Gcc-patches wrote:
> >>
> >>
> >> On 11/22/2021 10:22 AM, Marek Polacek via Gcc-patches wrote:
> >>> Let's hide [[likely]] behind a macro, to suppress warnings if the
> >>> compiler doesn't support it.
> >>>
> >>> Co-authored-by: Jonathan Wakely <jwakely@redhat.com>
> >>>
> >>> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk?
> >>>
> >>> PR preprocessor/103355
> >>>
> >>> libcpp/ChangeLog:
> >>>
> >>> * lex.c: Use ATTR_LIKELY instead of [[likely]].
> >>> * system.h (ATTR_LIKELY): Define.
> >> OK
> >> jeff
> >
> >
> > This patch breaks the build when the host compiler is gcc-4.8.5,
> > because __has_cpp_attribute is not defined.
> Sigh. I'd like to move to a more recent prereq if we could.
>
I don't know why we have such an old dependency indeed.
I am not requesting it, I just happen to have an old enough host
compiler so that I can check/complain when we accidentally
break the dependency :-)
Christophe
>
>
> >
> > Is this small patch OK with a proper ChangeLog?
> Yes. Sorry about the breakage.
> jeff
>
>
>
next prev parent reply other threads:[~2021-11-23 20:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 17:22 Marek Polacek
2021-11-23 0:26 ` Jeff Law
2021-11-23 15:26 ` Christophe LYON
2021-11-23 15:38 ` Marek Polacek
2021-11-23 15:38 ` Jeff Law
2021-11-23 20:34 ` Christophe Lyon [this message]
2021-11-23 20:43 ` Jakub Jelinek
2021-11-23 20:43 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKhMtS+yOGhdyHp4fjBEfNcVRdZUTowEOSUUrjaVPZqpyDi3vg@mail.gmail.com \
--to=christophe.lyon.oss@gmail.com \
--cc=christophe.lyon@foss.st.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).