From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id A161E3858403 for ; Wed, 15 Sep 2021 16:15:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A161E3858403 Received: by mail-il1-x12c.google.com with SMTP id a20so3496023ilq.7 for ; Wed, 15 Sep 2021 09:15:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yZJ5QcBPN0MrNhtA03pEDukHBeyeF3JU7MTsm9L7MoE=; b=20086U/tOImbDLrUDvvCJ/6erYy8P0wzRx1o3qgKl7hpEeZtGMX0tmRvZikq5DNdt0 0WGE2+V5JJU0TToDwdDqTw0TDAf+sr+JKjqRXf33JWZeWdrr72dpQLY2DpWO4jCw1CAb 7SOLXlei6u7PLgbSMhFUJR7ucXw9/HKQHbP2Ju60KEyBqibnwPWUCT+hq8QWVUXwx1wF qLtCtSMrfYSchpZzXG2Iofy1SjXUqSWUKAcqC89AtaZu8ccy/Hwi/nVSVA9ePjtx9w4y zCjvn9dvYqac9pzY0CrNJjCRixjI6N+ivFQwEtMuveVAHjjiiNIHaWYvFGSV4w8TNWb6 IknQ== X-Gm-Message-State: AOAM530zyl9CF+a+/viaqF6R4g9wChgws9a77DmcOcNiZN6LPGMrf1Of z7Ad1aGDDOWYFhKPtA5PDR01zim/atM0WQl/eAE= X-Google-Smtp-Source: ABdhPJyOGxI5LdLGihic3Y6q9xdT7j3Jg0FUQ/XyFWv++pqQDRHH3KYz6eccvwJB9FaUsiU4R/e2KS0xd8Rp5B4ZtR0= X-Received: by 2002:a05:6e02:1c86:: with SMTP id w6mr663643ill.52.1631722518079; Wed, 15 Sep 2021 09:15:18 -0700 (PDT) MIME-Version: 1.0 References: <20210915153154.1111443-1-jason@redhat.com> <423c550a-1493-bf3e-7301-5544dbaae772@gmail.com> In-Reply-To: From: Christophe Lyon Date: Wed, 15 Sep 2021 18:15:07 +0200 Message-ID: Subject: Re: [pushed] c++: don't warn about internal interference sizes To: Jason Merrill Cc: Jeff Law , gcc-patches List X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2021 16:15:20 -0000 On Wed, Sep 15, 2021 at 5:39 PM Jason Merrill via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > On Wed, Sep 15, 2021 at 11:37 AM Jeff Law wrote: > > > > > > > On 9/15/2021 9:31 AM, Jason Merrill via Gcc-patches wrote: > > > Most any compilation on ARM/AArch64 was warning because the default L1 > > cache > > > line size of 32B was smaller than the default > > > std::hardware_constructive_interference_size of 64B. This is mostly > due > > to > > > inaccurate --param l1-cache-line-size, but it's not helpful to complain > > to a > > > user that didn't set the values. > > > > > > gcc/cp/ChangeLog: > > > > > > * decl.c (cxx_init_decl_processing): Only warn about odd > > > interference sizes if they were specified with --param. > > I wonder if that'll fix the arm-linux build failures that started > > showing up recently: > > > > armeb-linux-gnueabi: > > > > : error: '--param constructive-interference-size=64' is > > greater than '--param l1-cache-line-size=32' [-Werror=interference-size] > > > > I expect the other arm- linux configurations would show it as well, but > > they're only run once a week in my tester and I don't think they've been > > run since the recent changes in this space. > > > > Yes, that is exactly the purpose of this change. > > I can confirm that those targets build again, thanks. > Jason >