From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 7FE533857420 for ; Fri, 6 Aug 2021 09:15:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7FE533857420 Received: by mail-il1-x130.google.com with SMTP id r1so8134013iln.6 for ; Fri, 06 Aug 2021 02:15:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=quJCffZpRKr67AkMctqzTCfnuAVPcN/1TOURIpZrwKo=; b=qdwCH6IgU4rb/VqmEmPYCYf5pXitkCMUBV6aANQQTqufBwe71bRfjoG70VE4Puj+SU rRZ6L04BelRDf4VvdP6I0NgqS8GfwZEVoIJyzeTv4mlmO+zUZZ0g4Lhd1PL8p23QN/c4 joQ1sfawq2wBX1Vc2OSt5iRF6PHq5vNMuV3p6bRslf9na5INm8kn+bRs1rifU4z7gkdc CqyTOFfhIVN47CUYgCiSvXVpnMUG7JvNDQcZ76SkY3aqP04sXtvsIicNpT9fcTHXCttc VzW3/PvM5RlYsu0jxlnmjRH7X9/hH6KXepAdnY0ATbVWn8p2QOpS+ieOP59Fhsdz2Rvt GkbQ== X-Gm-Message-State: AOAM5330fQq/i+nrNEqCPiZ+B6fqqh2di4KjYTRtLAm1Qn40Ev9ZShmR nlmJtKK7Zwyl+MSHYks9Bdyk7gmpmKvyUJwI8NA= X-Google-Smtp-Source: ABdhPJwY62ZE27cy7gej1y6Eah1ORpPtf7kFB9vV3JQHPgw5yRwzNapJxmAZbofgCWISPohfNNmUj3ulgRpZ8wTfLtQ= X-Received: by 2002:a05:6e02:1543:: with SMTP id j3mr190882ilu.308.1628241316956; Fri, 06 Aug 2021 02:15:16 -0700 (PDT) MIME-Version: 1.0 References: <20210723093911.81759-1-sebastian.huber@embedded-brains.de> <501a8c1b-d5ae-e274-f8f9-6f6ceec4d20c@embedded-brains.de> <535407c0-435a-87d2-3ca9-825bba0376b8@embedded-brains.de> In-Reply-To: <535407c0-435a-87d2-3ca9-825bba0376b8@embedded-brains.de> From: Christophe Lyon Date: Fri, 6 Aug 2021 11:15:06 +0200 Message-ID: Subject: Re: [PATCH v3] gcov: Add __gcov_info_to_gdca() To: Sebastian Huber Cc: =?UTF-8?Q?Martin_Li=C5=A1ka?= , GCC Patches X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Aug 2021 09:15:19 -0000 On Fri, Aug 6, 2021 at 10:05 AM Sebastian Huber < sebastian.huber@embedded-brains.de> wrote: > Hello Christophe, > > On 06/08/2021 09:50, Christophe Lyon wrote: > > Looks like there's a problem with your patch: > > > /tmp/1784442_7.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-eab= i/gcc1/./gcc/xgcc > -B/tmp/1784442_7.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-ea= bi/gcc1/./gcc/ > -B/tmp/1784442_7.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-= eabi/bin/ > -B/tmp/1784442_7.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-= eabi/lib/ > -isystem > /tmp/1784442_7.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-ea= bi/include > -isystem > /tmp/1784442_7.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-ea= bi/sys-include > -g -O2 -O2 -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -W -Wall > -Wno-narrowing -Wwrite-strings -Wcast-qual -Wstrict-prototypes > -Wmissing-prototypes -Wold-style-definition -isystem ./include -fno-inli= ne > -g -DIN_LIBGCC2 -fbuilding-libgcc -fno-stack-protector -Dinhibit_libc > -fno-inline -I. -I. -I../.././gcc > -I/tmp/1784442_7.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libgcc > -I/tmp/1784442_7.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libgcc/. > -I/tmp/1784442_7.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libgcc/../gcc > -I/tmp/1784442_7.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libgcc/../incl= ude > -o _gcov.o -MT _gcov.o -MD -MP -MF _gcov.dep -DL_gcov -c > /tmp/1784442_7.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libgcc/libgcov-d= river.c > > > > In file included from > > > /tmp/1784442_7.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/libgcc/libgcov-d= river.c:29: > > > /tmp/1784442_7.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-eabi= /gcc1/gcc/include/stdint.h:9:16: > > > fatal error: stdint.h: No such file or directory > > 9 | # include_next > > | ^~~~~~~~~~ > > compilation terminated. > > make[2]: *** [Makefile:928: _gcov.o] Error 1 > > make[2]: *** Waiting for unfinished jobs.... > > > > Can you check? > > I already feared that the include may cause problems, from > the commit message: > > "With this patch, is included in libgcov-driver.c even if > inhibit_libc is defined. This header file should be also available for > freestanding environments. If this is not the case, then we have to > define intptr_t somehow." > > What about the attached patch? > Thanks, it does fix the build issue for me. Christophe > > -- > embedded brains GmbH > Herr Sebastian HUBER > Dornierstr. 4 > 82178 Puchheim > Germany > email: sebastian.huber@embedded-brains.de > phone: +49-89-18 94 741 - 16 > fax: +49-89-18 94 741 - 08 > > Registergericht: Amtsgericht M=C3=BCnchen > Registernummer: HRB 157899 > Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler > Unsere Datenschutzerkl=C3=A4rung finden Sie hier: > https://embedded-brains.de/datenschutzerklaerung/ >