From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id B2D99383D80F for ; Wed, 11 Aug 2021 14:07:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B2D99383D80F Received: by mail-io1-xd2d.google.com with SMTP id b142so2458950iof.4 for ; Wed, 11 Aug 2021 07:07:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sIcJINsOre30EV9zTe0UcNhVvJ+ucVrsH9g3swAuX34=; b=puJybHuZ1u/XQaosgZaqpR2/dFjp1tE4YV35nWeevLjvRli/1zn3o34be/LNPau9BU 1s+6J8+7Qbcc4leeKhQTUcS68YIl5F4y0l0Mp9rtJOJoOm9OedoMnzzv0r3ZN2f2txom PkOmX9z1EFfB+hpt8O1ePFa9NMdY8mDCoSRrquFQbsEHq8RmLOcW4HPCyRRGeWsBw6sX kp75VfdiM4d4nPoWW2heTc7VFSQrlSjc8VryE0UN/7I11dwYAbUOako+lweuejghP+wX QyuoevZgWL1q6LjCLSFSt0AlF8me7M5tcWcRSB4iPqlfuk+t65FAzC5Op/9xuYhgv3Fi zfXg== X-Gm-Message-State: AOAM530mvwE/qEgwwCO0LKjJyq+VYLigkrKhrWEiWbV27Tx1F7yfLnG4 fp1/Q8y6Mr2s4PpfFchm5JEZWGLykorPxbsysLw= X-Google-Smtp-Source: ABdhPJzOhOnEmpHyaJQ9t9U6yUTKRK1TUi/5nkAMACKyiEEU/eZysSTo6lJDKmVS2uctX/QjFo+vy7dvX8v2hSdafl4= X-Received: by 2002:a6b:6e11:: with SMTP id d17mr167008ioh.112.1628690827212; Wed, 11 Aug 2021 07:07:07 -0700 (PDT) MIME-Version: 1.0 References: <71064e87-e296-4bfd-e934-9b582e2ed3de@foss.st.com> In-Reply-To: From: Christophe Lyon Date: Wed, 11 Aug 2021 16:06:56 +0200 Message-ID: Subject: Re: [PATCH] arm: Fix multilib mapping for CDE extensions [PR100856] To: Christophe Lyon Cc: Christophe LYON , gcc Patches X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Aug 2021 14:07:18 -0000 ping? https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575310.html On Wed, Aug 4, 2021 at 11:13 AM Christophe Lyon via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > ping? > > On Thu, 15 Jul 2021 at 15:07, Christophe LYON via Gcc-patches > wrote: > > > > This is a followup to Srinath's recent patch: the newly added test is > > failing e.g. on arm-linux-gnueabihf without R/M profile multilibs. > > > > It is also failing on arm-eabi with R/M profile multilibs if the > > execution engine does not support v8.1-M instructions. > > > > The patch avoids this by adding check_effective_target_FUNC_multilib > > in target-supports.exp which effectively checks whether the target > > supports linking and execution, like what is already done for other > > ARM effective targets. pr100856.c is updated to use it instead of > > arm_v8_1m_main_cde_mve_ok (which makes the testcase a bit of a > > duplicate with check_effective_target_FUNC_multilib). > > > > In addition, I noticed that requiring MVE does not seem necessary and > > this enables the test to pass even when targeting a CPU without MVE: > > since the test does not involve actual CDE instructions, it can pass > > on other architecture versions. For instance, when requiring MVE, we > > have to use cortex-m55 under QEMU for the test to pass because the > > memset() that comes from v8.1-m.main+mve multilib uses LOB > > instructions (DLS) (memset is used during startup). Keeping > > arm_v8_1m_main_cde_mve_ok would mean we would enable the test provided > > we have the right multilibs, causing a runtime error if the simulator > > does not support LOB instructions (e.g. when targeting cortex-m7). > > > > I do not update sourcebuild.texi since the CDE effective targets are > > already collectively documented. > > > > Finally, the patch fixes two typos in comments. > > > > 2021-07-15 Christophe Lyon > > > > PR target/100856 > > gcc/ > > * config/arm/arm.opt: Fix typo. > > * config/arm/t-rmprofile: Fix typo. > > > > gcc/testsuite/ > > * gcc.target/arm/acle/pr100856.c: Use arm_v8m_main_cde_multilib > > and arm_v8m_main_cde. > > * lib/target-supports.exp: Add > > check_effective_target_FUNC_multilib for ARM CDE. > > > > >