From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by sourceware.org (Postfix) with ESMTPS id 6C0213853803 for ; Tue, 29 Jun 2021 21:03:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C0213853803 Received: by mail-il1-x142.google.com with SMTP id z1so638128ils.0 for ; Tue, 29 Jun 2021 14:03:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sexc6U7lWtCrHQqozntxPImGQKWPnsCNohgIk5KBZnU=; b=e9fwvwILJc4Y2ZMPAVTDKMFbim4jtb/4L+6jOABCPI2sq3YXYKG7P7Vy6fBi92y17G urHW09H6jop+IH5sCDMstKGr0IebqkJAq88UHyOnM5GlUEuoxvK42xExI+EMApZTAibC VBHo9s4fViDa/AOAa10G1fOv1MVq2ZZvedumYuVDE+bD7QKI8HwgoP7YEckz2a310/QE B6axdIoMkYepOiv98h3od46ux6FvO4XfEJcf+el3ddsZCdeXI9ddduxsj5L/OP3Xaqj2 B5Psqk8OL53uGLqvjipfaQCMUMdmtxb+T8JddomecVrT7OGlh98ykPapMITH0n84Zlu6 5POQ== X-Gm-Message-State: AOAM530q73TcYPepQO3rj1PIgAN/6n5D8tClfRv76wlzcIeOXNMeBTkO iB3HD60vFQM082xdr1cQcSO2TR39pBah7FRMJQY= X-Google-Smtp-Source: ABdhPJyl8qFWDyt83mbVnVk8x/0GYtFqE1XrVZWYFSVg+QA9BuSZYcnZfleQiXu/VXhXTjo75hEw6GltneThF95RfCc= X-Received: by 2002:a92:cbd0:: with SMTP id s16mr23477225ilq.19.1625000581986; Tue, 29 Jun 2021 14:03:01 -0700 (PDT) MIME-Version: 1.0 References: <20210617175054.GI7746@tucnak> <07d9e298-55d0-0e80-84f5-5d5d75c9e341@codesourcery.com> <20210617194010.GJ7746@tucnak> <7e4ad7a0-e601-b97f-9caa-9f10befbe84e@codesourcery.com> <81177be7-97bd-5c1e-2649-5ebe8eeb47b4@mentor.com> <89a1a17b-2e2d-238e-856c-b38c9aacc7ef@codesourcery.com> <4af01e92-c1e7-8cfc-d635-45aba3a48232@codesourcery.com> <20210629115856.GR7746@tucnak> In-Reply-To: From: Christophe Lyon Date: Tue, 29 Jun 2021 23:02:51 +0200 Message-ID: Subject: Re: [Patch] Add 'default' to -foffload=; document that flag [PR67300] To: Rainer Orth Cc: Tobias Burnus , Jakub Jelinek , Richard Biener , Sandra Loosemore , gcc-patches , Thomas Schwinge X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jun 2021 21:03:03 -0000 On Tue, Jun 29, 2021 at 10:48 PM Rainer Orth wrote: > Hi Tobias, > > > On 29.06.21 13:58, Jakub Jelinek wrote: > > > >> Also, wonder if we shouldn't print the list of configured targets in > that > >> case, see candidates_list_and_hint functions and its callers. > >> And it is unclear why we use fatal_error, can't unknown offload target > names > >> be simply ignored after emitting error? > > > > Done so =E2=80=93 as the changes now became a bit larger, I have attach= ed the > > new version of the patch =E2=80=93 despite the LGTM. > > this patch broke Solaris bootstrap (both 32 and 64-bit sparc and x86): > > /vol/gcc/src/hg/master/local/gcc/gcc.c: In function 'bool > check_offload_target_name(const char*, ptrdiff_t)': > /vol/gcc/src/hg/master/local/gcc/gcc.c:4010:23: error: writing 1 byte int= o > a region of size 0 [-Werror=3Dstringop-overflow=3D] > 4010 | cand[n - c] =3D '\0'; > | ~~~~~~~~~~~~^~~~~~ > In file included from /vol/gcc/src/hg/master/local/gcc/system.h:706, > from /vol/gcc/src/hg/master/local/gcc/gcc.c:31: > /vol/gcc/src/hg/master/local/gcc/../include/libiberty.h:733:36: note: at > offset 1 into destination object of size 1 allocated by '__builtin_alloca= ' > 733 | # define alloca(x) __builtin_alloca(x) > | ~~~~~~~~~~~~~~~~^~~ > /vol/gcc/src/hg/master/local/gcc/gcc.c:4000:29: note: in expansion of > macro 'alloca' > 4000 | char *cand =3D (char *) alloca (strlen (OFFLOAD_TARGETS) + = 1); > | ^~~~~~ > > Rainer > > Also seeing: FAIL: compiler driver --help=3Dcommon option(s): "^ +-.*[^:.]$" absent fro= m output: " -foffload=3D=3D Specify options for the offloa= ding targets" looks related to this patch. Thanks, Christophe --=20 > > -------------------------------------------------------------------------= ---- > Rainer Orth, Center for Biotechnology, Bielefeld University >