From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by sourceware.org (Postfix) with ESMTPS id DADE9385840A for ; Wed, 11 Aug 2021 16:53:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DADE9385840A Received: by mail-io1-xd35.google.com with SMTP id b142so3163213iof.4 for ; Wed, 11 Aug 2021 09:53:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0gEnFs+hOW/ZwQIlWJ1rtN10hKL3vXYZbtVaumRrQc4=; b=AcRbt3A3bdahPHlkEKuVTvL2xkVDU1iB1ayjnmgcNZ7SvPeD/TmseyP2GW1MT9djSS 92t8IkpD5zDZs6k8pNAg7ieauG4ySMW5eDKBo2+JlZhhZ7iCPjFKlz3dgc1l3M+y7pzm DX5sXXDxqnXpoGFjdWMKA3VqbVNJ/i5NNP1Mpyus1Fh87q9oMU6c8PMgqI7btM8r4ORf vNWvZCoOZgMO+J2mQhGpch4YK3FK67cdipOiQcmm19aVOuIOLJXk2ufPV95MT3aMtcEk qN0fc06/abEGqKnsp1uN4jDyFTHiDIG8rp95SNXb2zzrvk4hYNlKLrUpxbh9YWGG/Oaf Bhyg== X-Gm-Message-State: AOAM5335hu/TiNiGpCeGRQCDiColYqM6o2JXGgea0z8AvhajWUvKZKr7 0JCyUOfBq4LMAAHOfYMaTUbbvnQ+oIC/553mgl0= X-Google-Smtp-Source: ABdhPJxOx+1XUW9WyDtJ1u4GzNGfO9gbJm9n7uvnViCxlCLObVMco1eAtukoBC0y/P34SXYvKuAUGKYXa/KynuJgf5Q= X-Received: by 2002:a02:cd09:: with SMTP id g9mr2280230jaq.87.1628700822401; Wed, 11 Aug 2021 09:53:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christophe Lyon Date: Wed, 11 Aug 2021 18:53:31 +0200 Message-ID: Subject: Re: [ARM] PR66791: Replace builtins for vdup_n and vmov_n intrinsics To: Kyrylo Tkachov Cc: Prathamesh Kulkarni , gcc Patches X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Aug 2021 16:53:53 -0000 On Thu, Jun 24, 2021 at 6:29 PM Kyrylo Tkachov via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > > > > -----Original Message----- > > From: Prathamesh Kulkarni > > Sent: 24 June 2021 12:11 > > To: gcc Patches ; Kyrylo Tkachov > > > > Subject: [ARM] PR66791: Replace builtins for vdup_n and vmov_n intrinsics > > > > Hi, > > This patch replaces builtins for vdup_n and vmov_n. > > The patch results in regression for pr51534.c. > > Consider following function: > > > > uint8x8_t f1 (uint8x8_t a) { > > return vcgt_u8(a, vdup_n_u8(0)); > > } > > > > code-gen before patch: > > f1: > > vmov.i32 d16, #0 @ v8qi > > vcgt.u8 d0, d0, d16 > > bx lr > > > > code-gen after patch: > > f1: > > vceq.i8 d0, d0, #0 > > vmvn d0, d0 > > bx lr > > > > I am not sure which one is better tho ? > > Hi Prathamesh, This patch introduces a regression on non-hardfp configs (eg arm-linux-gnueabi or arm-eabi): FAIL: gcc:gcc.target/arm/arm.exp=gcc.target/arm/pr51534.c scan-assembler-times vmov.i32[ \t]+[dD][0-9]+, #0xffffffff 3 FAIL: gcc:gcc.target/arm/arm.exp=gcc.target/arm/pr51534.c scan-assembler-times vmov.i32[ \t]+[qQ][0-9]+, #4294967295 3 Can you fix this? Thanks Christophe > I think they're equivalent in practice, in any case the patch itself is > good (move away from RTL builtins). > Ok. > Thanks, > Kyrill > > > > > Also, this patch regressed bf16_dup.c on arm-linux-gnueabi, > > which is due to a missed opt in lowering. I had filed it as > > PR98435, and posted a fix for it here: > > https://gcc.gnu.org/pipermail/gcc-patches/2021-June/572648.html > > > > Thanks, > > Prathamesh >