From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) by sourceware.org (Postfix) with ESMTPS id 3367D3858C54 for ; Wed, 7 Jun 2023 11:38:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3367D3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-55b2170b536so478730eaf.2 for ; Wed, 07 Jun 2023 04:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686137905; x=1688729905; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+mKiSBrhu7c3E+VUvIrD3YkAG8FdA/mX+M2qgKy7X0s=; b=XFh5eukSFIZszVeo90TsF4reMIu7YxCOuBnEon6NTTZ+cU8gv27ux/DlgaJ563HV2G 8HGdM5/gVNs25psdB37Tb/snnJDiwpngopm3cVKaTj0YHEcO9Pel6fa31Lua92UOKVXz ZOqOBjzo6BvhItBuE4Y0wTiDb1TlvGjDN+DbCKSW/PzOzxfdPWcPufcGNax1InSKxkqr Wclhk9htcfM5UenprP8v3HWx+nHDNrAmDcIp1w0uveU+U80q8KJZQWPFM4GgwePkus12 ma1xmNfK7tJvaYlTL1VuAtyDfplSpkQ18Kku9bSxwrh+zEaJIli7HY/fqhYO63MgO5Te PZyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686137905; x=1688729905; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+mKiSBrhu7c3E+VUvIrD3YkAG8FdA/mX+M2qgKy7X0s=; b=SI91VsNX5B9ZONrnlmpCGKzrYqc9QZdWVVB0AGbdtQp3iFiA6dFUK87RrQpzl7j4GQ i0V6OhRLoCHgcs+RZiZB1RHcxpgprcxULLDUK51ZgDPqjYawh19h5ohWDZXmcc6xFXVv Nn5P0iqPurvX536hXhF/r9cl1tBSWWG4X4JSYjuRIQ0X8OxSHxrBP0sBP2wED4icM9pH IOZF2GjOuBsQcMhJ7tmXZJpYgj4bEtfgapdVR048xE5Br7qaNX1qcO9Xly7dXx8liiGE mAT0ep/+yrkgDLPTonvqFROfVZCWh2E2CAyndCYmIjOuBOxUzz51HUeY12mtxKJD6t16 9cjw== X-Gm-Message-State: AC+VfDwF9kOg4o9QHgEk5HJalsO3+Cu7YvIqb5/qdVf2jl26YiuwI34S QKLROZy58vo0ylXtfhkd4XUUK6b1TzwIePW85g== X-Google-Smtp-Source: ACHHUZ4b0AwpIcDR7iQ5SR22NuZUF5O+H8diilpX9JTX0MMWLAvrwqr8cViyUlKNp1kRJ70XR1VC5JJKwDVcu4dPlHM= X-Received: by 2002:a05:6358:4ea2:b0:129:8c5e:84c1 with SMTP id ce34-20020a0563584ea200b001298c5e84c1mr3237706rwb.32.1686137905117; Wed, 07 Jun 2023 04:38:25 -0700 (PDT) MIME-Version: 1.0 References: <20230606114858.447221-1-vultkayn@gcc.gnu.org> <48297dcd9fe381183eb344854bac0d4065abaa2b.camel@redhat.com> <5b5d9d546834f441ff3dcd7b16959b71e8bf834c.camel@redhat.com> In-Reply-To: <5b5d9d546834f441ff3dcd7b16959b71e8bf834c.camel@redhat.com> From: Benjamin Priour Date: Wed, 7 Jun 2023 13:38:13 +0200 Message-ID: Subject: Re: [PATCH] analyzer: Standalone OOB-warning [PR109437, PR109439] To: David Malcolm Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jun 6, 2023 at 8:37=E2=80=AFPM David Malcolm = wrote: > > On Tue, 2023-06-06 at 18:05 +0200, Benjamin Priour wrote: [...] > [Looks like you droppped the mailing list from the recipients; was that > intentional?] > Not at all, just me missing the reply all button. > > > > I indeed bootstrapped and regtested on linux-x86_64, but it was last > > week, since I'm still using my laptop, which is painfully slow (1 > > night per step), my tests are always a few days old. > > Thanks. The patch is OK for trunk once the minor formatting nits are > fixed (you don't have to bother with a full test run for that). We > might want to backport it to gcc 13 as well, but let's let it "soak" in > trunk for some time first. > > > We discussed it already but yes, in the end I believe an account on > > the compile farm will be necessary for me. > > Let me know if you need any help with that. I'm not certain about what to put under "Contributions" in the account creation form. I'm still green behind the ears, and wouldn't count my current count of 2 patches *not yet pushed to trunk* as anything remarkable. > > I'll correct the formatting of the comments and resend it, and double > > check the indentation. > > Thanks. I said that but actually I am unsure about the indentation format. Is it spaces up to 6 characters them morph them into tabs ? It was looking like that in the code, although some portion were breaking this rule. I went with the same indentation rules as already shown within each functio= n. > > > I'm still writing custom formatting rules for > > my gcc subfolders, > > but the formatter is sometimes switching back to my default rules > > instead of the workspace's. > > Which formatter are these rules for, BTW? > I'm using vscode default C/Cpp extension's formatter. [...] Thanks, Benjamin