From ca495cecf39eabe761eb073dbbe844118a98229d Mon Sep 17 00:00:00 2001 From: Thomas Preud'homme Date: Tue, 27 Nov 2018 15:52:38 +0000 Subject: [PATCH] [PATCH, ARM] Do softfloat when -mfpu set, -mfloat-abi=softfp and targeting Thumb-1 Hi, FP instructions are only enabled for TARGET_32BIT and TARGET_HARD_FLOAT but GCC only gives an error when TARGET_HARD_FLOAT is true and -mfpu is not set. Among other things, it makes some of the cmse tests (eg. gcc.target/arm/cmse/baseline/softfp.c) fail when targeting -march=armv8-m.base -mcmse -mfpu= -mfloat-abi=softfp. This patch adds an extra check for TARGET_32BIT to TARGET_HARD_FLOAT such that it is false on TARGET_THUMB1 targets even when a FPU is specified. ChangeLog entries are as follows: *** gcc/ChangeLog *** 2018-12-19 thomas Preud'homme * config/arm/arm.h (TARGET_HARD_FLOAT): Restrict to TARGET_32BIT targets. * config/arm/arm.c (output_return_instruction): Only check TARGET_HARD_FLOAT to decide whether FP instructions are available. *** gcc/testsuite/ChangeLog *** 2018-12-14 thomas Preud'homme * gcc.target/arm/cmse/baseline/softfp.c: Force an FPU. Testing: No testsuite regression when targeting arm-none-eabi Armv6S-M. Is this ok for stage3? Best regards, Thomas --- gcc/config/arm/arm.c | 2 +- gcc/config/arm/arm.h | 3 ++- gcc/testsuite/gcc.target/arm/cmse/baseline/softfp.c | 4 +++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 40f0574e32e..509f287aa63 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -19872,7 +19872,7 @@ output_return_instruction (rtx operand, bool really_return, bool reverse, "msr%s\tAPSR_nzcvq, %%|lr", conditional); output_asm_insn (instr, & operand); - if (TARGET_HARD_FLOAT && !TARGET_THUMB1) + if (TARGET_HARD_FLOAT) { /* Clear the cumulative exception-status bits (0-4,7) and the condition code bits (28-31) of the FPSCR. We need to diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h index 8472312487b..149243d0978 100644 --- a/gcc/config/arm/arm.h +++ b/gcc/config/arm/arm.h @@ -125,7 +125,8 @@ extern tree arm_fp16_type_node; /* Use hardware floating point instructions. */ #define TARGET_HARD_FLOAT (arm_float_abi != ARM_FLOAT_ABI_SOFT \ && bitmap_bit_p (arm_active_target.isa, \ - isa_bit_vfpv2)) + isa_bit_vfpv2) \ + && TARGET_32BIT) #define TARGET_SOFT_FLOAT (!TARGET_HARD_FLOAT) /* User has permitted use of FP instructions, if they exist for this target. */ diff --git a/gcc/testsuite/gcc.target/arm/cmse/baseline/softfp.c b/gcc/testsuite/gcc.target/arm/cmse/baseline/softfp.c index 3d383ff6ee1..30b3eec078c 100644 --- a/gcc/testsuite/gcc.target/arm/cmse/baseline/softfp.c +++ b/gcc/testsuite/gcc.target/arm/cmse/baseline/softfp.c @@ -1,5 +1,7 @@ /* { dg-do compile } */ -/* { dg-options "-mcmse -mfloat-abi=softfp" } */ +/* Force an FPU to test that it is ignored for Thumb-1 -like targets and that + no clearing of VFP register occurs. */ +/* { dg-options "-mcmse -mfloat-abi=softfp -mfpu=fpv5-d16" } */ double __attribute__ ((cmse_nonsecure_call)) (*bar) (float, double); -- 2.19.1