From: Thomas Preudhomme <thomas.preudhomme@linaro.org>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: dimitar@dinux.eu, gcc-patches@gcc.gnu.org,
richard.sandiford@arm.com,
"Thomas Preud'homme" <thomas.preudhomme@arm.com>
Subject: Re: [PATCH] [RFC] PR target/52813 and target/11807
Date: Wed, 12 Dec 2018 10:30:00 -0000 [thread overview]
Message-ID: <CAKnkMGtz8mx=2L-f1v6ueMCi8ZPjbKK9hoB3tAd4Sw8_wF5ceA@mail.gmail.com> (raw)
In-Reply-To: <CAKdteOaNdpvF2q_483WfOEa1b20wGL6q43x41btsvv8CcHA6_g@mail.gmail.com>
Hi Christophe,
That PR was about a bug occuring when sp was clobbered so if it cannot
be clobbered anymore the whole commit (r242693) can be removed. Let me
check the original code that lead to the PR why it's clobbering sp
though.
Best regards,
Thomas
On Wed, 12 Dec 2018 at 09:43, Christophe Lyon
<christophe.lyon@linaro.org> wrote:
>
> On Tue, 11 Dec 2018 at 16:52, Richard Sandiford
> <richard.sandiford@arm.com> wrote:
> >
> > Dimitar Dimitrov <dimitar@dinux.eu> writes:
> > > On понеделник, 10 декември 2018 г. 11:21:53 EET Richard Sandiford wrote:
> > >> Dimitar Dimitrov <dimitar@dinux.eu> writes:
> > >> > I have tested this fix on x86_64 host, and found no regression in the C
> > >> > and C++ testsuites. I'm marking this patch as RFC simply because I don't
> > >> > have experience with other architectures, and I don't have a setup to
> > >> > test all architectures supported by GCC.
> > >> >
> > >> > gcc/ChangeLog:
> > >> >
> > >> > 2018-12-07 Dimitar Dimitrov <dimitar@dinux.eu>
> > >> >
> > >> > * cfgexpand.c (asm_clobber_reg_is_valid): Also produce
> > >> > error when stack pointer is clobbered.
> > >> > (expand_asm_stmt): Refactor clobber check in separate function.
> > >> >
> > >> > gcc/testsuite/ChangeLog:
> > >> >
> > >> > 2018-12-07 Dimitar Dimitrov <dimitar@dinux.eu>
> > >> >
> > >> > * gcc.target/i386/pr52813.c: New test.
> > >> >
> > >> > Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> > >>
> > >> LGTM. Do you have a copyright assignment on file? 'Fraid this is
> > >> probably big enough to need one.
> > > Yes, I have copyright assignment.
> >
> > OK, great. I went ahead and applied the patch.
> >
>
> Hi,
>
> This patch introduces a regression on arm:
> FAIL: gcc.target/arm/pr77904.c (test for excess errors)
> Excess errors:
> /gcc/testsuite/gcc.target/arm/pr77904.c:7:3: error: Stack Pointer
> register clobbered by 'sp' in 'asm'
>
> Indeed the testcase has an explicit:
> __asm volatile ("" : : : "sp");
> which is now rejected.
>
> Thomas, is that mandatory to test your code to fix pr77904?
>
> Thanks,
>
> Christophe
>
> > Thanks,
> > Richard
next prev parent reply other threads:[~2018-12-12 10:30 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 10:09 Dimitar Dimitrov
2018-12-10 11:21 ` Richard Sandiford
2018-12-10 19:36 ` Dimitar Dimitrov
2018-12-11 15:52 ` Richard Sandiford
2018-12-12 9:42 ` Christophe Lyon
2018-12-12 10:03 ` Christophe Lyon
2018-12-12 16:39 ` Dimitar Dimitrov
2018-12-12 10:30 ` Thomas Preudhomme [this message]
2018-12-12 11:21 ` Thomas Preudhomme
2018-12-12 13:19 ` Christophe Lyon
2018-12-12 15:13 ` Christophe Lyon
2018-12-12 15:35 ` Thomas Preudhomme
2018-12-12 16:26 ` Dimitar Dimitrov
2018-12-13 14:49 ` Segher Boessenkool
2018-12-13 22:21 ` Dimitar Dimitrov
2018-12-14 8:52 ` Segher Boessenkool
2018-12-16 8:43 ` Dimitar Dimitrov
2018-12-17 15:23 ` Segher Boessenkool
2018-12-14 13:49 ` Richard Sandiford
2018-12-15 15:38 ` Segher Boessenkool
2018-12-12 11:24 ` Andreas Schwab
2018-12-16 14:36 Bernd Edlinger
2018-12-16 16:14 ` Dimitar Dimitrov
2018-12-17 11:47 ` Richard Sandiford
2018-12-17 12:54 ` Christophe Lyon
2018-12-17 13:35 ` Richard Sandiford
2018-12-17 13:42 ` Christophe Lyon
2018-12-17 14:05 ` Bernd Edlinger
2018-12-17 14:10 ` Bernd Edlinger
2018-12-17 15:55 ` Segher Boessenkool
2018-12-17 18:46 ` Richard Sandiford
2018-12-17 20:15 ` Bernd Edlinger
2018-12-19 6:40 ` Dimitar Dimitrov
2018-12-19 9:29 ` Segher Boessenkool
2018-12-18 14:16 ` Bernd Edlinger
2018-12-18 15:14 ` Bernd Edlinger
2019-01-07 9:23 ` Jakub Jelinek
2019-01-07 21:51 ` Bernd Edlinger
2019-01-08 12:03 ` Richard Sandiford
2019-01-10 13:21 ` Segher Boessenkool
2019-01-10 21:23 ` Richard Sandiford
2019-01-10 21:26 ` Jakub Jelinek
2019-01-10 21:56 ` Richard Sandiford
2019-01-11 12:26 ` Segher Boessenkool
2019-01-10 22:32 ` Bernd Edlinger
2019-01-11 12:18 ` Segher Boessenkool
2019-01-11 12:23 ` Richard Sandiford
2019-01-11 22:59 ` Jeff Law
2019-01-17 14:27 ` Christophe Lyon
2019-01-18 9:49 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKnkMGtz8mx=2L-f1v6ueMCi8ZPjbKK9hoB3tAd4Sw8_wF5ceA@mail.gmail.com' \
--to=thomas.preudhomme@linaro.org \
--cc=christophe.lyon@linaro.org \
--cc=dimitar@dinux.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
--cc=thomas.preudhomme@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).