From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120043 invoked by alias); 12 Dec 2018 10:30:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 112026 invoked by uid 89); 12 Dec 2018 10:30:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=2.6 required=5.0 tests=BAYES_00,BODY_8BITS,GARBLED_BODY,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=8:=d0=bf, mandatory, H*Ad:D*eu, 11807?= X-HELO: mail-io1-f49.google.com Received: from mail-io1-f49.google.com (HELO mail-io1-f49.google.com) (209.85.166.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Dec 2018 10:30:38 +0000 Received: by mail-io1-f49.google.com with SMTP id r200so14355820iod.11 for ; Wed, 12 Dec 2018 02:30:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=tlB/Jdi/AcuL5PiDUsEvXAFsp17IYKavsceVJiU4wog=; b=TJbJtlmf5q3Ni5X2Sjfe8hjrDtPDyR1wTCSscnOxYcyxRHg6gVs6HBsbbGymcwTKJq NaZPlfrBL1WHWmEKKwaLv6i16ZiS6A5F2etX2jMaNjnFZi+qAgoTDt8Yz/q7AQEuoFd9 aStQt4RMzjyd2eIC/GJDMdliT+CNUK6r6uI7g= MIME-Version: 1.0 References: <20181209100856.14051-1-dimitar@dinux.eu> <87woohsk32.fsf@arm.com> <2807771.CbC4dySGB1@tpdeb> <87woog9i32.fsf@arm.com> In-Reply-To: From: Thomas Preudhomme Date: Wed, 12 Dec 2018 10:30:00 -0000 Message-ID: Subject: Re: [PATCH] [RFC] PR target/52813 and target/11807 To: Christophe Lyon Cc: dimitar@dinux.eu, gcc-patches@gcc.gnu.org, richard.sandiford@arm.com, "Thomas Preud'homme" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00778.txt.bz2 Hi Christophe, That PR was about a bug occuring when sp was clobbered so if it cannot be clobbered anymore the whole commit (r242693) can be removed. Let me check the original code that lead to the PR why it's clobbering sp though. Best regards, Thomas On Wed, 12 Dec 2018 at 09:43, Christophe Lyon wrote: > > On Tue, 11 Dec 2018 at 16:52, Richard Sandiford > wrote: > > > > Dimitar Dimitrov writes: > > > On =D0=BF=D0=BE=D0=BD=D0=B5=D0=B4=D0=B5=D0=BB=D0=BD=D0=B8=D0=BA, 10 = =D0=B4=D0=B5=D0=BA=D0=B5=D0=BC=D0=B2=D1=80=D0=B8 2018 =D0=B3. 11:21:53 EET = Richard Sandiford wrote: > > >> Dimitar Dimitrov writes: > > >> > I have tested this fix on x86_64 host, and found no regression in = the C > > >> > and C++ testsuites. I'm marking this patch as RFC simply because = I don't > > >> > have experience with other architectures, and I don't have a setup= to > > >> > test all architectures supported by GCC. > > >> > > > >> > gcc/ChangeLog: > > >> > > > >> > 2018-12-07 Dimitar Dimitrov > > >> > > > >> > * cfgexpand.c (asm_clobber_reg_is_valid): Also produce > > >> > error when stack pointer is clobbered. > > >> > (expand_asm_stmt): Refactor clobber check in separate function. > > >> > > > >> > gcc/testsuite/ChangeLog: > > >> > > > >> > 2018-12-07 Dimitar Dimitrov > > >> > > > >> > * gcc.target/i386/pr52813.c: New test. > > >> > > > >> > Signed-off-by: Dimitar Dimitrov > > >> > > >> LGTM. Do you have a copyright assignment on file? 'Fraid this is > > >> probably big enough to need one. > > > Yes, I have copyright assignment. > > > > OK, great. I went ahead and applied the patch. > > > > Hi, > > This patch introduces a regression on arm: > FAIL: gcc.target/arm/pr77904.c (test for excess errors) > Excess errors: > /gcc/testsuite/gcc.target/arm/pr77904.c:7:3: error: Stack Pointer > register clobbered by 'sp' in 'asm' > > Indeed the testcase has an explicit: > __asm volatile ("" : : : "sp"); > which is now rejected. > > Thomas, is that mandatory to test your code to fix pr77904? > > Thanks, > > Christophe > > > Thanks, > > Richard