From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102462 invoked by alias); 29 Nov 2018 10:51:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102205 invoked by uid 89); 29 Nov 2018 10:51:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SEM_URI,SEM_URIRED,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:4516 X-HELO: mail-it1-f170.google.com Received: from mail-it1-f170.google.com (HELO mail-it1-f170.google.com) (209.85.166.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 10:51:41 +0000 Received: by mail-it1-f170.google.com with SMTP id z7so2915432iti.0 for ; Thu, 29 Nov 2018 02:51:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=2LUeKiu+Oee/SCKWgXvHImxyOEnA2pItskcwN/IeqoQ=; b=Jmrorh8ViuP84b6rzlvGx0XRIIUDLRyfqBlt7Y6EezGNCwYq3Tj6SYhssgjZGh8RsK L5nKaRpSkNwS6N28XnjYo94OxIl38JZqJ6ztppVVN3faWHJpAQJ2ovU6ObTRZVSSEEZW utIZxTH973cCeTifBpxi4oSXmrROMvuIOR1DI= MIME-Version: 1.0 From: Thomas Preudhomme Date: Thu, 29 Nov 2018 10:51:00 -0000 Message-ID: Subject: [PATCH, ARM] Error out when -mfpu set and targeting Thumb-1 To: kyrylo.tkachov@foss.arm.com, Ramana Radhakrishnan , Richard Earnshaw , gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary="000000000000af1f02057bcb7725" X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg02429.txt.bz2 --000000000000af1f02057bcb7725 Content-Type: text/plain; charset="UTF-8" Content-length: 1111 Hi, FP instructions are only enabled for TARGET_32BIT and TARGET_HARD_FLOAT but GCC only gives an error when TARGET_HARD_FLOAT is true and -mfpu is not set. Among other things, it makes some of the cmse tests (eg. gcc.target/arm/cmse/baseline/softfp.c) fail when targeting -march=armv8-m.base -mfpu= -mfloat-abi=softfp. This patch errors out when a Thumb-1 -like target is selected and a FPU is specified, thus making such tests being skipped. ChangeLog entries are as follows: *** gcc/ChangeLog *** 2018-11-28 thomas Preud'homme * config/arm/arm.c (arm_options_perform_arch_sanity_checks): Error out if targeting Thumb-1 with an FPU specified. *** gcc/testsuite/ChangeLog *** 2018-11-28 thomas Preud'homme * gcc.target/arm/thumb1_mfpu-1.c: New testcase. * gcc.target/arm/thumb1_mfpu-2.c: Likewise. Testing: No testsuite regression when targeting arm-none-eabi Armv6S-M. Fails as expected when targeting Armv6-M with an -mfpu or a default FPU. Succeeds without. Is this ok for stage3? Best regards, Thomas --000000000000af1f02057bcb7725 Content-Type: text/x-patch; charset="US-ASCII"; name="thumb1_mfpu_error.patch" Content-Disposition: attachment; filename="thumb1_mfpu_error.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jp2halcj0 Content-length: 4665 RnJvbSAwNTFlMzg1NTJkN2M1OTY4NzNlMDMwM2Y2ZWM0MjcyYjI2ZDUwOTAw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUaG9tYXMgUHJldWQn aG9tbWUgPHRob21hcy5wcmV1ZGhvbW1lQGxpbmFyby5vcmc+CkRhdGU6IFR1 ZSwgMjcgTm92IDIwMTggMTU6NTI6MzggKzAwMDAKU3ViamVjdDogW1BBVENI XSBbUEFUQ0gsIEFSTV0gRXJyb3Igb3V0IHdoZW4gLW1mcHUgc2V0IGFuZCB0 YXJnZXRpbmcgVGh1bWItMQoKSGksCgpGUCBpbnN0cnVjdGlvbnMgYXJlIG9u bHkgZW5hYmxlZCBmb3IgVEFSR0VUXzMyQklUIGFuZCBUQVJHRVRfSEFSRF9G TE9BVApidXQgR0NDIG9ubHkgZ2l2ZXMgYW4gZXJyb3Igd2hlbiBUQVJHRVRf SEFSRF9GTE9BVCBpcyB0cnVlIGFuZCAtbWZwdSBpcwpub3Qgc2V0LiBBbW9u ZyBvdGhlciB0aGluZ3MsIGl0IG1ha2VzIHNvbWUgb2YgdGhlIGNtc2UgdGVz dHMgKGVnLgpnY2MudGFyZ2V0L2FybS9jbXNlL2Jhc2VsaW5lL3NvZnRmcC5j KSBmYWlsIHdoZW4gdGFyZ2V0aW5nCi1tYXJjaD1hcm12OC1tLmJhc2UgLW1m cHU9PHNvbWV0aGluZz4gLW1mbG9hdC1hYmk9c29mdGZwLiBUaGlzIHBhdGNo CmVycm9ycyBvdXQgd2hlbiBhIFRodW1iLTEgLWxpa2UgdGFyZ2V0IGlzIHNl bGVjdGVkIGFuZCBhIEZQVSBpcwpzcGVjaWZpZWQsIHRodXMgbWFraW5nIHN1 Y2ggdGVzdHMgYmVpbmcgc2tpcHBlZC4KCkNoYW5nZUxvZyBlbnRyaWVzIGFy ZSBhcyBmb2xsb3dzOgoKKioqIGdjYy9DaGFuZ2VMb2cgKioqCgoyMDE4LTEx LTI4ICB0aG9tYXMgUHJldWQnaG9tbWUgIDx0aG9tYXMucHJldWRob21tZUBs aW5hcm8ub3JnPgoKCSogY29uZmlnL2FybS9hcm0uYyAoYXJtX29wdGlvbnNf cGVyZm9ybV9hcmNoX3Nhbml0eV9jaGVja3MpOiBFcnJvciBvdXQKCWlmIHRh cmdldGluZyBUaHVtYi0xIHdpdGggYW4gRlBVIHNwZWNpZmllZC4KCioqKiBn Y2MvdGVzdHN1aXRlL0NoYW5nZUxvZyAqKioKCjIwMTgtMTEtMjggIHRob21h cyBQcmV1ZCdob21tZSAgPHRob21hcy5wcmV1ZGhvbW1lQGxpbmFyby5vcmc+ CgoJKiBnY2MudGFyZ2V0L2FybS90aHVtYjFfbWZwdS0xLmM6IE5ldyB0ZXN0 Y2FzZS4KCSogZ2NjLnRhcmdldC9hcm0vdGh1bWIxX21mcHUtMi5jOiBMaWtl d2lzZS4KClRlc3Rpbmc6IE5vIHRlc3RzdWl0ZSByZWdyZXNzaW9uIHdoZW4g dGFyZ2V0aW5nIGFybS1ub25lLWVhYmkgQXJtdjZTLU0uCkZhaWxzIGFzIGV4 cGVjdGVkIHdoZW4gdGFyZ2V0aW5nIEFybXY2LU0gd2l0aCBhbiAtbWZwdSBv ciBhIGRlZmF1bHQgRlBVLgpTdWNjZWVkcyB3aXRob3V0LgoKSXMgdGhpcyBv ayBmb3Igc3RhZ2UzPwoKQmVzdCByZWdhcmRzLAoKVGhvbWFzCi0tLQogZ2Nj L2NvbmZpZy9hcm0vYXJtLmMgICAgICAgICAgICAgICAgICAgICAgICAgfCAz ICsrKwogZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2FybS90aHVtYjFfbWZw dS0xLmMgfCA3ICsrKysrKysKIGdjYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9h cm0vdGh1bWIxX21mcHUtMi5jIHwgOCArKysrKysrKwogMyBmaWxlcyBjaGFu Z2VkLCAxOCBpbnNlcnRpb25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgZ2Nj L3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2FybS90aHVtYjFfbWZwdS0xLmMKIGNy ZWF0ZSBtb2RlIDEwMDY0NCBnY2MvdGVzdHN1aXRlL2djYy50YXJnZXQvYXJt L3RodW1iMV9tZnB1LTIuYwoKZGlmZiAtLWdpdCBhL2djYy9jb25maWcvYXJt L2FybS5jIGIvZ2NjL2NvbmZpZy9hcm0vYXJtLmMKaW5kZXggNDBmMDU3NGUz MmUuLjFhMjA1MTIzY2Y1IDEwMDY0NAotLS0gYS9nY2MvY29uZmlnL2FybS9h cm0uYworKysgYi9nY2MvY29uZmlnL2FybS9hcm0uYwpAQCAtMzc0Nyw2ICsz NzQ3LDkgQEAgYXJtX29wdGlvbnNfcGVyZm9ybV9hcmNoX3Nhbml0eV9jaGVj a3MgKHZvaWQpCiAgICAgewogICAgICAgaWYgKGFybV9hYmkgPT0gQVJNX0FC SV9JV01NWFQpCiAJYXJtX3Bjc19kZWZhdWx0ID0gQVJNX1BDU19BQVBDU19J V01NWFQ7CisgICAgICBlbHNlIGlmIChUQVJHRVRfVEhVTUIxCisJICAgICAg ICYmIGJpdG1hcF9iaXRfcCAoYXJtX2FjdGl2ZV90YXJnZXQuaXNhLCBpc2Ff Yml0X3ZmcHYyKSkKKwllcnJvciAoIlRodW1iLTEgZG9lcyBub3QgYWxsb3cg RlAgaW5zdHJ1Y3Rpb25zIik7CiAgICAgICBlbHNlIGlmIChUQVJHRVRfSEFS RF9GTE9BVF9BQkkpCiAJewogCSAgYXJtX3Bjc19kZWZhdWx0ID0gQVJNX1BD U19BQVBDU19WRlA7CmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2djYy50 YXJnZXQvYXJtL3RodW1iMV9tZnB1LTEuYyBiL2djYy90ZXN0c3VpdGUvZ2Nj LnRhcmdldC9hcm0vdGh1bWIxX21mcHUtMS5jCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwLi41MzQ3ZTYzZjliNgotLS0gL2Rldi9u dWxsCisrKyBiL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9hcm0vdGh1bWIx X21mcHUtMS5jCkBAIC0wLDAgKzEsNyBAQAorLyogeyBkZy1kbyBjb21waWxl IH0gKi8KKy8qIHsgZGctcmVxdWlyZS1lZmZlY3RpdmUtdGFyZ2V0IGFybV90 aHVtYjFfb2sgfSAqLworLyogeyBkZy1za2lwLWlmICJpbmNvbXBhdGlibGUg ZmxvYXQgQUJJIiB7ICotKi0qIH0geyAiLW1mbG9hdC1hYmk9KiIgfSB7ICIt bWZsb2F0LWFiaT1zb2Z0ZnAiIH0gfSAqLworLyogeyBkZy1vcHRpb25zICIt bXRodW1iIC1tZnB1PXZmcCAtbWZsb2F0LWFiaT1zb2Z0ZnAiIH0gKi8KKy8q IHsgZGctZXJyb3IgIlRodW1iLTEgZG9lcyBub3QgYWxsb3cgRlAgaW5zdHJ1 Y3Rpb25zIiAiIiB7IHRhcmdldCAqLSotKiB9IDAgfSAqLworCitpbnQgZm9v OwpkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2FybS90 aHVtYjFfbWZwdS0yLmMgYi9nY2MvdGVzdHN1aXRlL2djYy50YXJnZXQvYXJt L3RodW1iMV9tZnB1LTIuYwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMC4uOTQxZWQyNmVkMDEKLS0tIC9kZXYvbnVsbAorKysgYi9n Y2MvdGVzdHN1aXRlL2djYy50YXJnZXQvYXJtL3RodW1iMV9tZnB1LTIuYwpA QCAtMCwwICsxLDggQEAKKy8qIHsgZGctZG8gY29tcGlsZSB9ICovCisvKiB7 IGRnLXJlcXVpcmUtZWZmZWN0aXZlLXRhcmdldCBhcm1fdGh1bWIxX29rIH0g Ki8KKy8qIHsgZGctc2tpcC1pZiAiaW5jb21wYXRpYmxlIGZsb2F0IEFCSSIg eyAqLSotKiB9IHsgIi1tZmxvYXQtYWJpPSoiIH0geyAiLW1mbG9hdC1hYmk9 c29mdGZwIiB9IH0gKi8KKy8qIE5vIG5lZWQgdG8gc2tpcCBpbiBwcmVzZW5j ZSBvZiAtbWZwdSBzaW5jZSBhcm1fdGh1bWIxX29rIHdpbGwgYWxyZWFkeSBm YWlsCisgICBkdWUgdG8gVGh1bWItMSB3aXRoIC1tZnB1IHdoaWNoIGlzIHRl c3RlZCBieSB0aHVtYjFfbWZwdS0xIHRlc3RjYXNlLiAgKi8KKy8qIHsgZGct b3B0aW9ucyAiLW10aHVtYiAtbWZsb2F0LWFiaT1zb2Z0ZnAiIH0gKi8KKwor aW50IGZvbzsKLS0gCjIuMTkuMQoK --000000000000af1f02057bcb7725--