public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Janus Weil <janus@gcc.gnu.org>
To: "Dominique d'Humières" <dominiq@lps.ens.fr>
Cc: Janne Blomqvist <blomqvist.janne@gmail.com>,
	Francisco Pena <fran.pena@usc.es>,
		gfortran <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Documentation of LTIME
Date: Mon, 19 Dec 2016 10:59:00 -0000	[thread overview]
Message-ID: <CAKwh3qgs36Ki2UKefYBuA-XGEGQve_pvV2sMpbqDFZg90BP0eQ@mail.gmail.com> (raw)
In-Reply-To: <CAKwh3qjvgqFRVB=Z0hqwcErsJxegfqFJffq7VVygE_a==NkPBw@mail.gmail.com>

Hi all,

I have just committed some minor additions
(https://gcc.gnu.org/viewcvs?rev=243794&root=gcc&view=rev) to
Dominique's patch at
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=243785, so that
these documentation issued are finally resolved now.

Cheers,
Janus



2016-11-26 21:45 GMT+01:00 Janus Weil <janus@gcc.gnu.org>:
>>> If not, we definitely need to fix the documentation of LTIME, since
>>> the current version simply does not work with TIME8(), unless one uses
>>> -fdefault-integer-8 (which is not mentioned in the docu).
>>
>> What about the attached patch
>
> Yes, looks good to me. Ok to commit!
>
> One minor nit (optional):
>
> @@ -9635,10 +9650,15 @@ To stat an open file: @ref{FSTAT}, to st
>
>  @table @asis
>  @item @emph{Description}:
> -Given a system time value @var{TIME} (as provided by the @code{TIME8}
> +Given a system time value @var{TIME} (as provided by the @code{TIME}
>  intrinsic), fills @var{VALUES} with values extracted from it appropriate
>  to the local time zone using @code{localtime(3)}.
>
> I would use @ref{TIME} here (there are two places where this occurs).
> Also I would add @ref{DATE_AND_TIME} to the "see also" section.
>
> Thanks,
> Janus

  reply	other threads:[~2016-12-19 10:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <42E6ADCB-E228-42B0-BF2B-E630E56C2048@lps.ens.fr>
     [not found] ` <CAC2FYYqEPKCNp88Yb7RTJtOZjuU1b-VirROSoCrRQgNwNRgm5Q@mail.gmail.com>
2016-11-26 15:49   ` Dominique d'Humières
2016-11-26 15:54     ` Janus Weil
2016-11-26 16:01       ` Janus Weil
2016-11-26 16:28         ` Dominique d'Humières
2016-11-26 16:58           ` Janus Weil
2016-11-26 17:03             ` Janus Weil
2016-11-26 17:17               ` Janne Blomqvist
2016-11-26 17:25                 ` Janus Weil
2016-11-26 18:35                   ` Dominique d'Humières
2016-11-26 20:45                     ` Janus Weil
2016-12-19 10:59                       ` Janus Weil [this message]
2016-11-26 16:19       ` Dominique d'Humières
2016-11-26 16:17     ` Francisco Pena

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKwh3qgs36Ki2UKefYBuA-XGEGQve_pvV2sMpbqDFZg90BP0eQ@mail.gmail.com \
    --to=janus@gcc.gnu.org \
    --cc=blomqvist.janne@gmail.com \
    --cc=dominiq@lps.ens.fr \
    --cc=fortran@gcc.gnu.org \
    --cc=fran.pena@usc.es \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).