From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67698 invoked by alias); 13 Feb 2018 18:24:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 67507 invoked by uid 89); 13 Feb 2018 18:24:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-yw0-f181.google.com Received: from mail-yw0-f181.google.com (HELO mail-yw0-f181.google.com) (209.85.161.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Feb 2018 18:24:38 +0000 Received: by mail-yw0-f181.google.com with SMTP id f12so4141102ywb.8; Tue, 13 Feb 2018 10:24:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=3sFOwJbWYH0uh8ZRN5vvrEnnwf4O0u2InqF2OSzVLDg=; b=DRqLYtvuC7Nem9hSPkB46bcmQi4iFH3+70CPQ8kVlI3z0c1DnGd54Yxv/iObKuQe+x BEQaRq7mdGclNcn8uZXK5axFkZKPoeW9sglhnIB174BFn+lY/DjZgZciNnUtM+GUqkJE ZjeazXULDIGVCY45Cn10vSWdtxVy9X8vjjw+SB+5Fjp3hvPzU0hB04WTK3pAkBD8PuO9 L8dWOslqCAGXIpkwz/Wy1Rw5BrrlLa0StDrNjixLwNLI6YtlYIHl7PIZ5xSARDiB7jFz eweXzefWXsXM+1umqtbwsAohL4NZsik864McgA3T+xbT6YsEjn1TbCsoi6o6f/wjJg7a gc3Q== X-Gm-Message-State: APf1xPBmKwtUoZF3beU2mbCakvqu8fL8Ow+VcA+pmye81p+qTmU/2y/j 4DKrPk1yhDUQOtyrS8hV30p/0dhIDyI3D8E/NUJS7g== X-Google-Smtp-Source: AH8x2264pnvEEa795HSgCnpcS/2FY3066awmfD2ZxQAkgV4S/i5I5skjOPUSNKhTm/VrecLq+Ytbk3ZBPskO/thsBGw= X-Received: by 10.129.134.129 with SMTP id w123mr1435929ywf.329.1518546276192; Tue, 13 Feb 2018 10:24:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.85.138 with HTTP; Tue, 13 Feb 2018 10:24:35 -0800 (PST) From: Janus Weil Date: Tue, 13 Feb 2018 18:24:00 -0000 Message-ID: Subject: [Patch, Fortran, F08] PR 84313: reject procedure pointers in COMMON blocks To: gfortran , gcc-patches , Richard Guenther , Jakub Jelinek Content-Type: multipart/mixed; boundary="001a114f32d85e2d1705651c1b2d" X-SW-Source: 2018-02/txt/msg00760.txt.bz2 --001a114f32d85e2d1705651c1b2d Content-Type: text/plain; charset="UTF-8" Content-length: 1145 Hi all, as the subject line says, the attached patch rejects procedure pointers in COMMON blocks (which is forbidden in F08). Since it's apparently legal in F03, I'm still accepting it with -std=f2003 and add that flag to a test case where this 'feature' is used. In another one, I'm adding the error message that one gets with -std=f2008. As my last submission, this fixes fallout from https://groups.google.com/forum/?fromgroups#!topic/comp.lang.fortran/AIHRQ2kJv3c. As the last one, it is a very simple fix for an accepts-invalid problem (which is not a regression), so I hope this one will also still be suitable for trunk (if not, I hope the release managers, in CC, will stop me). It does regtest cleanly on x86_64-linux-gnu. Ok for trunk? Cheers, Janus 2018-02-13 Janus Weil PR fortran/84313 * symbol.c (check_conflict): Reject procedure pointers in common blocks. 2018-02-13 Janus Weil PR fortran/84313 * gfortran.dg/proc_ptr_common_1.f90: Fix invalid test case, add necessary compiler options. * gfortran.dg/proc_ptr_common_2.f90: Add missing error message. --001a114f32d85e2d1705651c1b2d Content-Type: text/plain; charset="US-ASCII"; name="pr84313.diff" Content-Disposition: attachment; filename="pr84313.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jdlz7orf0 Content-length: 2542 SW5kZXg6IGdjYy9mb3J0cmFuL3N5bWJvbC5jCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIGdjYy9mb3J0cmFuL3N5bWJvbC5jCShyZXZpc2lvbiAyNTc1 ODkpCisrKyBnY2MvZm9ydHJhbi9zeW1ib2wuYwkod29ya2luZyBjb3B5KQpA QCAtODA5LDcgKzgwOSw5IEBAIGNoZWNrX2NvbmZsaWN0IChzeW1ib2xfYXR0 cmlidXRlICphdHRyLCBjb25zdCBjaGFyCiAJICAgIGNvbmYyICh0aHJlYWRw cml2YXRlKTsKIAl9CiAKLSAgICAgIGlmICghYXR0ci0+cHJvY19wb2ludGVy KQorICAgICAgLyogUHJvY2VkdXJlIHBvaW50ZXJzIGluIENPTU1PTiBibG9j a3MgYXJlIGFsbG93ZWQgaW4gRjAzLAorICAgICAgICogYnV0IGZvcmJpZGRl biBwZXIgRjA4OkM1MTAwLiAgKi8KKyAgICAgIGlmICghYXR0ci0+cHJvY19w b2ludGVyIHx8IChnZmNfb3B0aW9uLmFsbG93X3N0ZCAmIEdGQ19TVERfRjIw MDgpKQogCWNvbmYyIChpbl9jb21tb24pOwogCiAgICAgICBjb25mMiAob21w X2RlY2xhcmVfdGFyZ2V0X2xpbmspOwpJbmRleDogZ2NjL3Rlc3RzdWl0ZS9n Zm9ydHJhbi5kZy9wcm9jX3B0cl9jb21tb25fMS5mOTAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9wcm9j X3B0cl9jb21tb25fMS5mOTAJKHJldmlzaW9uIDI1NzU4OSkKKysrIGdjYy90 ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvcHJvY19wdHJfY29tbW9uXzEuZjkwCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDE2ICsxLDE4IEBACiAhIHsgZGctZG8gcnVu IH0KLQorISB7IGRnLW9wdGlvbnMgIi1zdGQ9ZjIwMDMgLWZhbGwtaW50cmlu c2ljcyIgfQorIQogISBQUiBmb3J0cmFuLzM2NTkyCiAhCiAhIFByb2NlZHVy ZSBQb2ludGVycyBpbnNpZGUgQ09NTU9OIGJsb2Nrcy4KKyEgKEFsbG93ZWQg aW4gRjAzLCBidXQgZm9yYmlkZGVuIGluIEYwOC4pCiAhCiAhIENvbnRyaWJ1 dGVkIGJ5IEphbnVzIFdlaWwgPGphbnVzQGdjYy5nbnUub3JnPi4KIAogc3Vi cm91dGluZSBvbmUoKQogICBpbXBsaWNpdCBub25lCi0gIGNvbW1vbiAvY29t LyBwMSxwMixhLGIKICAgcHJvY2VkdXJlKHJlYWwpLCBwb2ludGVyIDo6IHAx LHAyCiAgIGludGVnZXIgOjogYSxiCisgIGNvbW1vbiAvY29tLyBwMSxwMixh LGIKICAgaWYgKGEvPTUgLm9yLiBiLz0tOSAub3IuIHAxKDAuMCkvPTEuMCAu b3IuIHAyKDAuMCkvPTAuMCkgY2FsbCBhYm9ydCgpCiBlbmQgc3Vicm91dGlu ZSBvbmUKIApJbmRleDogZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9wcm9j X3B0cl9jb21tb25fMi5mOTAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g Z2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9wcm9jX3B0cl9jb21tb25fMi5m OTAJKHJldmlzaW9uIDI1NzU4OSkKKysrIGdjYy90ZXN0c3VpdGUvZ2ZvcnRy YW4uZGcvcHJvY19wdHJfY29tbW9uXzIuZjkwCSh3b3JraW5nIGNvcHkpCkBA IC0xMiw3ICsxMiw3IEBAIGFic3RyYWN0IGludGVyZmFjZQogZW5kIGludGVy ZmFjZQogCiBwcm9jZWR1cmUoZm9vKSwgcG9pbnRlciwgYmluZChDKSA6OiBw cm9jCi1jb21tb24gL2NvbS8gcHJvYyxyCitjb21tb24gL2NvbS8gcHJvYyxy ICAhIHsgZGctZXJyb3IgIlBST0NFRFVSRSBhdHRyaWJ1dGUgY29uZmxpY3Rz IHdpdGggQ09NTU9OIGF0dHJpYnV0ZSIgfQogCiBjb21tb24gcwogY2FsbCBz KCkgICEgeyBkZy1lcnJvciAiUFJPQ0VEVVJFIGF0dHJpYnV0ZSBjb25mbGlj dHMgd2l0aCBDT01NT04gYXR0cmlidXRlIiB9Cg== --001a114f32d85e2d1705651c1b2d--