From: Janus Weil <janus@gcc.gnu.org>
To: Tobias Burnus <burnus@net-b.de>
Cc: fortran@gcc.gnu.org, gcc patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran] PR 42418: PROCEDURE: Rejects interface which is both specific and generic procedure
Date: Tue, 31 Jul 2012 18:06:00 -0000 [thread overview]
Message-ID: <CAKwh3qiX0RhxD-d47XFBJrTs+kEXbczky3uMFr1ZLcT-5cpewQ@mail.gmail.com> (raw)
In-Reply-To: <5017F949.2010301@net-b.de>
>> The patch was regtested successfully on x86_64-unknown-linux-gnu. Ok for
>> trunk?
>
>
> The patch looks okay.
Thanks!
> I assume, the patch doesn't help to get PR 54035
> fixed,does it? (That PR is about TBP binding to the generic instead of the
> specific name.)
Not directly. Although - since they're not completely unrelated - one
might think about applying a similar strategy for that one. However, I
expect it will be a bit harder to fix. Maybe I'll have a look soon ...
In general I don't really like the sort of special-case treatment that
is needed, e.g. in this PR, to handle generics and specifics with the
same. In the long run, it might be worth to think about a separate
symtree for generics in each namespace. That would also help to
simplify the treatment of 'constructors' etc, but it's surely not a
quick'n'easy project (and I'm not sure if there are any pitfalls
lurking).
Cheers,
Janus
>> 2012-07-31 Janus Weil <janus@gcc.gnu.org>
>>
>> PR fortran/42418
>> * decl.c (match_procedure_interface): Move some checks to
>> 'resolve_procedure_interface'. Set flavor if appropriate.
>> * expr.c (gfc_check_pointer_assign): Cleanup of
>> 'gfc_is_intrinsic'.
>> * intrinsic.c (gfc_is_intrinsic): Additional checks for attributes
>> which
>> identify a procedure as being non-intrinsic.
>> * resolve.c (resolve_procedure_interface): Checks moved here from
>> 'match_procedure_interface'. Minor cleanup.
>> (resolve_formal_arglist,resolve_symbol): Cleanup of
>> 'resolve_procedure_interface'
>> (resolve_actual_arglist,is_external_proc): Cleanup of
>> 'gfc_is_intrinsic'.
>>
>> 2012-07-31 Janus Weil <janus@gcc.gnu.org>
>>
>> PR fortran/42418
>> * gfortran.dg/proc_decl_29.f90: New.
>
>
next prev parent reply other threads:[~2012-07-31 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 9:59 Janus Weil
2012-07-31 15:33 ` Tobias Burnus
2012-07-31 18:06 ` Janus Weil [this message]
2012-07-31 19:17 ` Janus Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwh3qiX0RhxD-d47XFBJrTs+kEXbczky3uMFr1ZLcT-5cpewQ@mail.gmail.com \
--to=janus@gcc.gnu.org \
--cc=burnus@net-b.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).