From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79722 invoked by alias); 18 Nov 2016 21:06:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 79687 invoked by uid 89); 18 Nov 2016 21:06:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=suspicion, claims X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-yw0-f196.google.com Received: from mail-yw0-f196.google.com (HELO mail-yw0-f196.google.com) (209.85.161.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Nov 2016 21:06:11 +0000 Received: by mail-yw0-f196.google.com with SMTP id b66so21087475ywh.2; Fri, 18 Nov 2016 13:06:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=+d9G/w8MwgZns2yz+Ef4o5wnkWNcv1OXGgoWWur8yWY=; b=a44JZnnIwo8gmAVM1WWZXx7giS0127ZfVqfCnH99QFCxlg3vtagAne4HTgXYk+2ivp +Nb37Se89u3z77+2vkA1PlBIIY5C2OeGHhJye1YE9YZCdAZFHJz4pBCu8qYT1bNK3e5c 5qmQk8Zfq4LgsuJ9+G/uN/fw689cCM50oe5lWjN/qCrSoJE7/boycYZQzr8yHXhRIOPU 3w5kKW91kg2N+73PUMY3g/4MaKGwyf6yINqaSld+o4+SmtybUsxlFfy7GKQS2aVEDFWT nmZ0iAJUpLEQknKUu1pALVee+Y2marRigC8BQE41wNtBs0fd1NXZ0/8MC1Qr4Tr6J924 i19Q== X-Gm-Message-State: AKaTC00+5hq+H4WH5z8+YEIemXyTzMZG5mfUlcsx9VYBQ2cRqusenhBTLvQaEFTeopFK4UAc7GYYyX/64C/xUw== X-Received: by 10.13.255.5 with SMTP id p5mr2003070ywf.60.1479503170349; Fri, 18 Nov 2016 13:06:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.52.2 with HTTP; Fri, 18 Nov 2016 13:06:09 -0800 (PST) In-Reply-To: <2709BC01-540E-4BB6-8266-355357EA7138@lps.ens.fr> References: <2709BC01-540E-4BB6-8266-355357EA7138@lps.ens.fr> From: Janus Weil Date: Fri, 18 Nov 2016 21:06:00 -0000 Message-ID: Subject: Re: [Patch, Fortran] PR 78392: ICE in gfc_trans_auto_array_allocation, at fortran/trans-array.c:5979 To: =?UTF-8?Q?Dominique_d=27Humi=C3=A8res?= Cc: gfortran , gcc-patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-11/txt/msg01996.txt.bz2 Hi Dominique, >> the attached patch fixes an ice-on-valid problem, simply by removing an assert. ... > > I have several instances in my test suite showing that the proposed patch removes the ICE but generates wrong code: > > pr42359, second test, => ICE on another place > pr54613, sixth and eighth tests, thanks for the comments, those cases are closely related. I previously assumed that the test case for this PR would be legal, but by now I think that's wrong. The test case should be rejected, and we already have checking mechanisms for this (see resolve_fl_variable), but apparently they are not working. My current suspicion is that 'gfc_is_constant_expr' has a bug, because it claims the call to the function 'get_i' to be a constant expression. This is not true, because get_i() can not be reduced to a compile-time constant. In any case the patch I proposed is wrong and the assert should stay. Cheers, Janus