public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Janus Weil <janus@gcc.gnu.org>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] fortran/50524 -- Check return status of resolving substring ref
Date: Sun, 16 Oct 2011 10:32:00 -0000	[thread overview]
Message-ID: <CAKwh3qjwj_MerAZ0Vs-_SsPHBqfZw4nAg6nhXjE+A3hsMOmcRg@mail.gmail.com> (raw)
In-Reply-To: <20111015223944.GA39231@troutmask.apl.washington.edu>

Hi Steve,

> resolve_ref() calls resolve_substring() but failed to check
> its return value.  This patch does the check.

Looks pretty obvious. Please commit.

Thanks for the patch,
Janus



> 2011-10-15  Steven G. Kargl  <kargl@gcc.gcu.org>
>
>        * resolve.c (resolve_ref): Check return value of resolve_substring().
>
>
> 2011-10-15  Steven G. Kargl  <kargl@gcc.gcu.org>
>
>        * gfortran.dg/substring_integer_index.f90: New test.
>

      reply	other threads:[~2011-10-16  8:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-16  8:15 Steve Kargl
2011-10-16 10:32 ` Janus Weil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKwh3qjwj_MerAZ0Vs-_SsPHBqfZw4nAg6nhXjE+A3hsMOmcRg@mail.gmail.com \
    --to=janus@gcc.gnu.org \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=sgk@troutmask.apl.washington.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).