From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26381 invoked by alias); 16 Oct 2011 08:34:41 -0000 Received: (qmail 26204 invoked by uid 22791); 16 Oct 2011 08:34:39 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-yw0-f47.google.com (HELO mail-yw0-f47.google.com) (209.85.213.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 16 Oct 2011 08:34:24 +0000 Received: by ywm39 with SMTP id 39so27496ywm.20 for ; Sun, 16 Oct 2011 01:34:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.146.223.19 with SMTP id v19mr3120005yag.14.1318754063620; Sun, 16 Oct 2011 01:34:23 -0700 (PDT) Received: by 10.147.114.1 with HTTP; Sun, 16 Oct 2011 01:34:23 -0700 (PDT) In-Reply-To: <20111015223944.GA39231@troutmask.apl.washington.edu> References: <20111015223944.GA39231@troutmask.apl.washington.edu> Date: Sun, 16 Oct 2011 10:32:00 -0000 Message-ID: Subject: Re: [PATCH] fortran/50524 -- Check return status of resolving substring ref From: Janus Weil To: Steve Kargl Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg01409.txt.bz2 Hi Steve, > resolve_ref() calls resolve_substring() but failed to check > its return value. =A0This patch does the check. Looks pretty obvious. Please commit. Thanks for the patch, Janus > 2011-10-15 =A0Steven G. Kargl =A0 > > =A0 =A0 =A0 =A0* resolve.c (resolve_ref): Check return value of resolve_s= ubstring(). > > > 2011-10-15 =A0Steven G. Kargl =A0 > > =A0 =A0 =A0 =A0* gfortran.dg/substring_integer_index.f90: New test. >