From: Sharad Singhai <singhai@google.com>
To: janis@gcc.gnu.org, Richard Biener <richard.guenther@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [PATCH] Fix ICE in vectorization dump (PR tree-optimization/55995)
Date: Fri, 18 Jan 2013 08:52:00 -0000 [thread overview]
Message-ID: <CAKxPW644nc1tcW4s1J2sQGWt9jUzgdfXg=BgNY4SPYfTVTrurQ@mail.gmail.com> (raw)
This patch fixes an ICE in vectorization dump when section anchors are present.
Bootstrapped/tested on x86_64 and PPC 64 and found no new failures. OK
for trunk?
Thanks,
Sharad
2013-01-18 Sharad Singhai <singhai@google.com>
PR tree-optimization/55995
* dumpfile.c (dump_loc): Print location only if available.
* testsuite/gcc.dg/vect/vect.exp: Use "details" flags for dump info.
* tree-vectorizer.c (increase_alignment): Intialize vect_location.
Index: dumpfile.c
===================================================================
--- dumpfile.c (revision 195244)
+++ dumpfile.c (working copy)
@@ -260,14 +260,13 @@ dump_loc (int dump_kind, FILE *dfile, source_locat
/* Currently vectorization passes print location information. */
if (dump_kind)
{
- if (loc == UNKNOWN_LOCATION)
+ if (loc != UNKNOWN_LOCATION)
+ fprintf (dfile, "\n%s:%d: note: ", LOCATION_FILE (loc),
+ LOCATION_LINE (loc));
+ else if (current_function_decl)
fprintf (dfile, "\n%s:%d: note: ",
DECL_SOURCE_FILE (current_function_decl),
DECL_SOURCE_LINE (current_function_decl));
- else
- fprintf (dfile, "\n%s:%d: note: ",
- LOCATION_FILE (loc),
- LOCATION_LINE (loc));
}
}
Index: testsuite/gcc.dg/vect/vect.exp
===================================================================
--- testsuite/gcc.dg/vect/vect.exp (revision 195244)
+++ testsuite/gcc.dg/vect/vect.exp (working copy)
@@ -156,7 +156,8 @@ dg-runtest [lsort [glob -nocomplain $srcdir/$subdi
# alignment-sensitive -fsection-anchors tests
set DEFAULT_VECTCFLAGS $SAVED_DEFAULT_VECTCFLAGS
-lappend DEFAULT_VECTCFLAGS "-fsection-anchors" "-fdump-ipa-increase_alignment"
+lappend DEFAULT_VECTCFLAGS "-fsection-anchors" \
+ "-fdump-ipa-increase_alignment-details"
dg-runtest [lsort [glob -nocomplain
$srcdir/$subdir/aligned-section-anchors-*.\[cS\]]] \
"" $DEFAULT_VECTCFLAGS
Index: tree-vectorizer.c
===================================================================
--- tree-vectorizer.c (revision 195244)
+++ tree-vectorizer.c (working copy)
@@ -225,6 +225,8 @@ increase_alignment (void)
{
struct varpool_node *vnode;
+ vect_location = UNKNOWN_LOC;
+
/* Increase the alignment of all global arrays for vectorization. */
FOR_EACH_DEFINED_VARIABLE (vnode)
{
next reply other threads:[~2013-01-18 8:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 8:52 Sharad Singhai [this message]
2013-01-18 10:04 ` Richard Biener
2013-01-18 10:11 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKxPW644nc1tcW4s1J2sQGWt9jUzgdfXg=BgNY4SPYfTVTrurQ@mail.gmail.com' \
--to=singhai@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=janis@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).