From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4053 invoked by alias); 17 Jan 2020 11:20:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 4038 invoked by uid 89); 17 Jan 2020 11:20:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-vs1-f67.google.com Received: from mail-vs1-f67.google.com (HELO mail-vs1-f67.google.com) (209.85.217.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2020 11:20:19 +0000 Received: by mail-vs1-f67.google.com with SMTP id x18so14613924vsq.4 for ; Fri, 17 Jan 2020 03:20:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4/2jPQ3X+CKSpc41asYohMJDumgTLgdW3MHdI84JFJw=; b=hQnxTKe/zGKBUqPbh42sE3Pxhdt4UmngaMTtwFCofXsERXoNeheR198um+fCyBnzec Ah4j/HbBpWurBAsWaywL5iP6LmK8gTRFYHxstJzX18QyWQr+2x6WgafLJgaos4ZDt2xK KgugeP29223ojt4UhAcLuYYBEQ3teL+NsRW43KiCSCTVo5tf0KApYrHeYUG/PhQGus7V X99smCQ3mTOLXDlmdAmX1IEjltOwmII5SlSofBcbxbmGv/xSDKQYbpYI0pSp3vOFeSEf DwO5fH46tc+UBFO0oHyZNEboCjmf1o3DY0Fi30jU2CLlsTk2VgRA+ZGalHos+eh8ae8m zkGQ== MIME-Version: 1.0 References: <20191209095229.5572-1-claziss@gmail.com> <27dc3f10-daf4-6e42-7097-738d66912434@synopsys.com> In-Reply-To: <27dc3f10-daf4-6e42-7097-738d66912434@synopsys.com> From: Claudiu Zissulescu Ianculescu Date: Fri, 17 Jan 2020 11:29:00 -0000 Message-ID: Subject: Re: [PATCH] [ARC] Use hardware support for double-precision compare instructions. To: Vineet Gupta Cc: "gcc-patches@gcc.gnu.org" , Claudiu Zissulescu , "andrew.burgess@embecosm.com" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg01031.txt.bz2 It is already ported :) https://github.com/gcc-mirror/gcc/commit/555e4a053951a0ae24835a266e71819336d7f637#diff-5b8bd26eec6c2b9f560870c205416edc Cheers, Claudiu On Wed, Jan 15, 2020 at 1:49 AM Vineet Gupta wrote: > > On 12/9/19 1:52 AM, Claudiu Zissulescu wrote: > > Although the FDCMP (the double precision floating point compare instruction) is added to the compiler, it is not properly used via cstoredi pattern. Fix it. > > > > OK to apply? > > Claudidu > > > > xxxx-xx-xx Claudiu Zissulescu > > > > * config/arc/arc.md (iterator SDF): Check TARGET_FP_DP_BASE. > > (cstoredi4): Use TARGET_HARD_FLOAT. > > --- > > gcc/config/arc/arc.md | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md > > index b592f25afce..bd44030b409 100644 > > --- a/gcc/config/arc/arc.md > > +++ b/gcc/config/arc/arc.md > > @@ -3749,7 +3749,7 @@ archs4x, archs4xd" > > }) > > > > (define_mode_iterator SDF [(SF "TARGET_FP_SP_BASE || TARGET_OPTFPE") > > - (DF "TARGET_OPTFPE")]) > > + (DF "TARGET_FP_DP_BASE || TARGET_OPTFPE")]) > > > > (define_expand "cstore4" > > [(set (reg:CC CC_REG) > > @@ -3759,7 +3759,7 @@ archs4x, archs4xd" > > (match_operator:SI 1 "comparison_operator" [(reg CC_REG) > > (const_int 0)]))] > > > > - "TARGET_FP_SP_BASE || TARGET_OPTFPE" > > + "TARGET_HARD_FLOAT || TARGET_OPTFPE" > > { > > gcc_assert (XEXP (operands[1], 0) == operands[2]); > > gcc_assert (XEXP (operands[1], 1) == operands[3]); > > Can this be backported to gcc-9 please ? > glibc testing uses gcc-9 > > Thx, > -Vineet