From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10387 invoked by alias); 13 Sep 2018 08:42:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 3758 invoked by uid 89); 13 Sep 2018 08:39:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=watched, HX-Received:sk:l3-v6mr, gcctestresults, gcc-testresults X-HELO: mail-oi0-f67.google.com Received: from mail-oi0-f67.google.com (HELO mail-oi0-f67.google.com) (209.85.218.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Sep 2018 08:39:01 +0000 Received: by mail-oi0-f67.google.com with SMTP id t68-v6so8579545oie.12 for ; Thu, 13 Sep 2018 01:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PlDdhIENMJNfPr159Soy7zbxGbvjJm0XF/QiDxaiaCA=; b=SQsC1tdkFco8fL+Hk5o/Oc70kRKy8J5XQztYVuDjuuyfgje9MTivB4shR6RZt44YHm LtLGg3FSfoBPaNDMgvoENoMQo4KKyUFDOX0xl/RSl2EsZ4LedHh3kBPODBOlo2RPh2NF 777/rJh+hK1QIk/+pZi/icSzI8iS6JCgZg+pN8oMewswyb737HZ/b2H39oUNXNrfCuFC Twfp+oUeVdvkAprdEK+Tm6SXX5evDy9fK5v6nHj07mVMaHNIz/8NUTdAEEzyajl6c2E2 9Wm4QyJYKxR+gaqmkWMfXu9rJ5x9IeRXrmTgW7M+e6zafbZO3+cDyc41nWkmwBq5eX7v PQ4Q== MIME-Version: 1.0 References: <70510d48-a6fc-7934-904a-c0ec88b79a6c@suse.cz> In-Reply-To: <70510d48-a6fc-7934-904a-c0ec88b79a6c@suse.cz> From: Joey Ye Date: Thu, 13 Sep 2018 09:08:00 -0000 Message-ID: Subject: Re: [PATCH][OBVIOUS] Close file on return from verify-intermediate To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: Joey Ye , gcc-patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00676.txt.bz2 Committed as r264202. gcov-8 still fails at r264226 according to https://gcc.gnu.org/ml/gcc-testresults/2018-09/msg01478.html So it is confirmed that this patch doesn't resolve PR85871, as Mike hoped. Thanks, Joey On Mon, Sep 10, 2018 at 3:04 PM Martin Li=C5=A1ka wrote: > > On 09/05/2018 03:29 PM, Joey Ye wrote: > > This is a fix to an obvious issue in gcov.exp, where proc verify-interm= ediate returns without closing the open file. > > > > This can be a possible fix to PR85871. gcov-8.C diffs to other gcov tes= tcases that it invokes verify-intermediate. Not closing an open file may re= sult in random failure quietly. > > > > It is only a possible fix as I failed to reproduce the PR85871 random f= ailure in my local machine despite continuous testing of multiple days. So = I cannot verify if this patch fixes the regression either. > > > > To verify, https://gcc.gnu.org/ml/gcc-testresults/ need to be watched w= hether gcov-8 regression will disappear completely one month after this pat= ch committed to trunk. > > > > Tested with make check with no new regressions. > > > > OK to trunk? > > > > testsuite/ChangeLog: > > 2018-09-05 Joey Ye > > > > * lib/gcov.exp (verify-intermediate): Add missing close. > > > > Hi. > > Thanks for the fix, it's obvious. Please install the patch. > > Note that gcov-8.C is built multiple times with different -std=3D* option= s: > > PASS: g++.dg/gcov/gcov-8.C -std=3Dgnu++98 (test for excess errors) > PASS: g++.dg/gcov/gcov-8.C -std=3Dgnu++98 execution test > PASS: g++.dg/gcov/gcov-8.C -std=3Dgnu++98 gcov > PASS: g++.dg/gcov/gcov-8.C -std=3Dgnu++11 (test for excess errors) > PASS: g++.dg/gcov/gcov-8.C -std=3Dgnu++11 execution test > PASS: g++.dg/gcov/gcov-8.C -std=3Dgnu++11 gcov > PASS: g++.dg/gcov/gcov-8.C -std=3Dgnu++14 (test for excess errors) > PASS: g++.dg/gcov/gcov-8.C -std=3Dgnu++14 execution test > PASS: g++.dg/gcov/gcov-8.C -std=3Dgnu++14 gcov > > That can cause the collisions seen in the PR. > > Martin