From: Joey Ye <joey.ye.cc@gmail.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH][ARM] Enable code hoisting with -Os (PR80155)
Date: Thu, 10 Oct 2019 10:40:00 -0000 [thread overview]
Message-ID: <CAL0py26NXyEnFrDi-TQ5xt50Tqx3O5cDjODqV-6-e1Et9npYWg@mail.gmail.com> (raw)
In-Reply-To: <HE1PR0801MB212194851187F71FADA5151783B10@HE1PR0801MB2121.eurprd08.prod.outlook.com>
Committed to ARM/arm-9-branch
On Wed, Sep 11, 2019 at 4:50 PM Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
>
> While code hoisting generally improves codesize, it can affect performance
> negatively. Benchmarking shows it doesn't help SPEC and negatively affects
> embedded benchmarks, so only enable code hoisting with -Os on Arm.
>
> Bootstrap OK, OK for commit?
>
> ChangeLog:
> 2019-09-11 Wilco Dijkstra <wdijkstr@arm.com>
>
>
> PR tree-optimization/80155
> * common/config/arm/arm-common.c (arm_option_optimization_table):
> Enable -fcode-hoisting with -Os.
>
> --
> diff --git a/gcc/common/config/arm/arm-common.c b/gcc/common/config/arm/arm-common.c
> index 41a920f6dc96833e778faa8dbcc19beac483734c..b0d5fb300bf01acc1fb6f4631635f8a1bfe6441c 100644
> --- a/gcc/common/config/arm/arm-common.c
> +++ b/gcc/common/config/arm/arm-common.c
> @@ -39,6 +39,8 @@ static const struct default_options arm_option_optimization_table[] =
> /* Enable section anchors by default at -O1 or higher. */
> { OPT_LEVELS_1_PLUS, OPT_fsection_anchors, NULL, 1 },
> { OPT_LEVELS_1_PLUS, OPT_fsched_pressure, NULL, 1 },
> + /* Enable code hoisting only with -Os. */
> + { OPT_LEVELS_SIZE, OPT_fcode_hoisting, NULL, 1 },
> { OPT_LEVELS_NONE, 0, NULL, 0 }
> };
>
>
prev parent reply other threads:[~2019-10-10 10:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 15:50 Wilco Dijkstra
2019-09-12 9:54 ` Richard Biener
2019-09-12 11:29 ` Wilco Dijkstra
2019-09-12 11:55 ` Richard Biener
2019-09-14 21:49 ` Prathamesh Kulkarni
2019-09-16 12:58 ` Wilco Dijkstra
2019-09-16 13:31 ` Richard Biener
2019-09-17 17:18 ` Wilco Dijkstra
2019-09-18 8:47 ` Richard Biener
2019-09-18 16:47 ` Prathamesh Kulkarni
2019-09-19 1:28 ` Prathamesh Kulkarni
2019-09-19 10:47 ` Richard Biener
2019-09-19 10:37 ` Richard Biener
2019-10-10 10:40 ` Joey Ye [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL0py26NXyEnFrDi-TQ5xt50Tqx3O5cDjODqV-6-e1Et9npYWg@mail.gmail.com \
--to=joey.ye.cc@gmail.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).