From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by sourceware.org (Postfix) with ESMTPS id 429823858D28 for ; Sun, 30 Jan 2022 02:29:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 429823858D28 Received: by mail-io1-xd31.google.com with SMTP id n17so12542051iod.4 for ; Sat, 29 Jan 2022 18:29:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3z6p3uofrMxkc3USDw4tgbftwU+CuDWt8QAvEbpwfQ0=; b=2WICls+GNAuCG7jnzx9nFZ8+gRX+RwGNg4qwhYMSkB61jcgX6W4WehfmMYWW2z9rTY fK6aEolOHuEz5S/PDnLvMX7pupPbKghAPjKfP9K9zET7/gKChEGh4MOj7HaAwizMJOYw 05Q76rbvPdlP2PxbWdFaxAKuZhwC15kJQ4FuQmkcyAXEm54zw1lhC5lrqsmQLSGXn3mo 20Gjv/txYT4sTl5HH41wcuY0EpiusvaVNu5ELBNm+GJxSxdnQx/hNTAdKh7yFNFl/Q8i kkuZfgR/hVAoh9Ze3i3PrQ5byRao9eR1zf0igwCFOYo0UZ2zB31tBFaAh59XZbv5m5u1 kDQg== X-Gm-Message-State: AOAM5303jAjS89Spn6nk5l4lvQWtdaHbaqqZpsV33/PMpmDSGbxrFDnw 4IUOGLZyNnUc6q7Z4gJcITIyyH7S7XUUGbIlQk0= X-Google-Smtp-Source: ABdhPJxW7e9RrQx/JtQsjM7vzJJT37R6fbQ4zpTmOZr/aWTiFE7iYHAD89xKjb1mRVlUSpvV9m3RVMTudmcUk4kI0Fo= X-Received: by 2002:a02:aa0a:: with SMTP id r10mr1278277jam.246.1643509759521; Sat, 29 Jan 2022 18:29:19 -0800 (PST) MIME-Version: 1.0 References: <20220129162334.GV2646553@tucnak> In-Reply-To: From: Zhao Wei Liew Date: Sun, 30 Jan 2022 10:28:43 +0800 Message-ID: Subject: Re: [PATCH] match.pd: Fix up 1 / X for unsigned X optimization [PR104280] To: Jeff Law , Jakub Jelinek Cc: Richard Biener , GCC Patches X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jan 2022 02:29:21 -0000 Sincere apologies for the issues. I wasn't aware of the need for a cast but after reading the PRs, I understand that now. On the other hand, the incorrect test case was simply a major oversight on my part. I'll be sure to be more careful next time. Thanks for the fixes!