From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id B538F3858C60 for ; Tue, 2 Nov 2021 10:46:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B538F3858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-lf1-x136.google.com with SMTP id bu18so24901269lfb.0 for ; Tue, 02 Nov 2021 03:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/Z0TpK0viBolg4MP99K3Fff96I6cYMOpV3Xo6jM3t7U=; b=QKSeFckviPQUT83zQeRDo7XP+3HlP/U7Xuk0pcGDEI8svMhPvDu76Ee2A/XWQ3fO1a MAkCIUwGnfgaxbFKS2VRCAYi4PWO5W1piOGi3xbRFbH8ki3Wh8oCfpgP2xzuMONphwIo gbVH6A+jE/vZi5XmYhi1rONrqSBv1kcH7rSohFrcQAGVNdUfIncW5qpEDZLN7ldzaIis WZLIGjOurIt1ZbyBYET2v7qOrb9E37GZ2yOvnBqvLG1za5vlBCp/Ehnm+Uyyq7pbEjUZ I9Qi+sLnAyFh1khobJDWGw3D/sigDNuzI6IbGr7rw+gSPKFFwilhWpO0xJz1iXQj4LWC rVLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/Z0TpK0viBolg4MP99K3Fff96I6cYMOpV3Xo6jM3t7U=; b=mpTJMHZP7ODwLAiKMBcUKgAuc9RfKsrl+Hbq4aJJJN5VghuOHoertF8gc9mr6V4JuN sQDX5+ZzoD02xFIWRJ9xBciYmyx8vzrp4jf1ATL8qww7wjAI9oipbVd+IycmhvsMvi8e 5iero1cqL9n3B4fOoeSoNgp3QnniSOkh5iFOyaUenspX/YOmtpzvbkLxySYzQPRmZd33 1+nsS+y1kUQWU6JHBDeOpiJJtzTLRqGVGFNgbDqnDtzEIyos0Dcf18QsQIJAUluG6uTz lDTzIuxzUJF4gl2XGfHvVsuVmpNMnlFJ8s1eXufqfsLnVI+mxToZNpzoxCuQiOQxKzI3 4yNg== X-Gm-Message-State: AOAM532yYjKhcF1a6ejAEASNsGyhENBmwQ0cG9yr85iZwJ0Ds27bHv7r 8DR5mLdlF0Wu+CLP6OtI8+KMLja63sVjF17PIDBj7Q== X-Google-Smtp-Source: ABdhPJwcwt5vkfDIxGLrUUTWs9GpB/sQYteL8Hod+T8MhUS5y7X0SAFJ7ctCOhXNJtsHpfsPdRK//JzTkhGGnHcM8A4= X-Received: by 2002:ac2:47e6:: with SMTP id b6mr10429268lfp.285.1635849959623; Tue, 02 Nov 2021 03:45:59 -0700 (PDT) MIME-Version: 1.0 References: <20211031093445.1414518-1-siyu@isrc.iscas.ac.cn> <20211031093445.1414518-2-siyu@isrc.iscas.ac.cn> In-Reply-To: <20211031093445.1414518-2-siyu@isrc.iscas.ac.cn> From: Kito Cheng Date: Tue, 2 Nov 2021 18:45:48 +0800 Message-ID: Subject: Re: [PATCH 01/21] Fix riscv_expand_block_move To: siyu@isrc.iscas.ac.cn Cc: GCC Patches , Jim Wilson , Christoph Muellner , Palmer Dabbelt , Andrew Waterman , =?UTF-8?B?V2VpIFd1ICjlkLTkvJ8p?= , jiawei , ben.marshall@pqshield.com, mjos@pqshield.com, Richard.Newell@microchip.com, linsinan1995 <47880367+linsinan1995@users.noreply.github.com> Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2021 10:46:03 -0000 IIRC this issue should be resolved? https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99314 On Sun, Oct 31, 2021 at 5:34 PM wrote: > > From: linsinan1995 <47880367+linsinan1995@users.noreply.github.com> > > --- > gcc/config/riscv/riscv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/riscv.c b/gcc/config/riscv/riscv.c > index 6aef3d3a6cf..0529b6d60cd 100644 > --- a/gcc/config/riscv/riscv.c > +++ b/gcc/config/riscv/riscv.c > @@ -3491,7 +3491,7 @@ riscv_block_move_loop (rtx dest, rtx src, unsigned HOST_WIDE_INT length, > bool > riscv_expand_block_move (rtx dest, rtx src, rtx length) > { > - if (CONST_INT_P (length)) > + if (CONST_INT_P (length) && INTVAL (length) >= 0) > { > unsigned HOST_WIDE_INT hwi_length = UINTVAL (length); > unsigned HOST_WIDE_INT factor, align; > -- > 2.25.1 >