From: Kito Cheng <kito.cheng@sifive.com>
To: Christoph Muellner <christoph.muellner@vrull.eu>
Cc: gcc-patches@gcc.gnu.org, Jim Wilson <jim.wilson.gcc@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Jeff Law <jeffreyalaw@gmail.com>
Subject: Re: [PATCH] RISC-V: Add ABI requirement for XTheadFMemIdx tests
Date: Tue, 7 Nov 2023 09:18:56 +0800 [thread overview]
Message-ID: <CALLt3TghwQD-L+TLmH12npT15t3Bq3T=340MpNN+Fnb1snMvJQ@mail.gmail.com> (raw)
In-Reply-To: <20231106194442.1446416-1-christoph.muellner@vrull.eu>
LGTM, and maybe change stdint.h to stdint-gcc.h in
xtheadmemidx-helpers.h? that could make it more portable on multi-lib
testing.
On Tue, Nov 7, 2023 at 3:44 AM Christoph Muellner
<christoph.muellner@vrull.eu> wrote:
>
> From: Christoph Müllner <christoph.muellner@vrull.eu>
>
> The XTheadFMemIdx tests set the required ABI for RV32, but not
> for RV64, which has the effect that the tests are expected to
> succeed for RV64/LP64. Let's set the ABI to LP64D in these
> tests to clarify the requirements.
>
> Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/riscv/xtheadfmemidx-index-update.c: Add ABI.
> * gcc.target/riscv/xtheadfmemidx-index-xtheadbb-update.c: Likewise.
> * gcc.target/riscv/xtheadfmemidx-index-xtheadbb.c: Likewise.
> * gcc.target/riscv/xtheadfmemidx-index.c: Likewise.
> * gcc.target/riscv/xtheadfmemidx-uindex-update.c: Likewise.
> * gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb-update.c: Likewise.
> * gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb.c: Likewise.
> * gcc.target/riscv/xtheadfmemidx-uindex.c: Likewise.
> ---
> gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-update.c | 2 +-
> .../gcc.target/riscv/xtheadfmemidx-index-xtheadbb-update.c | 2 +-
> gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb.c | 2 +-
> gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index.c | 2 +-
> gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-update.c | 2 +-
> .../gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb-update.c | 2 +-
> gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb.c | 2 +-
> gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex.c | 2 +-
> 8 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-update.c b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-update.c
> index 24bbb63d174..cb86b8ad296 100644
> --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-update.c
> +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-update.c
> @@ -1,6 +1,6 @@
> /* { dg-do compile } */
> /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */
> -/* { dg-options "-march=rv64gc_xtheadmemidx_xtheadfmemidx" { target { rv64 } } } */
> +/* { dg-options "-march=rv64gc_xtheadmemidx_xtheadfmemidx -mabi=lp64d" { target { rv64 } } } */
> /* { dg-options "-march=rv32imafc_xtheadmemidx_xtheadfmemidx -mabi=ilp32f" { target { rv32 } } } */
>
> #include "xtheadmemidx-helpers.h"
> diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb-update.c b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb-update.c
> index 3b931a4b980..cc3f6219c05 100644
> --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb-update.c
> +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb-update.c
> @@ -1,6 +1,6 @@
> /* { dg-do compile } */
> /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */
> -/* { dg-options "-march=rv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx" { target { rv64 } } } */
> +/* { dg-options "-march=rv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx -mabi=lp64d" { target { rv64 } } } */
> /* { dg-options "-march=rv32imafc_xtheadbb_xtheadmemidx_xtheadfmemidx -mabi=ilp32f" { target { rv32 } } } */
>
> #include "xtheadmemidx-helpers.h"
> diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb.c b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb.c
> index 48858605c24..8ee98c87469 100644
> --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb.c
> +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb.c
> @@ -1,6 +1,6 @@
> /* { dg-do compile } */
> /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */
> -/* { dg-options "-march=rv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx" { target { rv64 } } } */
> +/* { dg-options "-march=rv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx -mabi=lp64d" { target { rv64 } } } */
> /* { dg-options "-march=rv32imafc_xtheadbb_xtheadmemidx_xtheadfmemidx -mabi=ilp32f" { target { rv32 } } } */
>
> #include "xtheadmemidx-helpers.h"
> diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index.c b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index.c
> index 1bb231a9e88..35704063598 100644
> --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index.c
> +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index.c
> @@ -1,6 +1,6 @@
> /* { dg-do compile } */
> /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */
> -/* { dg-options "-march=rv64gc_xtheadmemidx_xtheadfmemidx" { target { rv64 } } } */
> +/* { dg-options "-march=rv64gc_xtheadmemidx_xtheadfmemidx -mabi=lp64d" { target { rv64 } } } */
> /* { dg-options "-march=rv32imafc_xtheadmemidx_xtheadfmemidx -mabi=ilp32f" { target { rv32 } } } */
>
> #include "xtheadmemidx-helpers.h"
> diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-update.c b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-update.c
> index bc50fa799e0..37ffe6afd53 100644
> --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-update.c
> +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-update.c
> @@ -1,6 +1,6 @@
> /* { dg-do compile } */
> /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */
> -/* { dg-options "-march=rv64gc_xtheadmemidx_xtheadfmemidx" { target { rv64 } } } */
> +/* { dg-options "-march=rv64gc_xtheadmemidx_xtheadfmemidx -mabi=lp64d" { target { rv64 } } } */
> /* { dg-options "-march=rv32imafc_xtheadmemidx_xtheadfmemidx -mabi=ilp32f" { target { rv32 } } } */
>
> #include "xtheadmemidx-helpers.h"
> diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb-update.c b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb-update.c
> index 242be7af4a4..95bf3e616b8 100644
> --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb-update.c
> +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb-update.c
> @@ -1,6 +1,6 @@
> /* { dg-do compile } */
> /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */
> -/* { dg-options "-march=rv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx" { target { rv64 } } } */
> +/* { dg-options "-march=rv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx -mabi=lp64d" { target { rv64 } } } */
> /* { dg-options "-march=rv32imafc_xtheadbb_xtheadmemidx_xtheadfmemidx -mabi=ilp32f" { target { rv32 } } } */
>
> #include "xtheadmemidx-helpers.h"
> diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb.c b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb.c
> index e2a4f36796f..5b57bb0a738 100644
> --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb.c
> +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb.c
> @@ -1,6 +1,6 @@
> /* { dg-do compile } */
> /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */
> -/* { dg-options "-march=rv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx" { target { rv64 } } } */
> +/* { dg-options "-march=rv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx -mabi=lp64d" { target { rv64 } } } */
> /* { dg-options "-march=rv32imafc_xtheadbb_xtheadmemidx_xtheadfmemidx -mabi=ilp32f" { target { rv32 } } } */
>
> #include "xtheadmemidx-helpers.h"
> diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex.c b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex.c
> index 32783ebed03..268a31ba21d 100644
> --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex.c
> +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex.c
> @@ -1,6 +1,6 @@
> /* { dg-do compile } */
> /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */
> -/* { dg-options "-march=rv64gc_xtheadmemidx_xtheadfmemidx" { target { rv64 } } } */
> +/* { dg-options "-march=rv64gc_xtheadmemidx_xtheadfmemidx -mabi=lp64d" { target { rv64 } } } */
> /* { dg-options "-march=rv32imafc_xtheadmemidx_xtheadfmemidx -mabi=ilp32f" { target { rv32 } } } */
>
> #include "xtheadmemidx-helpers.h"
> --
> 2.41.0
>
next prev parent reply other threads:[~2023-11-07 1:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 19:44 Christoph Muellner
2023-11-07 1:18 ` Kito Cheng [this message]
2023-11-07 9:46 ` Christoph Müllner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALLt3TghwQD-L+TLmH12npT15t3Bq3T=340MpNN+Fnb1snMvJQ@mail.gmail.com' \
--to=kito.cheng@sifive.com \
--cc=andrew@sifive.com \
--cc=christoph.muellner@vrull.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).