From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id 431203858404 for ; Tue, 7 Nov 2023 01:19:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 431203858404 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 431203858404 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699319951; cv=none; b=kqjOrmueY2Wk6RQdUOuWd+UBxjDY3ydqxHPE7bLv415+3Pn1CdDKvQxdZazlRt/qTob9DN6YcBneuOhxBBcsLZk2hL+LvyhVEm+Q4jntMoSoSLioOHPRDii+OiZo+aT334irbnC5dPlbJu2YpdTBk8KJNILNnyKhOOCY5cXckLA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699319951; c=relaxed/simple; bh=dwW1ECmBWSbORMnpn4/cwd2iehJv+6KiKePGCa7nd/g=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=fd1yM20MeUKYesmG/VTTLBUFS3NcGEq25M4AL6cFz5aH/m3AxA6+ARmqLTrTG73KHLLrWCORjBjyAAQck/yTiOwrh4k3kS3jAuIsOqkU8lz9BHsmiUYTShKOL7zpOSLtKhUr0QuETpvk4B/VMGlVMLuyeMi010kKq09b/GaWRa8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2c59a4dd14cso68874361fa.2 for ; Mon, 06 Nov 2023 17:19:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1699319947; x=1699924747; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xzNdiG/Wwi5qxyfUlL5okqkzEYXJXGRou8ESkDgxEsY=; b=iTDy9uDgcXqMWEaC3UutYO7q/7vJ/SMo2SV1fEWsz26JmHyq22+VMmEdSaKSTavdWF b/Lj4FbtmKTjh0Hl/2MoQaZNdralzqqtC7TLUPo8BekFTUHuzHI6tcXKnK+gqjLhbamZ UPYlk5ydbS5GhMP++Roicx8AneczJnK7c8ENp97/WM7paI52iZkAnrp5vsWxzbIy5WwX k4pvbOnaxa+o+/CqvZcJREWlGQzmOP8Tez8HGLefQ9ookFlsN+YbDsicfpkoGyazAaws aFZHX/r+cxdHNTsFzQ49A2BfS6z4APfloZd9nTQz0x1mff3sNOa42lmNvw624soOqJLK Atqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699319947; x=1699924747; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xzNdiG/Wwi5qxyfUlL5okqkzEYXJXGRou8ESkDgxEsY=; b=EkETj9DgCqYnmL4wJ9s7iNz3cm9dRDJk4GHqqZaXBeSCnQC+ooo9rlu5CJ18sYdtLi CxaidbCWyK6GhLhEfDV76j5nm4Ia41FB31wVFnPRolOOHzsjwuUgoR33wgN+KVJ9iBmO 1uk+tDwHOsaWeXn/YAUr6piXBgHom2rEs38A7ObMvPMyk6wnfQMpbvkENHWaKfMhc9a+ kLwDi7Nilj1c/Zd66llYrUiHP8rcm85VMWzgpr/kvTCt9wuNL51C8DpR/hA8Mc9S8ajr IVEh1QHupE+spNQggzm0l1yh4+A2/fQQOoFY8Kjk1AL1VkeMjYr/EXxdDgAeSwASV0u9 O+Qg== X-Gm-Message-State: AOJu0YzAdsQ1n1bsX9yyl/PwnSBKmfPONx0nGPkqsMh0ar2L3cFlPRg5 gSke4Nl0VWsbdg/XoEIEU8if+T+12/hoGWrjfchFpQ== X-Google-Smtp-Source: AGHT+IHwCn78j+lesjXL6QwuwKVXo/peYRTENZgwSlkZLaFZCbJavCTfoTbG769aIX2+y48izWxC4whv/aivTUplkt4= X-Received: by 2002:a2e:99c2:0:b0:2c6:ef19:4658 with SMTP id l2-20020a2e99c2000000b002c6ef194658mr12524206ljj.48.1699319947391; Mon, 06 Nov 2023 17:19:07 -0800 (PST) MIME-Version: 1.0 References: <20231106194442.1446416-1-christoph.muellner@vrull.eu> In-Reply-To: <20231106194442.1446416-1-christoph.muellner@vrull.eu> From: Kito Cheng Date: Tue, 7 Nov 2023 09:18:56 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Add ABI requirement for XTheadFMemIdx tests To: Christoph Muellner Cc: gcc-patches@gcc.gnu.org, Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Jeff Law Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM, and maybe change stdint.h to stdint-gcc.h in xtheadmemidx-helpers.h? that could make it more portable on multi-lib testing. On Tue, Nov 7, 2023 at 3:44=E2=80=AFAM Christoph Muellner wrote: > > From: Christoph M=C3=BCllner > > The XTheadFMemIdx tests set the required ABI for RV32, but not > for RV64, which has the effect that the tests are expected to > succeed for RV64/LP64. Let's set the ABI to LP64D in these > tests to clarify the requirements. > > Signed-off-by: Christoph M=C3=BCllner > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/xtheadfmemidx-index-update.c: Add ABI. > * gcc.target/riscv/xtheadfmemidx-index-xtheadbb-update.c: Likewis= e. > * gcc.target/riscv/xtheadfmemidx-index-xtheadbb.c: Likewise. > * gcc.target/riscv/xtheadfmemidx-index.c: Likewise. > * gcc.target/riscv/xtheadfmemidx-uindex-update.c: Likewise. > * gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb-update.c: Likewi= se. > * gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb.c: Likewise. > * gcc.target/riscv/xtheadfmemidx-uindex.c: Likewise. > --- > gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-update.c | 2 +- > .../gcc.target/riscv/xtheadfmemidx-index-xtheadbb-update.c | 2 +- > gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb.c | 2 +- > gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index.c | 2 +- > gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-update.c | 2 +- > .../gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb-update.c | 2 +- > gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb.c | 2 +- > gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex.c | 2 +- > 8 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-update.c = b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-update.c > index 24bbb63d174..cb86b8ad296 100644 > --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-update.c > +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-update.c > @@ -1,6 +1,6 @@ > /* { dg-do compile } */ > /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */ > -/* { dg-options "-march=3Drv64gc_xtheadmemidx_xtheadfmemidx" { target { = rv64 } } } */ > +/* { dg-options "-march=3Drv64gc_xtheadmemidx_xtheadfmemidx -mabi=3Dlp64= d" { target { rv64 } } } */ > /* { dg-options "-march=3Drv32imafc_xtheadmemidx_xtheadfmemidx -mabi=3Di= lp32f" { target { rv32 } } } */ > > #include "xtheadmemidx-helpers.h" > diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb-= update.c b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb-upda= te.c > index 3b931a4b980..cc3f6219c05 100644 > --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb-update.= c > +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb-update.= c > @@ -1,6 +1,6 @@ > /* { dg-do compile } */ > /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */ > -/* { dg-options "-march=3Drv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx" { = target { rv64 } } } */ > +/* { dg-options "-march=3Drv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx -ma= bi=3Dlp64d" { target { rv64 } } } */ > /* { dg-options "-march=3Drv32imafc_xtheadbb_xtheadmemidx_xtheadfmemidx = -mabi=3Dilp32f" { target { rv32 } } } */ > > #include "xtheadmemidx-helpers.h" > diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb.= c b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb.c > index 48858605c24..8ee98c87469 100644 > --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb.c > +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index-xtheadbb.c > @@ -1,6 +1,6 @@ > /* { dg-do compile } */ > /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */ > -/* { dg-options "-march=3Drv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx" { = target { rv64 } } } */ > +/* { dg-options "-march=3Drv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx -ma= bi=3Dlp64d" { target { rv64 } } } */ > /* { dg-options "-march=3Drv32imafc_xtheadbb_xtheadmemidx_xtheadfmemidx = -mabi=3Dilp32f" { target { rv32 } } } */ > > #include "xtheadmemidx-helpers.h" > diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index.c b/gcc/t= estsuite/gcc.target/riscv/xtheadfmemidx-index.c > index 1bb231a9e88..35704063598 100644 > --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index.c > +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-index.c > @@ -1,6 +1,6 @@ > /* { dg-do compile } */ > /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */ > -/* { dg-options "-march=3Drv64gc_xtheadmemidx_xtheadfmemidx" { target { = rv64 } } } */ > +/* { dg-options "-march=3Drv64gc_xtheadmemidx_xtheadfmemidx -mabi=3Dlp64= d" { target { rv64 } } } */ > /* { dg-options "-march=3Drv32imafc_xtheadmemidx_xtheadfmemidx -mabi=3Di= lp32f" { target { rv32 } } } */ > > #include "xtheadmemidx-helpers.h" > diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-update.c= b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-update.c > index bc50fa799e0..37ffe6afd53 100644 > --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-update.c > +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-update.c > @@ -1,6 +1,6 @@ > /* { dg-do compile } */ > /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */ > -/* { dg-options "-march=3Drv64gc_xtheadmemidx_xtheadfmemidx" { target { = rv64 } } } */ > +/* { dg-options "-march=3Drv64gc_xtheadmemidx_xtheadfmemidx -mabi=3Dlp64= d" { target { rv64 } } } */ > /* { dg-options "-march=3Drv32imafc_xtheadmemidx_xtheadfmemidx -mabi=3Di= lp32f" { target { rv32 } } } */ > > #include "xtheadmemidx-helpers.h" > diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb= -update.c b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb-up= date.c > index 242be7af4a4..95bf3e616b8 100644 > --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb-update= .c > +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb-update= .c > @@ -1,6 +1,6 @@ > /* { dg-do compile } */ > /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */ > -/* { dg-options "-march=3Drv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx" { = target { rv64 } } } */ > +/* { dg-options "-march=3Drv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx -ma= bi=3Dlp64d" { target { rv64 } } } */ > /* { dg-options "-march=3Drv32imafc_xtheadbb_xtheadmemidx_xtheadfmemidx = -mabi=3Dilp32f" { target { rv32 } } } */ > > #include "xtheadmemidx-helpers.h" > diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb= .c b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb.c > index e2a4f36796f..5b57bb0a738 100644 > --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb.c > +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex-xtheadbb.c > @@ -1,6 +1,6 @@ > /* { dg-do compile } */ > /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */ > -/* { dg-options "-march=3Drv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx" { = target { rv64 } } } */ > +/* { dg-options "-march=3Drv64gc_xtheadbb_xtheadmemidx_xtheadfmemidx -ma= bi=3Dlp64d" { target { rv64 } } } */ > /* { dg-options "-march=3Drv32imafc_xtheadbb_xtheadmemidx_xtheadfmemidx = -mabi=3Dilp32f" { target { rv32 } } } */ > > #include "xtheadmemidx-helpers.h" > diff --git a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex.c b/gcc/= testsuite/gcc.target/riscv/xtheadfmemidx-uindex.c > index 32783ebed03..268a31ba21d 100644 > --- a/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex.c > +++ b/gcc/testsuite/gcc.target/riscv/xtheadfmemidx-uindex.c > @@ -1,6 +1,6 @@ > /* { dg-do compile } */ > /* { dg-skip-if "" { *-*-* } { "-O0" "-O1" "-Og" } } */ > -/* { dg-options "-march=3Drv64gc_xtheadmemidx_xtheadfmemidx" { target { = rv64 } } } */ > +/* { dg-options "-march=3Drv64gc_xtheadmemidx_xtheadfmemidx -mabi=3Dlp64= d" { target { rv64 } } } */ > /* { dg-options "-march=3Drv32imafc_xtheadmemidx_xtheadfmemidx -mabi=3Di= lp32f" { target { rv32 } } } */ > > #include "xtheadmemidx-helpers.h" > -- > 2.41.0 >