From: Kito Cheng <kito.cheng@sifive.com>
To: Christoph Muellner <christoph.muellner@vrull.eu>
Cc: gcc-patches@gcc.gnu.org, Jim Wilson <jim.wilson.gcc@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
JuzheZhong <juzhe.zhong@rivai.ai>,
Jojo R <rjiejie@linux.alibaba.com>
Subject: Re: [PATCH] target/109296 - riscv: Add missing mode specifiers for XTheadMemPair
Date: Mon, 27 Mar 2023 19:55:47 +0800 [thread overview]
Message-ID: <CALLt3TgxS=4E9V4QkANgpSLvdFs1Umz8qKSNfQQZaYNcE1ANdg@mail.gmail.com> (raw)
In-Reply-To: <20230327110422.3353876-1-christoph.muellner@vrull.eu>
[-- Attachment #1: Type: text/plain, Size: 2490 bytes --]
OK for trunk, thanks :)
On Mon, Mar 27, 2023 at 7:04 PM Christoph Muellner <
christoph.muellner@vrull.eu> wrote:
> From: Christoph Müllner <christoph.muellner@vrull.eu>
>
> This patch adds missing mode specifiers for XTheadMemPair INSNs.
>
> gcc/ChangeLog:
> PR target/109296
> * config/riscv/thead.md: Add missing mode specifiers.
>
> Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
> ---
> gcc/config/riscv/thead.md | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/gcc/config/riscv/thead.md b/gcc/config/riscv/thead.md
> index 63c4af6f77d..0623607d3dc 100644
> --- a/gcc/config/riscv/thead.md
> +++ b/gcc/config/riscv/thead.md
> @@ -321,10 +321,10 @@ (define_insn "*th_mempair_store_<GPR:mode>2"
>
> ;; MEMPAIR load DI extended signed SI
> (define_insn "*th_mempair_load_extendsidi2"
> - [(set (match_operand 0 "register_operand" "=r")
> - (sign_extend:DI (match_operand 1 "memory_operand" "m")))
> - (set (match_operand 2 "register_operand" "=r")
> - (sign_extend:DI (match_operand 3 "memory_operand" "m")))]
> + [(set (match_operand:DI 0 "register_operand" "=r")
> + (sign_extend:DI (match_operand:SI 1 "memory_operand" "m")))
> + (set (match_operand:DI 2 "register_operand" "=r")
> + (sign_extend:DI (match_operand:SI 3 "memory_operand" "m")))]
> "TARGET_XTHEADMEMPAIR && TARGET_64BIT && reload_completed
> && th_mempair_operands_p (operands, true, SImode)"
> { return th_mempair_output_move (operands, true, SImode, SIGN_EXTEND); }
> @@ -334,10 +334,10 @@ (define_insn "*th_mempair_load_extendsidi2"
>
> ;; MEMPAIR load DI extended unsigned SI
> (define_insn "*th_mempair_load_zero_extendsidi2"
> - [(set (match_operand 0 "register_operand" "=r")
> - (zero_extend:DI (match_operand 1 "memory_operand" "m")))
> - (set (match_operand 2 "register_operand" "=r")
> - (zero_extend:DI (match_operand 3 "memory_operand" "m")))]
> + [(set (match_operand:DI 0 "register_operand" "=r")
> + (zero_extend:DI (match_operand:SI 1 "memory_operand" "m")))
> + (set (match_operand:DI 2 "register_operand" "=r")
> + (zero_extend:DI (match_operand:SI 3 "memory_operand" "m")))]
> "TARGET_XTHEADMEMPAIR && TARGET_64BIT && reload_completed
> && th_mempair_operands_p (operands, true, SImode)"
> { return th_mempair_output_move (operands, true, SImode, ZERO_EXTEND); }
> --
> 2.39.2
>
>
next prev parent reply other threads:[~2023-03-27 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 11:04 Christoph Muellner
2023-03-27 11:55 ` Kito Cheng [this message]
2023-03-27 12:19 ` Philipp Tomsich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALLt3TgxS=4E9V4QkANgpSLvdFs1Umz8qKSNfQQZaYNcE1ANdg@mail.gmail.com' \
--to=kito.cheng@sifive.com \
--cc=andrew@sifive.com \
--cc=christoph.muellner@vrull.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jim.wilson.gcc@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
--cc=rjiejie@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).