From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id 19AF93858C41 for ; Wed, 17 May 2023 02:22:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 19AF93858C41 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-25343f0c693so123085a91.3 for ; Tue, 16 May 2023 19:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1684290122; x=1686882122; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+tASGVUdkOe6w3QclEAM4IjqpZCGSuBlsuW/zkBugSc=; b=eHcpqF46h21ZcL1ove5lF0SxXNrsd0SjlEKemqYIe4jDgJMl/b7EyUcPECXNETyrA/ M/8hwF0nGd+IU/vaF1jjDNDssxr5hjQa56jb/guVvqeNcwtKBr/JqXIhqdiiFrqbBGEo zwLn6pLdly3tWzgoxycTilZioAz762ppO8hUKUKnJS87nwMnVYhPXBYUyF0DmkdnT49f SZ752bWmGqTYqdfsPgrMfdpFZw82IyQwrANiQ8igB5hk+CkV7C89Ap/ZRe8ldh3WMjgO TVvZW41VUYQ2M1QR9g/m3pQXstEYQbd8/iHRoENYvpVEPHpHLR/KbBKruT23nuK9VOKy cc2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684290122; x=1686882122; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+tASGVUdkOe6w3QclEAM4IjqpZCGSuBlsuW/zkBugSc=; b=EqRWfdmXqU+H6X4p119zd/Ct+73S6y/TFizfemmA/nXfnPVIKp/VnFHdFI4Qmm2UEZ zsjjdlsQrVFV2fJNwKq6x+mCeZa92R3kYfk2q3wr1CRJOrGt7xg1oq1QAXio8uBHkZyP 0CUPYC6nX9bfJ8wxOg7TcGPqWLMKaikFvXD3o9tJrw2VfIZ0L9RmltzcsCIbaYW0DHZH QN7SjC4j4pptMqjtgJX0MZs8WhX60EMFYybs8SkGCfSD0KqrdrTOtfdu94O/+qtu5gQI kZiX2CsCCqz/fcHfYRVkP4Qt8io3YbYRKfhEMD1qtmFGYZfr7qGrtlm2M/mf1A2gsrt/ T0+Q== X-Gm-Message-State: AC+VfDx/KabRvXH5fexCw6AHykFuEyndE+4jNxCGcfh2xfiVRrUga38g +33hgyVF7BzehLi13MS65ilVnUr+JO+JRfiyMX0JSoiwfoMIQJg4t7U= X-Google-Smtp-Source: ACHHUZ7vek9kMpDg0sXuSDNgD1g8mtLKjUEHIw6ujZFO39JBJc/9nnnqybX556gBTAVEqeAAZPUyJ6/MDW2MRvoPxss= X-Received: by 2002:a17:90a:4611:b0:23d:3549:82b7 with SMTP id w17-20020a17090a461100b0023d354982b7mr37631893pjg.46.1684290121997; Tue, 16 May 2023 19:22:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Wed, 17 May 2023 10:21:51 +0800 Message-ID: Subject: Re: Re: RISC-V Test Errors and Failures To: Palmer Dabbelt , Vineet Gupta Cc: juzhe.zhong@rivai.ai, pinskia@gmail.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Palmer: For short-term, this should help your internal test: https://github.com/riscv-collab/riscv-gnu-toolchain/pull/1233 On Wed, May 17, 2023 at 10:20=E2=80=AFAM Kito Cheng = wrote: > > Currently we are highly rely on simulator can setup correctly by ELF > attribute or -march setting, but seems not true for everyone, for > longer term we need something like > check_effective_target_aarch64_sve_hw, but as Palmer point out, we > might need...bunch of that for different extensions.... > > On Wed, May 17, 2023 at 10:13=E2=80=AFAM Palmer Dabbelt wrote: > > > > On Tue, 16 May 2023 19:07:01 PDT (-0700), juzhe.zhong@rivai.ai wrote: > > > Oh, I see. Kito has add /* { dg-do run { target { riscv_vector } } } = */ > > > But not all RVV tests has use this and I not sure whether it can work= . > > > I think Kito can answer it. > > > If yes, I think we should add all of them. > > > > Unless I'm missing something, it looks like that only checks if GCC is > > compiling for V. Nothing appears to be checking if the system the test= s > > are running on supports V. > > > > # Return 1 if the target has RISC-V vector extension, 0 otherwise. > > # Cache the result. > > > > proc check_effective_target_riscv_vector { } { > > # Check that we are compiling for v by checking the __riscv_v m= arco. > > return [check_no_compiler_messages riscv_vector assembly { > > #if !defined(__riscv_v) > > #error "__riscv_v not defined!" > > #endif > > }] > > } > > > > Those are really just two different things. > > > > It seems pretty reasonably to me to just avoid running the tests when > > the DUT lacks V, but I'm never great with DG. We should probably add > > similar checks for the other ISA extensions, there's going to be a bunc= h > > of this. > > > > > > > > Thanks. > > > > > > > > > juzhe.zhong@rivai.ai > > > > > > From: Andrew Pinski > > > Date: 2023-05-17 10:02 > > > To: juzhe.zhong@rivai.ai > > > CC: gcc-patches; palmer; Kito.cheng > > > Subject: Re: RISC-V Test Errors and Failures > > > On Tue, May 16, 2023 at 6:58=E2=80=AFPM juzhe.zhong@rivai.ai > > > wrote: > > >> > > >> Hi, Palmer. > > >> I saw your patch showed there are a lot of run time fail (execution = fail) of C++. > > >> bug-*.C > > >> > > >> These tests are RVV api intrinsics tests coming from Kito's that I h= ave already fixed all of them. > > >> I just double checked again they all passed. > > >> I think it may be your regression environment does not set up simula= tor (QEMU or SPIKE or GEM5) correctly. > > >> For example, did not enable vector extension in simulator, I don't y= ou may try. > > > > > > So on x86_64, we test to see if you have the right vector unit before > > > running those tests? The same thing was true on powerpc (and I think > > > aarch64 does the same for SVE now too). The reason why I am asking is > > > that I would need to run the testsuite using the simulator as setup > > > for the RISCV ISA I am using rather than the one with everything on. > > > So does the RVV runtime testsuite tests to see if you can run RVV > > > before running them (or running them and return they passed)? > > > > > > Thanks, > > > Andrew Pinski > > > > > >> > > >> Thanks. > > >> > > >> > > >> juzhe.zhong@rivai.ai > > >