From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 228053857710 for ; Mon, 31 Jul 2023 14:53:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 228053857710 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-563dae89bc9so2664271a12.2 for ; Mon, 31 Jul 2023 07:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1690815188; x=1691419988; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZyYua7gmHearcPUZ/jAh5uppVCrRBxH5HmNzcA5S8tw=; b=jAHG+osA/FX5MDV39MdsA/i1w5k6cfqz37kfkCz9ZvZfOGkcOxndbPPfwO/MnkZLWV Wvs7bJinrYvz5Er1THgMnFjUPLqQrUh1yvNtMxT3ajko978bvHWGLpieL+1XDpBw1vPt BYpI267y05+lekm79Rs5Nr4znPeGoeVTbDGRRLx2F/s9f0DgfkUpxaNKddOJmrMjUF3o hUhdCMgca/Ec8TmUp8fvngO3JNNmnf/mNCdLe86heCHUN7qQ41Uj3y40BM8HZcN61Ezv 6nIFpkpgqLddXzMZBncCPWhgA4X5CtGCrH9ZNevDAbMDcftNF0Nx8K4zep7eA3EsqvnE VBIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690815188; x=1691419988; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZyYua7gmHearcPUZ/jAh5uppVCrRBxH5HmNzcA5S8tw=; b=PQe13DTklEEiIccBgLmNGlwAMNP6cU1qHQivs6Wt+LZgS5DkeGac5JlNfW8FWk21Gp uMJVFnMIBaLtV9yLfataRfuNV1PbI+bZVOVuiAOYiQIs2Sqh3uIj81qC+kHWqY8HbJSK Jqbl0HzSVtG+xYnmKAnrZuCgxoycywSB6sdope8IyPnojh9tyLY/cPvhp3nEETUGc34G 1KWBNDg75rwhdxN+EGZ2WxEwyFUuxbAJ/7hxD4I443Y/rdBy1NV9QPo/V6EJ20epuSfQ IbVb9h1LZJ970O6+oDA2IWP3tbNwgJmWoMjcYgMqNKh+plPlcU026M12B3Y1s5PHmcEg 4DXA== X-Gm-Message-State: ABy/qLa9g2068f3gzrjRL57GZzDZlvoU4IBNsK8jGFcYfOMayptsCCUn vANVZJ+5ol0qXfDZjWGeM748lzfOQSUPbtHwwLaAMg== X-Google-Smtp-Source: APBJJlEZnlddGzara4cTjhfxBmbnV7fL6g+86K13HAVuZs94t8VmycjKqcicunuBC9VAU7g9qWkhxEwGqHmAtZMCna8= X-Received: by 2002:a17:90a:6fa6:b0:262:e6c6:c2ec with SMTP id e35-20020a17090a6fa600b00262e6c6c2ecmr9005305pjk.33.1690815188651; Mon, 31 Jul 2023 07:53:08 -0700 (PDT) MIME-Version: 1.0 References: <20230731065228.69779-1-kito.cheng@sifive.com> In-Reply-To: From: Kito Cheng Date: Mon, 31 Jul 2023 22:52:57 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Return machine_mode rather than opt_machine_mode for get_mask_mode, NFC To: "Maciej W. Rozycki" Cc: Kito Cheng , juzhe.zhong@rivai.ai, gcc-patches , Robin Dapp , "pan2.li" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jul 31, 2023 at 10:03=E2=80=AFPM Maciej W. Rozycki wrote: > > On Mon, 31 Jul 2023, Kito Cheng wrote: > > > Sorry for disturbing, pushed a fix for that, and...added > > -Werror=3Dunused-variable to my build script to prevent that happen > > again :( > > I just configure with `--enable-werror-always', which we want to keep > our standards up to anyway, I rely on the host GCC which is 11 relatively old compared to the trunk, so --enable-werror-always will get many -Wformat* warning :( > but if you find this infeasible for some > reason with your workflow, then there's always an option to grep for > warnings in the build log and diff that against the previous iteration. That's a good suggestion! Thanks, let me try to apply myself workflow :) > > Maciej