From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id C40D73858D33 for ; Thu, 27 Apr 2023 15:00:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C40D73858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4ecb137af7eso9018020e87.2 for ; Thu, 27 Apr 2023 08:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1682607633; x=1685199633; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WRryHvXmi8GFy4f2GgYFh2y10sBSuum42eiZvZ9Aod0=; b=npKvIuRgRZU22XsO0fno8A6XCQpwGYOPVsKcdn1RkSvxoNfNyjb4gplWVTct/N+cvG rdKOc3Sm2/BdNDeFHU/442lLttvfzRpOMCSKWhbNNwm23cfJzMzt7LJeGTkVY/Ig0DJZ dLGzUrwH5X6P10zGr+VCYOj50UpXwcCaCDRErk3V/NPkaUvkROebELCRAWj9l/mZyIwV QE9bwYKdJ+II8Oa75rLloXl5IAr3/F+gnTW6Dz5RcQIAWPx+IJ07Rj1r6otRo/6PYMKX QzReaf3iIcoK7F0cT+SPsY5SXuFmD+eOtc8JuYw0DbYLUOWmDhO4D6+SZgG9kBMvVUq0 Wbiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682607633; x=1685199633; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WRryHvXmi8GFy4f2GgYFh2y10sBSuum42eiZvZ9Aod0=; b=KlvAyRTw1o2hTollkok1on3/+UllrJzCB2u+i7/9wPeh931NSxAGnof0e45zk7Pxlr W9zxba2XnDdqQMDytmhzvt1CD/jEFZghvHeasHXR2UcxMJDwtbfxgIw/UQhvr8nvPdgA xmdYcM/lVwVBs2K9eUCYmR49OtaAnm/K4jhSaX7qwkkpnHaK65I87FKn63hVtwkmOdgH 9idTYl3QRlC1xotsAbh7tlazx9LDpRsBzf7DbcsT62wbwQ5Nxma7u71FrQ+5THtlYKzX bpIf9fpCM0oBaBU5LOfcRG8Zv3oIhWxkEMjqQ1jbOJOzemZJtweerX9KUZ48akze4zJe +Zfg== X-Gm-Message-State: AC+VfDw4xHDb2/CdizIJ2GC7CxHTkIgFAS+UHQz8ToT1yngz3CpwZMTi ga3IHdsgytFPW69ybu70A2S4bno2iu/ZJ9JRvI35yg== X-Google-Smtp-Source: ACHHUZ6v0R74lioSape+n6o1Wa6OMMx0rVye/0g/ywa6K+eS3JQ4gHWsbhJJxr1gwQBrZQkLnfFeFFV8lh3B9rO9UvU= X-Received: by 2002:ac2:43bc:0:b0:4cb:13d7:77e2 with SMTP id t28-20020ac243bc000000b004cb13d777e2mr649806lfl.26.1682607633248; Thu, 27 Apr 2023 08:00:33 -0700 (PDT) MIME-Version: 1.0 References: <20230427143005.1781966-1-pan2.li@intel.com> In-Reply-To: From: Kito Cheng Date: Thu, 27 Apr 2023 23:00:21 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Allow RVV VMS{Compare}(V1, V1) simplify to VMCLR To: pan2.li@intel.com Cc: gcc-patches@gcc.gnu.org, juzhe.zhong@rivai.ai, yanzhang.wang@intel.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Could you try something like this? that should be more generic: > > (define_split > [(set (match_operand:VB 0 "register_operand") > (if_then_else:VB > (unspec:VB > [(match_operand:VB 1 "vector_all_trues_mask_operand") > (match_operand 4 "vector_length_operand") > (match_operand 5 "const_int_operand") > (match_operand 6 "const_int_operand") > (reg:SI VL_REGNUM) > (reg:SI VTYPE_REGNUM)] UNSPEC_VPREDICATE) > (match_operand:VB 3 "vector_move_operand") > (match_operand:VB 2 "vector_undef_operand")))] > "TARGET_VECTOR && reload_completed" Remove the reload_completed should work well, but you might need more test, I didn't run full test on this change :P > [(const_int 0)] > { > emit_insn (gen_pred_mov (mode, operands[0], CONST1_RTX (mode), > RVV_VUNDEF (mode), CONST0_RTX (mode), > operands[4], operands[5])); > DONE; > } > )