From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id F0ED2385840F for ; Fri, 24 Feb 2023 07:37:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0ED2385840F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-lf1-x130.google.com with SMTP id g17so4101801lfv.4 for ; Thu, 23 Feb 2023 23:37:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=N3/EnGb0PNH2r2kTjt3R3q+7tK5azN3nHPIKL99OVrk=; b=SM0JLewVQoykzGkX5Z9fikkoObmx+KtxUtoQ2Qj7xOxWElRY9IgSdl66zzzDpayYS0 bE9W11tmK8ixMSzKMOlebtqn3DcHF2dVo00AqI9iJzYZO0FSmn78qUq3haRgEBJf6CYi /RnlESxAEaaPZFNbafLuU5ju7ufmUxZH5BOfBTgZekjHEpqprdshntcvWJHUBqggbp3C 5rOQEByhPjtgM60i4KPCQim4IfrU8PWdnh+8ZvzayyFGyowwaPFUAlIw1QqJWxoopQvc O/T6mAvQaW8ZMpP13ABUTfoQTV45rEs9zQVdC/gs2IFFX5R5ItNPIHVE44GdPOe6Csrs 6Dbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N3/EnGb0PNH2r2kTjt3R3q+7tK5azN3nHPIKL99OVrk=; b=3O1lJSwUlvFE6D5dXzHGbTti+ofyo09m4EodKPawfNee5qzjKp5nn9Z9nqVMfjoDoh 4aWxxgiIUdDbs5GSW+fBQqgoF0zOGzrQdj/SoHpB2lluUTDs/YfVh5keSSMwgiuhX6fk GMPvDcWHdxor0sTbqNVzoSzCCFS5dB3XmTB1vpwSqIRGorxCmIph62m+kDsKDxZzAu7K BA8gFgA0VsqvNvP6JxbLaiQSLETfeH+2+tbNH6YLymYPsdoga9GtNe/UFLC4Qxc5XVNA nn5cKrtPQZBaDTiNWYLBLSPTnWx+O3d8Kw3EfkbrXkG9U0A0zm/ZuQJG/9gaJQCFnDaw qtow== X-Gm-Message-State: AO0yUKW2rXNzglX6YZv75NZ0fB6DEpus/Joom+U6sMoOR2s60N3l6J5U fkaHl6oBXZDIL63E/OfWVfUiNqVcC4jkaAp/rvTgSQ== X-Google-Smtp-Source: AK7set/ttLJXuOGB6SZoa2D6yFaePCZ1uO0JYsV1bkSz4+J/pustr4vJVZDgPnr/1ZX7RJIO2CiX1Wt92ztwx09JCJc= X-Received: by 2002:a05:6512:73:b0:4d5:ca42:e43a with SMTP id i19-20020a056512007300b004d5ca42e43amr4660410lfo.3.1677224230275; Thu, 23 Feb 2023 23:37:10 -0800 (PST) MIME-Version: 1.0 References: <20230224055127.2500953-1-christoph.muellner@vrull.eu> <20230224055127.2500953-5-christoph.muellner@vrull.eu> In-Reply-To: <20230224055127.2500953-5-christoph.muellner@vrull.eu> From: Kito Cheng Date: Fri, 24 Feb 2023 15:36:59 +0800 Message-ID: Subject: Re: [PATCH v3 04/11] riscv: thead: Add support for the XTheadBs ISA extension To: Christoph Muellner Cc: gcc-patches@gcc.gnu.org, Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Jeff Law , Cooper Qu , Lifang Xia , Yunhai Shang , Zhiwei Liu Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > diff --git a/gcc/config/riscv/thead.md b/gcc/config/riscv/thead.md > index 158e9124c3a..2c684885850 100644 > --- a/gcc/config/riscv/thead.md > +++ b/gcc/config/riscv/thead.md > @@ -29,3 +29,14 @@ (define_insn "*th_addsl" > "th.addsl\t%0,%3,%1,%2" > [(set_attr "type" "bitmanip") > (set_attr "mode" "")]) > + > +;; XTheadBs > + > +(define_insn "*th_tst" > + [(set (match_operand:X 0 "register_operand" "=r") > + (zero_extract:X (match_operand:X 1 "register_operand" "r") > + (const_int 1) > + (match_operand 2 "immediate_operand" "i")))] > + "TARGET_XTHEADBS" Add range check like *bexti pattern? TARGET_XTHEADBS && UINTVAL (operands[2]) < GET_MODE_BITSIZE (mode) > + "th.tst\t%0,%1,%2" > + [(set_attr "type" "bitmanip")])