From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id 1AFE83858C60 for ; Thu, 2 Feb 2023 13:30:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1AFE83858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-lf1-x133.google.com with SMTP id bp15so2921181lfb.13 for ; Thu, 02 Feb 2023 05:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+JTKv3foIK/HrnldgADU9xD9GrQhpKxV6j0IAnMoYME=; b=Y2HTEhqVgUJ4LHTzfizCrQ8s9275uQKe0PBmvg5gvB90793HYf4MTQw9Tzq9bVjS4A xlzDvtE02X3GanC0kt9r0EgKAoDPo+be+/nu1dB6I95HL2u0Uq8CGjt/eaN8Zh6RxEFl 3VwWRNAgT6vcu9NeCTCXU3NbLo/3N4J4faqrQGtDqHUZ5zksIOtMgvo4rcWu38evOv+U 9huV7b1eQN7QnMvmLmAiswzKYMDt2kUK2iYg0Y4UDZCboR12jqhB6eqcnBViwRCdfdFV UEjs/Mo5l5HT82V5+AX6Q5LNcWOcPNBqNAkb4hMuSvsiOz+EH+9MF+9GSZFrlHQdU9oV F7bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+JTKv3foIK/HrnldgADU9xD9GrQhpKxV6j0IAnMoYME=; b=e5Dgv5Okay7Ef7/3EiPCJzTUD6/Hr8IySZhffi/F/nCGmrlUPAj93UizZXqslSLshu DDpTWKiOl4YrfDyqUr6QRUa2EO6vb2eE315eAAbI5Uf0h3NzIMiLwZFP1zGzi8TcM7nZ nBGEdbpB2niNNWKzRxgkiG9tYGvcq+bTlikmUWrVGjbnRosW++maJXTKSBChEn4W8emB /LpAFEkeUPB4q13dpuzN0bhCk2ia5yBvaydR1jy168vbDZZaZnNuYg8Uo4Vuw7R9AXnG NKCF9fMf91IbAYnMtBD8zsifV1O9iwPzL1ugGDxE7U+PcJBn0SEkmQ23MXH+PoCDjwbY tj4A== X-Gm-Message-State: AO0yUKX5JRNLt7i78oA3jPCPa2rlc51UfOGFtQ6mRBwirptK54VHbmfW jv4ayVJwDIyvzEymQdfnifpvd6E6zLbuD1oqFXFSHw== X-Google-Smtp-Source: AK7set8w3/apWe3k/YH9q45hoD4dDLEtOR492S29O8cmesGLoUvmnkzCPSVOVzuPV/7CH3FUvFfKJTfrvMAgLZQ4OQc= X-Received: by 2002:a05:6512:962:b0:4b5:7290:3dd8 with SMTP id v2-20020a056512096200b004b572903dd8mr1311138lft.254.1675344629834; Thu, 02 Feb 2023 05:30:29 -0800 (PST) MIME-Version: 1.0 References: <20230202114604.2059-1-jinma@linux.alibaba.com> In-Reply-To: <20230202114604.2059-1-jinma@linux.alibaba.com> From: Kito Cheng Date: Thu, 2 Feb 2023 21:30:18 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Fix bug of TARGET_COMPUTE_MULTILIB implemented in riscv. To: Jin Ma Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com, palmer@dabbelt.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Good catch! thanks for fixing that, committed to trunk :) On Thu, Feb 2, 2023 at 7:46 PM Jin Ma wrote: > > MAX_MATCH_SCORE is not assigned anywhere except initialized to 0, > causing BEST_MATCH_MULTI_LIB to always be 0 or -1, which will > cause the result of TARGET_COMPUTE_MULTILIB hook to fail. > > gcc/ChangeLog: > > * common/config/riscv/riscv-common.cc: > --- > gcc/common/config/riscv/riscv-common.cc | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc > index 616e2f897b9..787674003cb 100644 > --- a/gcc/common/config/riscv/riscv-common.cc > +++ b/gcc/common/config/riscv/riscv-common.cc > @@ -1700,7 +1700,10 @@ riscv_compute_multilib ( > > /* Record highest match score multi-lib setting. */ > if (match_score > max_match_score) > - best_match_multi_lib = i; > + { > + best_match_multi_lib = i; > + max_match_score = match_score; > + } > } > > if (best_match_multi_lib == -1) > -- > 2.17.1 >