From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 902F83858028 for ; Mon, 31 Jul 2023 02:57:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 902F83858028 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-563d3e4f73cso2202436a12.3 for ; Sun, 30 Jul 2023 19:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1690772266; x=1691377066; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fCOFti+9dYlhUEdCQcdViIAJsQXDcvZ/ia9iJuxw1Vo=; b=UhTYcpgaH4LHhu61hEWF9e/RpgUCbR97r0dlXtT+ZfvKHpWM89VJhWAVm28gy1AaGo Iz3rlMW1TVJI5v2cTqBbSzV1QReeU5sLtGBZy+0iP3oyXkdp3UbYdzfsTS9+kJbRfF03 aP2YQMz5LM2X5/onze2Ppacnv4QwdK4ciGYhPcfC/8mQt8JxJEpNRmSOY9qC5UM6kFRI MX6R3H11tcmLKffymSclpoE2aVYT+HDjZHV+jnzswIIDrg6ZZGbZ7dGcY5w1JAwzaDp/ QB2k4OvZy1D3ijRs4LCicYutWxma1PoGmSkgcjAoYlL2kjtZujsCNxl3STAa3JpxRt/x gVHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690772266; x=1691377066; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fCOFti+9dYlhUEdCQcdViIAJsQXDcvZ/ia9iJuxw1Vo=; b=iuFJlVss6tbSWtKHhaoSrmCTlQ0Tw8SMmi5HsoGPBes/GeVmGrtjzZubLyKT8LZGBd Yd17hz8v9WuSdwnJGCKYSXKrb29GfDcZUrNKreGpOuUsYA7NEN0t+zk8S67hwMVBepeO /AnANGjU1/j0UQ30xWB1o81xyldasFxAaowxy4UXJ/uLfv+m2nj/4ZRgx4XWZ+pP8m2F zrh39TTT6PwL8ALt3ekrQjRhAYDrFPvSOjDRbPAF5fbXLB2Lb6w3U6VcTg13mM7iIgPZ Wq+51VMLS79TY12Xhi3Y/krBtFephAbwm/aFfveq+LNNXpOKLgsVWAYHXK5aKnWxPeGc ibrQ== X-Gm-Message-State: ABy/qLaO1V6Xz6n+IhVjqHA8CmnMDPeFfSObZQ7ufc40SmXB3zYBu9hY k/t0VXuM+Zt/F+i2PCSIK8HGHtiDM7mT7hwoO2zEsg== X-Google-Smtp-Source: APBJJlGexjU2Tm1X0uoMEOTIlQoTyIRjNPg2GZI2hbceHa3wrSEjbcfErRvkRU6ZzXvxNQLK1Rjw13OleSAAUAZO0ug= X-Received: by 2002:a17:90b:380b:b0:260:9cad:c56d with SMTP id mq11-20020a17090b380b00b002609cadc56dmr7261300pjb.7.1690772266442; Sun, 30 Jul 2023 19:57:46 -0700 (PDT) MIME-Version: 1.0 References: <20230731025646.1021646-1-pan2.li@intel.com> In-Reply-To: <20230731025646.1021646-1-pan2.li@intel.com> From: Kito Cheng Date: Mon, 31 Jul 2023 10:57:35 +0800 Message-ID: Subject: Re: [PATCH v1] RISC-V: Bugfix for RVV floating-point rm suffix sequence To: pan2.li@intel.com Cc: gcc-patches@gcc.gnu.org, juzhe.zhong@rivai.ai, yanzhang.wang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: lgtm On Mon, Jul 31, 2023 at 10:56=E2=80=AFAM wrote: > > From: Pan Li > > According to below RVV intrinsic doc, the RVV floating-point intrinsic na= me > with rounding mode should be: > > _rm_m > > instead of: > > _m_rm > > https://github.com/riscv-non-isa/rvv-intrinsic-doc/pull/226 > > This patch fix this naming sequence issue and adjust the test cases. > > Signed-off-by: Pan Li > > gcc/ChangeLog: > > * config/riscv/riscv-vector-builtins-shapes.cc (struct alu_frm_de= f): > Move rm suffix before mask. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/base/float-point-frm-insert-1.c: Adjust > test cases. > * gcc.target/riscv/rvv/base/float-point-frm.c: Ditto. > --- > gcc/config/riscv/riscv-vector-builtins-shapes.cc | 10 +++++----- > .../riscv/rvv/base/float-point-frm-insert-1.c | 14 +++++++------- > .../gcc.target/riscv/rvv/base/float-point-frm.c | 16 ++++++++-------- > 3 files changed, 20 insertions(+), 20 deletions(-) > > diff --git a/gcc/config/riscv/riscv-vector-builtins-shapes.cc b/gcc/confi= g/riscv/riscv-vector-builtins-shapes.cc > index 22b5fe256df..6af57c22bfb 100644 > --- a/gcc/config/riscv/riscv-vector-builtins-shapes.cc > +++ b/gcc/config/riscv/riscv-vector-builtins-shapes.cc > @@ -261,6 +261,11 @@ struct alu_frm_def : public build_base > b.append_name (type_suffixes[instance.type.index].vector); > } > > + /* According to rvv-intrinsic-doc, it does not add "_rm" suffix > + for vop_rm C++ overloaded API. */ > + if (!overloaded_p) > + b.append_name ("_rm"); > + > /* According to rvv-intrinsic-doc, it does not add "_m" suffix > for vop_m C++ overloaded API. */ > if (overloaded_p && instance.pred =3D=3D PRED_TYPE_m) > @@ -268,11 +273,6 @@ struct alu_frm_def : public build_base > > b.append_name (predication_suffixes[instance.pred]); > > - /* According to rvv-intrinsic-doc, it does not add "_rm" suffix > - for vop_rm C++ overloaded API. */ > - if (!overloaded_p) > - b.append_name ("_rm"); > - > return b.finish_name (); > } > > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-inse= rt-1.c b/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-insert-1.c > index 608b3883dd0..d6c5e1bddd6 100644 > --- a/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-insert-1.c > +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm-insert-1.c > @@ -11,20 +11,20 @@ test_riscv_vfadd_vv_f32m1_rm (vfloat32m1_t op1, vfloa= t32m1_t op2, size_t vl) { > } > > vfloat32m1_t > -test_vfadd_vv_f32m1_m_rm(vbool32_t mask, vfloat32m1_t op1, vfloat32m1_t = op2, > +test_vfadd_vv_f32m1_rm_m (vbool32_t mask, vfloat32m1_t op1, vfloat32m1_t= op2, > size_t vl) { > - return __riscv_vfadd_vv_f32m1_m_rm(mask, op1, op2, 1, vl); > + return __riscv_vfadd_vv_f32m1_rm_m (mask, op1, op2, 1, vl); > } > > vfloat32m1_t > -test_vfadd_vf_f32m1_rm(vfloat32m1_t op1, float32_t op2, size_t vl) { > - return __riscv_vfadd_vf_f32m1_rm(op1, op2, 2, vl); > +test_vfadd_vf_f32m1_rm (vfloat32m1_t op1, float32_t op2, size_t vl) { > + return __riscv_vfadd_vf_f32m1_rm (op1, op2, 2, vl); > } > > vfloat32m1_t > -test_vfadd_vf_f32m1_m_rm(vbool32_t mask, vfloat32m1_t op1, float32_t op2= , > - size_t vl) { > - return __riscv_vfadd_vf_f32m1_m_rm(mask, op1, op2, 3, vl); > +test_vfadd_vf_f32m1_rm_m (vbool32_t mask, vfloat32m1_t op1, float32_t op= 2, > + size_t vl) { > + return __riscv_vfadd_vf_f32m1_rm_m (mask, op1, op2, 3, vl); > } > > /* { dg-final { scan-assembler-times {vfadd\.v[vf]\s+v[0-9]+,\s*v[0-9]+,= \s*[fav]+[0-9]+} 4 } } */ > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm.c b/= gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm.c > index 95271b2c822..1f142605cc3 100644 > --- a/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm.c > +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/float-point-frm.c > @@ -11,20 +11,20 @@ test_riscv_vfadd_vv_f32m1_rm (vfloat32m1_t op1, vfloa= t32m1_t op2, size_t vl) { > } > > vfloat32m1_t > -test_vfadd_vv_f32m1_m_rm(vbool32_t mask, vfloat32m1_t op1, vfloat32m1_t = op2, > - size_t vl) { > - return __riscv_vfadd_vv_f32m1_m_rm(mask, op1, op2, 0, vl); > +test_vfadd_vv_f32m1_rm_m (vbool32_t mask, vfloat32m1_t op1, vfloat32m1_t= op2, > + size_t vl) { > + return __riscv_vfadd_vv_f32m1_rm_m (mask, op1, op2, 0, vl); > } > > vfloat32m1_t > -test_vfadd_vf_f32m1_rm(vfloat32m1_t op1, float32_t op2, size_t vl) { > - return __riscv_vfadd_vf_f32m1_rm(op1, op2, 0, vl); > +test_vfadd_vf_f32m1_rm (vfloat32m1_t op1, float32_t op2, size_t vl) { > + return __riscv_vfadd_vf_f32m1_rm (op1, op2, 0, vl); > } > > vfloat32m1_t > -test_vfadd_vf_f32m1_m_rm(vbool32_t mask, vfloat32m1_t op1, float32_t op2= , > - size_t vl) { > - return __riscv_vfadd_vf_f32m1_m_rm(mask, op1, op2, 0, vl); > +test_vfadd_vf_f32m1_rm_m (vbool32_t mask, vfloat32m1_t op1, float32_t op= 2, > + size_t vl) { > + return __riscv_vfadd_vf_f32m1_rm_m (mask, op1, op2, 0, vl); > } > > /* { dg-final { scan-assembler-times {vfadd\.v[vf]\s+v[0-9]+,\s*v[0-9]+,= \s*[fav]+[0-9]+} 4 } } */ > -- > 2.34.1 >