From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 8E4563858D1E for ; Wed, 17 May 2023 02:20:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E4563858D1E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-2533d74895bso300189a91.0 for ; Tue, 16 May 2023 19:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1684290056; x=1686882056; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5dzRS7bVO5sVuMtty0KTuYcQHHaHEpc5Q4j3WRGI2oA=; b=NwcsI7K/agNOP7gBRfsKv6AR0PIvSgXq4+B8uDSPGtNLk0+ZeSye4tsgBWueu8HbdK rxgBlSdjTrsZvR2+LM0HNqy9CPWuABsymoGM+J/SAnebHoUAwq8S88OQKDkK6bPbK3dE hXAgkK8CPD3YiF0YWl8BWrl5t50yo+AOTUheFRa43wjTdowOcmQl97DljyF6FbVU9vGk eMYKXr7Tq9Sn9U7f7SvNjZA1ubdxpvvYUFD9T5+9c/3J5tX2dJkHSpAwSipfliHfI2Np yI/YJinTbcRAGEY3lb2CV/+i4CEBzb/6N7Ey0NWR0HIeUro0MUgxudRtmT9usZHQKy+P a6jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684290056; x=1686882056; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5dzRS7bVO5sVuMtty0KTuYcQHHaHEpc5Q4j3WRGI2oA=; b=AAleUcKtcX/zx2ocsgPNEmrraoXjXoY5c7I6gePNd7C6QNW78dv2NvKMd5ZJ5gb3xu X5TaQN2PK1ACm9IGTGLDJjc/au4mCGE7GcwehhD/mEnhUAHUMuM0fN7SB/6MI3ZVD/va O5w/SLDgUzYku47NmiB62G3CdHU0XAbbkbD6FvF/L/iPUqFFg5SuhxXd5TDzSwu/YIyf B25UcB0/qIviobcLfIIWR0X3HQJw/oSiRGBl5C2WJHO1HmNzxmS7LGvjenJ4oEZ9dIKM /gpuoR5ISktvRLbDsa3Qq00kTY7JVzRzZwGJ44Wh4wFY4rNBS51GVYFts40x61oOF3mB HQ0w== X-Gm-Message-State: AC+VfDxvLRSYfCHxPUK649QinHA2ENMWqiZwKfooFnJfFOugwXw+V2Y1 Z3sxpPL9VuXNiG7P79OZ1zjJhL0r2WzvYMvjYzdNYQ== X-Google-Smtp-Source: ACHHUZ4UmUBRbO+I1IJAiVEbwJ5Ez3Xa5vw4RJQGS7zTYmNkiooRObeYdyMlZlef2mLhh0xF0JxH8wYlT5/bVWMWfic= X-Received: by 2002:a17:90a:f18f:b0:24b:7618:2d16 with SMTP id bv15-20020a17090af18f00b0024b76182d16mr40257732pjb.31.1684290056392; Tue, 16 May 2023 19:20:56 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Wed, 17 May 2023 10:20:45 +0800 Message-ID: Subject: Re: Re: RISC-V Test Errors and Failures To: Palmer Dabbelt Cc: juzhe.zhong@rivai.ai, pinskia@gmail.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Currently we are highly rely on simulator can setup correctly by ELF attribute or -march setting, but seems not true for everyone, for longer term we need something like check_effective_target_aarch64_sve_hw, but as Palmer point out, we might need...bunch of that for different extensions.... On Wed, May 17, 2023 at 10:13=E2=80=AFAM Palmer Dabbelt wrote: > > On Tue, 16 May 2023 19:07:01 PDT (-0700), juzhe.zhong@rivai.ai wrote: > > Oh, I see. Kito has add /* { dg-do run { target { riscv_vector } } } */ > > But not all RVV tests has use this and I not sure whether it can work. > > I think Kito can answer it. > > If yes, I think we should add all of them. > > Unless I'm missing something, it looks like that only checks if GCC is > compiling for V. Nothing appears to be checking if the system the tests > are running on supports V. > > # Return 1 if the target has RISC-V vector extension, 0 otherwise. > # Cache the result. > > proc check_effective_target_riscv_vector { } { > # Check that we are compiling for v by checking the __riscv_v mar= co. > return [check_no_compiler_messages riscv_vector assembly { > #if !defined(__riscv_v) > #error "__riscv_v not defined!" > #endif > }] > } > > Those are really just two different things. > > It seems pretty reasonably to me to just avoid running the tests when > the DUT lacks V, but I'm never great with DG. We should probably add > similar checks for the other ISA extensions, there's going to be a bunch > of this. > > > > > Thanks. > > > > > > juzhe.zhong@rivai.ai > > > > From: Andrew Pinski > > Date: 2023-05-17 10:02 > > To: juzhe.zhong@rivai.ai > > CC: gcc-patches; palmer; Kito.cheng > > Subject: Re: RISC-V Test Errors and Failures > > On Tue, May 16, 2023 at 6:58=E2=80=AFPM juzhe.zhong@rivai.ai > > wrote: > >> > >> Hi, Palmer. > >> I saw your patch showed there are a lot of run time fail (execution fa= il) of C++. > >> bug-*.C > >> > >> These tests are RVV api intrinsics tests coming from Kito's that I hav= e already fixed all of them. > >> I just double checked again they all passed. > >> I think it may be your regression environment does not set up simulato= r (QEMU or SPIKE or GEM5) correctly. > >> For example, did not enable vector extension in simulator, I don't you= may try. > > > > So on x86_64, we test to see if you have the right vector unit before > > running those tests? The same thing was true on powerpc (and I think > > aarch64 does the same for SVE now too). The reason why I am asking is > > that I would need to run the testsuite using the simulator as setup > > for the RISCV ISA I am using rather than the one with everything on. > > So does the RVV runtime testsuite tests to see if you can run RVV > > before running them (or running them and return they passed)? > > > > Thanks, > > Andrew Pinski > > > >> > >> Thanks. > >> > >> > >> juzhe.zhong@rivai.ai > >