From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-506303-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 8079 invoked by alias); 6 Aug 2019 03:19:20 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 7964 invoked by uid 89); 6 Aug 2019 03:19:19 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mail-qt1-f196.google.com
Received: from mail-qt1-f196.google.com (HELO mail-qt1-f196.google.com) (209.85.160.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Aug 2019 03:18:11 +0000
Received: by mail-qt1-f196.google.com with SMTP id w17so2532593qto.10        for <gcc-patches@gcc.gnu.org>; Mon, 05 Aug 2019 20:18:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=sifive.com; s=google;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=T6VVQu6VqG6LihyP7zPBaSWBZa756fHIjBn3BU2jrSQ=;        b=LLzF3Bn+zY0yYytXn7poM+QoYkRq2qL3kGsqn1m6lGam8uH5zBa5Wne8Z+UwQRIcsK         iRsIC5Q0S4MrOxxUunJVdudQS102Bcqj1nIov46waoSPtBTjihNPVSrvUQam8H8Ug5oc         cCgpMuYn+6aIqhDT3PQUFMOsNwVr9CIoxLrSizx0h6bpMgm6c6+Ma5CyTZSHpgJGv0nv         m7RUs7S3T1Lk9DPG0CEIgFDWF6k84sKm8reEXAeK3/lsmvcdFOc6JiaNgbRUnuKzHKhB         jupIn642YusmsD1HTt+bhSJxncTXqALu3SZimqW1+HdxySM5NbbVVM31QNhgUrO8uP87         l9kw==
MIME-Version: 1.0
References: <20190805082017.26702-1-kito.cheng@sifive.com> <CAFyWVaY+9rYVDHHEH+r7qKgf7nwYhpTZVi=gzLQnk97MbSCROw@mail.gmail.com>
In-Reply-To: <CAFyWVaY+9rYVDHHEH+r7qKgf7nwYhpTZVi=gzLQnk97MbSCROw@mail.gmail.com>
From: Kito Cheng <kito.cheng@sifive.com>
Date: Tue, 06 Aug 2019 07:05:00 -0000
Message-ID: <CALLt3TivijX4cv4ZUM=uzeEZOLpodWXr1dJJqR8X61nUKhCruw@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: Handle extensions combination correctly in multilib-generator.
To: Jim Wilson <jimw@sifive.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Kito Cheng <kito.cheng@gmail.com>, 	Palmer Dabbelt <palmer@sifive.com>
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2019-08/txt/msg00348.txt.bz2

Hi Jim. Andreas:

Thanks your review :)

Committed with English improvements and ChangeLog update as r274137

On Tue, Aug 6, 2019 at 5:48 AM Jim Wilson <jimw@sifive.com> wrote:
>
> On Mon, Aug 5, 2019 at 1:20 AM Kito Cheng <kito.cheng@sifive.com> wrote:
> > gcc/ChangeLog
> >         * gcc/config/riscv/multilib-generator: Handle extensions
> >         combination correctly.
>
> A ChangeLog entry should generally describe what a patch changes, not
> what it does.  So this should mention a new variable canonical_order,
> a new function arch_canonicalize, and the call to pass alts through
> it.
>
> > +    raise Exception("Unexpect arch: `%d`" % arch[:5])
>
> Unexpect -> Unexpected
>
> > +  long_ext_prefixs = ['z', 's', 'h', 'x']
>
> prefixs -> prefixes
>
> > +  # Concat rest multi-char extensions.
>
> rest multi-char -> rest of the multi-char
>
> This looks good to me with the minor English improvements Andreas and
> I suggested.
>
> Jim