From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id 52C98385B513 for ; Fri, 24 Feb 2023 09:46:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 52C98385B513 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-lf1-x12a.google.com with SMTP id m7so17100968lfj.8 for ; Fri, 24 Feb 2023 01:46:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IuDMy+P7z5fZvnppRP6zyWRcUVaP2iEdYRBQTTONSTk=; b=bBEVggHSWjRqHsVuXWkipx6dhjmt3HeCTYdCHgaRrsSJ3wL+pkFYxFezAnYgFRQUM/ foWFV4nlZqXw10yPCkXjJXT5F11Y/2omo7PJg/acSHdCBgI8d+DeImws151biD5nbKy0 +3wz2EPbvKdmuSKvTHDM2VyUOJOEuMYuEFOUpSPZlh0zoYu0QGadMM+Q9xDeCrtEU/Et 5dI7D8GK64hCDJ8XP2aXKe96GEV3QxMBuasHjtyj9DHXIU3C9FuX9MgmDFF/h9wd1QhM uBR/6ImhiV4MGtSLAsNMDItdtTqU8vMwk56j67ETcVfQbAVtYSrFmP9ldK0kPlOUNTIz itIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IuDMy+P7z5fZvnppRP6zyWRcUVaP2iEdYRBQTTONSTk=; b=W31M4KFFaioI/Vx1s4nWku2DxTxjKOWC3qNr9IN0EUmoqVPrzo56XScqvWOADSYs+x vZF9rN8dsPVBm6zxRG9F7AYUhl+WGx2OozNDk/pL1nkkw2zH+V2zuGwe+muT8nOHoaNh TfD7oy+xLMG4Lp5iE5JrtMGsOCgXhduMfjEsBPiDFDL8V+0GsuwBVHPnCCL+5RX974zl /MEHnea+C254a831Oq+5WSYy8VoFh79xO3eHqJDx9zvnOdu85jGl9aL8u1k/5LUNtyyq HqAiVGPll1czGKHp43Mg0X3lIRgBdjqUs5OwTMlQ7jNAr4p3UolyOtDrOzrx38V+3tQd SSTg== X-Gm-Message-State: AO0yUKUgtrdu/n+or4rKrYjtl7RTPzA2QOWdqDQO9ZhVJJlPBGCNThHY uGmfh9o6TQT71PrRIb3mRly7Hd2L/RjxS1rrbVHW2Q== X-Google-Smtp-Source: AK7set/JOGktIaU9QJDm6EzBK3nO8Y4AfweSwmlZAki1xclWijhDAfxdiyhT30gwmRO1mLSI4vqQv+gQ9C31n7ctV/0= X-Received: by 2002:a19:ac41:0:b0:4db:1a0d:f261 with SMTP id r1-20020a19ac41000000b004db1a0df261mr2836458lfc.3.1677232001006; Fri, 24 Feb 2023 01:46:41 -0800 (PST) MIME-Version: 1.0 References: <20230224055127.2500953-1-christoph.muellner@vrull.eu> <20230224055127.2500953-12-christoph.muellner@vrull.eu> In-Reply-To: From: Kito Cheng Date: Fri, 24 Feb 2023 17:46:29 +0800 Message-ID: Subject: Re: [PATCH v3 11/11] riscv: thead: Add support for the XTheadFMemIdx ISA extension To: Christoph Muellner Cc: gcc-patches@gcc.gnu.org, Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Jeff Law , Cooper Qu , Lifang Xia , Yunhai Shang , Zhiwei Liu , "moiz.hussain" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > > +(define_memory_constraint "Qmx" > > + "@internal > > + An address valid for GPR." > > + (and (match_code "mem") > > + (match_test "!riscv_legitimize_address_index_p ( > > + XEXP (op, 0), GET_MODE (op), false)"))) > > Check TARGET_XTHEADFMEMIDX, and I don't quite understand why it I changed my mind, don't check TARGET_XTHEADFMEMIDX here, check ext in the pattern instead.